foo_keep_queue |
  |
foo_keep_queue |
 Nov 11 2010, 04:56
Post
#26
|
|
 Group: FB2K Moderator Posts: 2359 Joined: 30-November 07 Member No.: 49158  |
Carpman's crash happens in the destructor of "static pfc::list_t<t_playback_queue_item> queue_backup", because the t_playback_queue_item.m_handle is invalid, but not NULL - probably points to an already released memory.
That certainly should not happen, metadb_handles are reference counted for a reason. I can only guess, maybe some other component releases a handle too many times? Might be also that one of the callbacks forwarded to backup_queue() gets called after cleaning the queue_backup in on_quit(), therefore filling it again, possibly leaving a stray pointer around again. I don't know and it's hard to guess. So anyway, it might be a good idea to not hold any references to metadb_handles, services or other shared objects till DLL unload, so I'd suggest having maybe a global flag like "bool g_shutting_down", which would ensure nothing would be done after on_quit() and see if that helped. And perhaps explicitely destroying the queue_pos array too, in case there is anything left there. Additionally, better don't include the 3 MB Debug\foo_keep_queue.ilk and testing fb2k install in your source code package, it's unnecessarily large then. If anything, including a .pdb file for the release would be more useful. -------------------- Full-quoting makes you scroll past the same junk over and over.
|
 |
 
|
|
Nov 11 2010, 14:58
Post
#27
|
|
|
Group: Developer Posts: 24 Joined: 5-November 10 From: Sweden Member No.: 85218 |
Thanks for the info Yirkha. I'll implement your suggestion. :) (Coding tips and thoughts always appreciated.)
That "source" package was mostly for my self I guess. And I did some clean on the project before packing, but seem it leaves some stuff behind. The next one will be lighter. ^^ |
|
|
|
|
Nov 11 2010, 15:41
Post
#28
|
|
|
Group: Developer Posts: 24 Joined: 5-November 10 From: Sweden Member No.: 85218 |
foo_keep_queue v0.3.3
Update includes:
Download: foo_keep_queue 0.3.3 Source: src (If some moderator could update the first post with these links it would be nice.) |
|
|
|
|
Nov 11 2010, 16:23
Post
#29
|
|
 Group: Developer Posts: 1217 Joined: 27-June 07 Member No.: 44789 |
Thanks for the update Qtax. Works for me! No crashes.
 Cheers, C. -------------------- TAK -p4m :: LossyWAV -q 6 | TAK :: Lame 3.98 -V 2
|
|
|
|
|
Nov 11 2010, 17:00
Post
#30
|
|
|
Group: Members Posts: 7 Joined: 20-February 10 Member No.: 78315 |
Hey, love this component, have been missing it ever since i switched over from winamp. Just wanted to note that the queue gets cleared when playing a 'next random' track (Playback > Random). Keep up the good work!
|
|
|
|
 Nov 11 2010, 17:40
Post
#31
|
|
 Group: Members Posts: 2771 Joined: 12-November 06 Member No.: 37463 |
Thanx for this, it's useful
 (no crash for now, foobar 1.1.1 under Seven x64) -------------------- http://br3tt.online.fr/
|
|
|
|
|
Nov 11 2010, 21:42
Post
#32
|
|
|
Group: Developer Posts: 24 Joined: 5-November 10 From: Sweden Member No.: 85218 |
QUOTE (lsn @ Nov 11 2010, 17:00)  Hey, love this component, have been missing it ever since i switched over from winamp. Just wanted to note that the queue gets cleared when playing a 'next random' track (Playback > Random). Keep up the good work! Thanks, and same reason I made this, been missing it ever since switching from winamp.  Didn't know about this random clearing feature, will have a look at it. |
|
|
|
|
Nov 12 2010, 05:17
Post
#33
|
|
|
Group: Developer Posts: 24 Joined: 5-November 10 From: Sweden Member No.: 85218 |
New version released, 0.3.5. A fix for clearing on random song, reported by lsn.
Now also available in the components repository: http://www.foobar2000.org/components/view/foo_keep_queue |
|
|
|
|
Nov 12 2010, 08:52
Post
#34
|
|
|
Group: Members Posts: 7 Joined: 20-February 10 Member No.: 78315 |
QUOTE (Qtax @ Nov 12 2010, 06:17) New version released, 0.3.5. A fix for clearing on random song, reported by lsn. Now also available in the components repository: http://www.foobar2000.org/components/view/foo_keep_queue Props for the good work! You've got my support |
|
|
|
|
Nov 12 2010, 13:50
Post
#35
|
|
|
Group: Members Posts: 6 Joined: 18-October 09 Member No.: 74100 |
hey
i just downloaded this and i get this message: QUOTE Failed to load DLL: foo_keep_queue.dll Reason: This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem. tell me how can i help you to help me
|
|
|
|
|
Nov 12 2010, 14:54
Post
#36
|
|
|
Group: Developer Posts: 24 Joined: 5-November 10 From: Sweden Member No.: 85218 |
QUOTE Failed to load DLL: foo_keep_queue.dll Reason: This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem. Try removing "foo_keep_queue.dll.cfg", it should in foorbars configuration folder. Other than that I have no idea what might cause this. |
|
|
|
|
Nov 12 2010, 15:17
Post
#37
|
|
|
Group: Members Posts: 151 Joined: 12-May 04 Member No.: 14050 |
Thank you for this component. This is something I've wanted for a long time.
|
|
|
|
|
Nov 12 2010, 18:00
Post
#38
|
|
|
Group: Members Posts: 6 Joined: 18-October 09 Member No.: 74100 |
QUOTE (Qtax @ Nov 12 2010, 15:54) Try removing "foo_keep_queue.dll.cfg", it should in foorbars configuration folder. Other than that I have no idea what might cause this. there's no "foo_keep_queue.dll.cfg" in the config folder  i can try disabling other plugins i have in my components folder, to see if any of them is causing problems. to eliminate them one by one.. i'll let you know if that helped asap. i can also try using older versions of your plugin. |
|
|
|
|
Nov 12 2010, 23:56
Post
#39
|
|
|
Group: Members Posts: 1013 Joined: 4-January 09 Member No.: 65169 |
QUOTE (pyrotechnician @ Nov 12 2010, 01:50) i just downloaded this and i get this message: QUOTE Failed to load DLL: foo_keep_queue.dll Reason: This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem. @ pyrotechnician, probably you have to install a particular version of the Microsoft Visual C++ Redistributable Package. Read here how the Windows event viewer can tell you more. If you are missing another assembly than that mentioned in the post I linked to an Internet search will tell you what runtimes you need. @ Qtax, fbuser explained here how to avoid this problem. EDIT: I am a slave to my poor English. This post has been edited by Robertina: Nov 13 2010, 00:02 |
|
|
|
|
Nov 13 2010, 16:36
Post
#40
|
|
 Group: Members Posts: 1684 Joined: 28-May 06 From: Düsseldorf Member No.: 31251 |
Wouldn't the message then be:
"This component is missing a required dependency, or was made for different version of foobar2000" -------------------- german support forum: www.foobar-users.de / user: qwert73
|
|
|
|
|
Nov 13 2010, 17:01
Post
#41
|
|
|
Group: Developer Posts: 646 Joined: 26-September 07 Member No.: 47369 |
QUOTE (q-stankovic @ Nov 13 2010, 16:36) Wouldn't the message then be: Yes for "normal" DLLs, but here a Side-by-side assembly DLL is missing."This component is missing a required dependency, or was made for different version of foobar2000" |
|
|
|
|
Nov 13 2010, 17:04
Post
#42
|
|
|
Group: Members Posts: 1684 Joined: 28-May 06 From: Düsseldorf Member No.: 31251 |
QUOTE (fbuser @ Nov 13 2010, 17:01) ... here a Side-by-side assembly DLL is missing. Never heard about such a thing! -------------------- german support forum: www.foobar-users.de / user: qwert73
|
|
|
|
|
Nov 13 2010, 19:04
Post
#43
|
|
 Group: Admin Posts: 4218 Joined: 15-December 02 Member No.: 4082 |
You also won't see that error for MSVC 2010 binaries compiled with dynamic runtime, since they're no longer stored in the Side by Side assemblies folder. (%systemroot%\WinSxS)
|
|
|
|
|
Jan 12 2011, 06:13
Post
#44
|
|
|
Group: Members Posts: 1 Joined: 12-January 11 Member No.: 87262 |
excellent plugin i love it.
i have a question... is there a way to see what's on the queue list ? thanks |
|
|
|
|
Jan 12 2011, 08:19
Post
#45
|
|
|
Group: Developer Posts: 1217 Joined: 27-June 07 Member No.: 44789 |
-------------------- TAK -p4m :: LossyWAV -q 6 | TAK :: Lame 3.98 -V 2
|
|
|
|
|
Jan 18 2011, 15:59
Post
#46
|
|
|
Group: Members Posts: 2 Joined: 18-January 11 Member No.: 87425 |
Great plugin. No crashes as yet. One problem i'm having is that there is no menu under Playback.
Using latest f2k and v0.3.5. I got the following headings: Replay Gain Total Play Time Other No mention of the queue. |
|
|
|
|
Jan 18 2011, 18:39
Post
#47
|
|
|
Group: Developer Posts: 1217 Joined: 27-June 07 Member No.: 44789 |
No, you're looking at the File > Preferences menu. You want the main menu at the top:
File Edit View Playback Library Help Just click (keep queue / keep queue on exit) to toggle on or off. C. -------------------- TAK -p4m :: LossyWAV -q 6 | TAK :: Lame 3.98 -V 2
|
|
|
|
|
Jan 19 2011, 01:50
Post
#48
|
|
|
Group: Members Posts: 2 Joined: 18-January 11 Member No.: 87425 |
Ahhh.
Cheers for that. |
|
|
|
|
Jun 23 2011, 00:26
Post
#49
|
|
|
Group: Members Posts: 4 Joined: 22-June 11 Member No.: 91763 |
|
|
|
|
|
Jun 23 2011, 00:55
Post
#50
|
|
 Group: Members Posts: 24 Joined: 27-July 09 From: Siberia Member No.: 71815 |
demeuts,
foo_queuecontents -------------------- You know what you are.
|
|
|
|
|
|
Lo-Fi Version | Time is now: 19th May 2013 - 07:05 |
