IPB

Welcome Guest ( Log In | Register )

 
Reply to this topicStart new topic
patches for aacgain, working towards release 1.1
davelasker
post Dec 23 2004, 18:01
Post #1





Group: Members
Posts: 102
Joined: 1-August 04
From: San Francisco
Member No.: 15951



http://altosdesign.com/aacgain/aacgain_1_0_to_1_1.patch

Fixes witt's problem with 5.1 files. They didn't work bacause there was no code to deal with files with >2 channels. I stole the 5.1 analysis algorithm from foobar2000 and added it to aacgain. If you don't like it, adjust to taste.
I also fixed a problem reported by snelg where the output with /o flag didn't always match what the MP3GainGUI expects.

http://altosdesign.com/aacgain/aacgain_fix_bible.patch

Fixes Digga's problem with the files from the m4a-bible. These files were mono. I had modifed faad2 to skip decoding, and only parse files when gain was being adjusted. Unfortunately for mono files I skipped over some code that was needed for parsing.

These patches can be applied singly or together.

I'll be making a 1.1 release next week.

I received a Linux port from DarkAvenger. I haven't had a chance to look at it yet, but if it doesn't break the windoze code, I'll add that as well.

Thanks to all for your positive comments.

Happy Holidays!

Dave
Go to the top of the page
 
+Quote Post
Digga
post Dec 23 2004, 18:09
Post #2





Group: Members
Posts: 1045
Joined: 28-June 03
From: on the dock of the bay
Member No.: 7423



QUOTE (davelasker @ Dec 23 2004, 06:01 PM)
Fixes Digga's problem with the files from the m4a-bible. These files were mono. I had modifed faad2 to skip decoding, and only parse files when gain was being adjusted. Unfortunately for mono files I skipped over some code that was needed for parsing.
ah, so it wasn't just because of my dumbness wink.gif
QUOTE
I'll be making a 1.1 release next week.
Thanks to all for your positive comments.
that's good to hear.
thanks for your work.


--------------------
Nothing but a Heartache - Since I found my Baby ;)
Go to the top of the page
 
+Quote Post
davelasker
post Dec 26 2004, 21:28
Post #3





Group: Members
Posts: 102
Joined: 1-August 04
From: San Francisco
Member No.: 15951



Version 1.1 is now available on http://altosdesign.com/aacgain. No patching required!

Thanks to all for your help and feedback!

Dave
Go to the top of the page
 
+Quote Post
Digga
post Dec 28 2004, 14:28
Post #4





Group: Members
Posts: 1045
Joined: 28-June 03
From: on the dock of the bay
Member No.: 7423



could some kind soul build a binary (win)?


--------------------
Nothing but a Heartache - Since I found my Baby ;)
Go to the top of the page
 
+Quote Post
hangman
post Dec 28 2004, 14:55
Post #5





Group: Members
Posts: 53
Joined: 7-November 03
Member No.: 9706



Already did a couple of days ago:
http://celticdruid.no-ip.com/xvid/aacgain/
Go to the top of the page
 
+Quote Post
Digga
post Dec 28 2004, 17:29
Post #6





Group: Members
Posts: 1045
Joined: 28-June 03
From: on the dock of the bay
Member No.: 7423



QUOTE (hangman @ Dec 28 2004, 02:55 PM)
Already did a couple of days ago:
ty.
maybe it would be a good idea to update the version at RW too...


--------------------
Nothing but a Heartache - Since I found my Baby ;)
Go to the top of the page
 
+Quote Post
davelasker
post Dec 28 2004, 21:41
Post #7





Group: Members
Posts: 102
Joined: 1-August 04
From: San Francisco
Member No.: 15951



QUOTE (Digga @ Dec 28 2004, 09:29 AM)
maybe it would be a good idea to update the version at RW too...
*


I emailed rjamorim a binary on Sunday, but he hasn't updated RW yet. He's probably still celebrating xmas smile.gif

Dave
Go to the top of the page
 
+Quote Post
bond
post Dec 29 2004, 18:27
Post #8





Group: Members
Posts: 881
Joined: 11-October 02
Member No.: 3523



does this tool handle the normalization of single streams in .mp4 files with multiple tracks in it (eg two aac audio streams, audio+video, aac and mp3 audio streams in one .mp4, ...)


--------------------
I know, that I know nothing (Socrates)
Go to the top of the page
 
+Quote Post
davelasker
post Dec 30 2004, 02:42
Post #9





Group: Members
Posts: 102
Joined: 1-August 04
From: San Francisco
Member No.: 15951



QUOTE (bond @ Dec 29 2004, 10:27 AM)
does this tool handle the normalization of single streams in .mp4 files with multiple tracks in it (eg two aac audio streams, audio+video, aac and mp3 audio streams in one .mp4, ...)
*


mp3 processing is unmodifed from mp3gain. I don't think it will handle mp3 in an mp4 container.

aacgain only handles files with a single track. It will refuse to process a multi-track file.

If aacgain doesn't meet your needs, feel free to modify it smile.gif

This post has been edited by davelasker: Dec 30 2004, 02:45
Go to the top of the page
 
+Quote Post
bond
post Dec 30 2004, 19:39
Post #10





Group: Members
Posts: 881
Joined: 11-October 02
Member No.: 3523



QUOTE (davelasker @ Dec 30 2004, 03:42 AM)
If aacgain doesn't meet your needs, feel free to modify it
i am not a developer sad.gif

than just note this as a feature wish for christmas: an option to define which trackid the gain gets applied to.
i assume now your tool does this automatically on the trackid 1 (which most aac-only encoders use, but its already easily doable to get an aac-only file where the audio stream is not on place 1. eg muxing an aac stream with mp4box into .mp4 will give it the id 101 afaik, which is the id defined by isma for aac-in-mp4)
afaik mpeg4ips mp4v2 lib should handle different trackids already smile.gif


--------------------
I know, that I know nothing (Socrates)
Go to the top of the page
 
+Quote Post
davelasker
post Dec 30 2004, 21:54
Post #11





Group: Members
Posts: 102
Joined: 1-August 04
From: San Francisco
Member No.: 15951



QUOTE (bond @ Dec 30 2004, 11:39 AM)
i assume now your tool does this automatically on the trackid 1 (which most aac-only encoders use, but its already easily doable to get an aac-only file where the audio stream is not on place 1. eg muxing an aac stream with mp4box into .mp4 will give it the id 101 afaik, which is the id defined by isma for aac-in-mp4)
*


aacgain checks that there is one track in the file, and then processes it, regardless of its track id. Does that help you?

In the case of multiple tracks, would it be useful to have aacgain automatically process all tracks?

Thanks for the feedback!

Dave
Go to the top of the page
 
+Quote Post
bond
post Jan 1 2005, 21:20
Post #12





Group: Members
Posts: 881
Joined: 11-October 02
Member No.: 3523



QUOTE (davelasker @ Dec 30 2004, 10:54 PM)
aacgain checks that there is one track in the file, and then processes it, regardless of its track id. Does that help you?

thanks for the info smile.gif

QUOTE
In the case of multiple tracks, would it be useful to have aacgain automatically process all tracks?

hm, what is if there are video tracks in the .mp4 files too? wouldnt this cause problems

i am coming more from the video encoding side and there people often combine aac and mpeg-4 video in the .mp4 container.
(most of the time 1 video stream and 1 audio stream (in few cases also more audio streams))

if your tool could recognize that a stream is video and doesnt try to gain it, a "do gain on all tracks" option would be indeed nice smile.gif


--------------------
I know, that I know nothing (Socrates)
Go to the top of the page
 
+Quote Post
Snelg
post Jan 9 2005, 02:17
Post #13


MP3Gain Developer


Group: Developer
Posts: 207
Joined: 30-December 01
Member No.: 846



I've made the necessary changes in the MP3Gain GUI to fully integrate with aacgain.
Well, fully integrate with it if you re-name it to "mp3gain.exe" wink.gif

http://mp3gain.sourceforge.net/download.php

-Glen
Go to the top of the page
 
+Quote Post
DarkAvenger
post Jan 9 2005, 11:30
Post #14





Group: Members
Posts: 97
Joined: 11-October 01
Member No.: 262



Hi Snelg, I wonder whether you got my email about the trouble I am having with the gain analysis in linux. Any bright ideas?
Go to the top of the page
 
+Quote Post
guruboolez
post Jan 9 2005, 16:07
Post #15





Group: Members (Donating)
Posts: 3459
Joined: 7-November 01
From: Strasbourg (France)
Member No.: 420



QUOTE (Snelg @ Jan 9 2005, 02:17 AM)
I've made the necessary changes in the MP3Gain GUI to fully integrate with aacgain.
Well, fully integrate with it if you re-name it to "mp3gain.exe" wink.gif

http://mp3gain.sourceforge.net/download.php

-Glen
*


I've tried AACgain through your very useful GUI (thanks), and there were errors after I applied track gain. The generated log is here.

I've also noticed that many blank and non-blank temporary files were generated in MP3Gain folder, and are not deleted:
ftp://ftp2.foobar2000.net/foobar/MP3GainGUIErrors.png

Any idea?
Go to the top of the page
 
+Quote Post
davelasker
post Jan 9 2005, 19:13
Post #16





Group: Members
Posts: 102
Joined: 1-August 04
From: San Francisco
Member No.: 15951



QUOTE (guruboolez @ Jan 9 2005, 08:07 AM)
I've tried AACgain through your very useful GUI (thanks), and there were errors after I applied track gain. The generated log is here.

I've also noticed that many blank and non-blank temporary files were generated in MP3Gain folder, and are not deleted:
ftp://ftp2.foobar2000.net/foobar/MP3GainGUIErrors.png
*

Sorry, these are both my bugs.

I was returning the "old-style" return code to MP3GainGUI on success; the "new-style" on failure. As a result MP3GainGUI thought all runs of aacgain failed. I also neglected to delete a temp file when the /t option was used.

I've posted updated source code on http://altosdesign.com/aacgain/ and emailed Roberto an executable to post on RW.

Version 1.1 will work with the old version of MP3GainGUI, but if you are using the latest versions of MP3GainGUI (1.2.5 or 1.3.4) then you must use aacgain version 1.2.

Thanks for finding this!

Dave

This post has been edited by davelasker: Jan 9 2005, 22:20
Go to the top of the page
 
+Quote Post
brian.comeau@bkc...
post Jan 9 2005, 23:17
Post #17





Group: Members
Posts: 1
Joined: 9-January 05
Member No.: 18955



This is very nice...any chance that that aacgain might be able to work with Apple Lossless in the near future?



QUOTE (davelasker @ Jan 9 2005, 12:13 PM)
QUOTE (guruboolez @ Jan 9 2005, 08:07 AM)
I've tried AACgain through your very useful GUI (thanks), and there were errors after I applied track gain. The generated log is here.

I've also noticed that many blank and non-blank temporary files were generated in MP3Gain folder, and are not deleted:
ftp://ftp2.foobar2000.net/foobar/MP3GainGUIErrors.png
*

Sorry, these are both my bugs.

I was returning the "old-style" return code to MP3GainGUI on success; the "new-style" on failure. As a result MP3GainGUI thought all runs of aacgain failed. I also neglected to delete a temp file when the /t option was used.

I've posted updated source code on http://altosdesign.com/aacgain/ and emailed Roberto an executable to post on RW.

Version 1.1 will work with the old version of MP3GainGUI, but if you are using the latest versions of MP3GainGUI (1.2.5 or 1.3.4) then you must use aacgain version 1.2.

Thanks for finding this!

Dave
*
Go to the top of the page
 
+Quote Post
kalmark
post Jan 9 2005, 23:34
Post #18





Group: Members
Posts: 597
Joined: 9-October 03
From: ZZ 9 Plural Z Alpha
Member No.: 9230



Just to clear up stuff: AAC and Apple Lossless have only one thing in common: that they are both supported by Apple.


--------------------
Life is Real...
(But not in audio :) )
Go to the top of the page
 
+Quote Post
davelasker
post Jan 9 2005, 23:45
Post #19





Group: Members
Posts: 102
Joined: 1-August 04
From: San Francisco
Member No.: 15951



QUOTE (brian.comeau@bkc.ca @ Jan 9 2005, 03:17 PM)
any chance that that aacgain might be able to work with Apple Lossless in the near future?
*


No chance of that happening.

If you have lossless, or other formats other than aac & mp3 in your iTunes library, then use iTunes's soundcheck instead.

Dave
Go to the top of the page
 
+Quote Post
rjamorim
post Jan 10 2005, 02:40
Post #20


Rarewares admin


Group: Members
Posts: 7515
Joined: 30-September 01
From: Brazil
Member No.: 81



QUOTE (davelasker @ Jan 9 2005, 03:13 PM)
I've posted updated source code on http://altosdesign.com/aacgain/ and emailed Roberto an executable to post on RW.
*


It's already uploaded.

Best regards;

Roberto.


--------------------
Get up-to-date binaries of Lame, AAC, Vorbis and much more at RareWares:
http://www.rarewares.org
Go to the top of the page
 
+Quote Post
Franky
post Jan 16 2005, 19:46
Post #21





Group: Members
Posts: 9
Joined: 27-September 04
Member No.: 17332



Wonderful piece of software. I just used it on my iTunes Music Library folder, but there were 6 files that wouldn't be changed, the log said Error: Wrap while modifying gain. Any idea why this happens?
Go to the top of the page
 
+Quote Post
davelasker
post Jan 17 2005, 18:51
Post #22





Group: Members
Posts: 102
Joined: 1-August 04
From: San Francisco
Member No.: 15951



QUOTE (Franky @ Jan 16 2005, 11:46 AM)
Wonderful piece of software. I just used it on my iTunes Music Library folder, but there were 6 files that wouldn't be changed, the log said Error: Wrap while modifying gain. Any idea why this happens?
*
from the command line, run

aacgain /? wrap

for an explaination of wrapping. Unlike mp3gain, aacgain does not permit wrapping.

Dave
Go to the top of the page
 
+Quote Post

Reply to this topicStart new topic
1 User(s) are reading this topic (1 Guests and 0 Anonymous Users)
0 Members:

 



RSS Lo-Fi Version Time is now: 9th February 2010 - 16:30