Toaster for Fb2k, The port of the Winamp Toaster plugin Options

[banjobacon]

Well, my latest crash came when I double clicked my playlist panel in order to create a new playlist. Here's the failure.txt, in case that is of any help.

CODE

Illegal operation:
Code: C0000005h, flags: 00000000h, address: 004212F5h
Access violation, operation: read, address: 00000000h
Call path:
WinMain=>app_mainloop
This is the first crash logged by this instance.
Code bytes (004212F5h):
004212B5h: FF 15 18 90 43 00 8B 3D 1C 59 44 00 FF 05 10 59
004212C5h: 44 00 C1 EF 03 C7 45 FC 00 00 00 00 74 3D 53 8B
004212D5h: 5D 08 56 8B 4D 0C FF 75 FC 8B 01 FF 10 84 C0 74
004212E5h: 20 A1 14 59 44 00 8B 4D FC 8B 34 C8 8B CE 8B 06
004212F5h: FF 10 8B 03 8B CB FF 10 8B 13 50 56 8B CB FF 52
00421305h: 10 FF 45 FC 39 7D FC 72 CA 5E 5B 8D 4D F8 E8 0C
00421315h: 4D FE FF 5F C9 C2 08 00 55 8B EC 51 B8 F8 58 44
00421325h: 00 56 50 89 45 FC FF 15 18 90 43 00 A1 1C 59 44
Stack (0012FCE0h):
0012FCC0h: 00BDF8C0 77FA88F0 77F521E0 0000005A
0012FCD0h: 00BDD9F4 C0000005 00BDD9D0 00BDD9E0
0012FCE0h: 013F0760 00000000 004458F4 004458F8
0012FCF0h: 0000003F 0012FD14 00427292 013F0774
0012FD00h: 0012FD10 00000002 00000003 00000000
0012FD10h: 004394C4 0012FD28 004277AE 01470AB8
0012FD20h: 0043B508 00000000 0012FDBC 00CB8C08
0012FD30h: 004465DC 0012FE4C 00CB7B0C 00000000
0012FD40h: 00CC63E0 00F19E58 0000001D 0000001D
0012FD50h: 00000000 00000010 00000000 00000000
0012FD60h: 00000000 00000001 00CC67DC 00CC67C8
0012FD70h: 005CBAF0 FFFFFFEB 00000000 0012FE4C
0012FD80h: 00CB7B0C 0012FDBC 77D440BD 005CBAF0
0012FD90h: FFFFFFEB 77D440C6 0012FE4C 00CB7B0C
0012FDA0h: 00000000 0012FD6C 77D47E67 00CB853A
0012FDB0h: 0012FE5C 00CC5B38 00000003 0012FDD8
0012FDC0h: 00CB7B32 004465AC 000102FE 00000203
0012FDD0h: 00000001 002D0044 0012FE04 77D43A50
0012FDE0h: 000102FE 00000203 00000001 002D0044
0012FDF0h: 00CB7B0C DCBAABCD 00000000 0012FE4C
Registers:
EAX: 00000000, EBX: 013F0774, ECX: 01470A54, EDX: 0000003E
ESI: 01470A54, EDI: 00000040, EBP: 0012FCF4, ESP: 0012FCE0
Crash location: "foobar2000", loaded at 00400000h - 00452000h

Loaded modules:
foobar2000 loaded at 00400000h - 00452000h
ntdll loaded at 77F50000h - 77FF7000h
kernel32 loaded at 77E60000h - 77F46000h
USER32 loaded at 77D40000h - 77DCC000h
GDI32 loaded at 7F000000h - 7F041000h
ADVAPI32 loaded at 77DD0000h - 77E5D000h
RPCRT4 loaded at 78000000h - 78087000h
ole32 loaded at 771B0000h - 772D4000h
COMCTL32 loaded at 71950000h - 71A34000h
msvcrt loaded at 77C10000h - 77C63000h
SHLWAPI loaded at 70A70000h - 70AD9000h
utf8api loaded at 10000000h - 1000D000h
comdlg32 loaded at 763B0000h - 763F5000h
SHELL32 loaded at 4F510000h - 4FD21000h
foo_albumlist loaded at 008D0000h - 008DB000h
foo_audioscrobbler loaded at 008E0000h - 00900000h
LIBCURL loaded at 00900000h - 00919000h
WS2_32 loaded at 71AB0000h - 71AC5000h
WS2HELP loaded at 71AA0000h - 71AA8000h
WINMM loaded at 76B40000h - 76B6C000h
serwvdrv loaded at 5CD70000h - 5CD77000h
umdmxfrm loaded at 5B0A0000h - 5B0A7000h
foo_cdda loaded at 009B0000h - 009BE000h
foo_clienc loaded at 009C0000h - 009CB000h
foo_console loaded at 009D0000h - 009D7000h
foo_dbsearch loaded at 009E0000h - 009F8000h
foo_diskwriter loaded at 00A00000h - 00A12000h
foo_dsp_extra loaded at 00A20000h - 00A35000h
foo_dsp_soundtouch loaded at 00A40000h - 00A4D000h
foo_flac loaded at 00A50000h - 00A6C000h
foo_freedb loaded at 00A70000h - 00A8D000h
foo_id3v2 loaded at 00A90000h - 00AC0000h
MSVCP60 loaded at 55900000h - 55961000h
foo_infobox loaded at 00AC0000h - 00AD3000h
foo_input_std loaded at 00AE0000h - 00B7E000h
MSACM32 loaded at 77BE0000h - 77BF4000h
foo_masstag loaded at 00B80000h - 00B94000h
foo_output_std loaded at 00BA0000h - 00BA9000h
foo_playcount-1.4.1 loaded at 00BB0000h - 00BBA000h
foo_playlistgen_ex loaded at 00BC0000h - 00BCF000h
foo_read_http loaded at 00BD0000h - 00BD9000h
foo_rgscan loaded at 00BE0000h - 00BED000h
foo_scroll loaded at 00BF0000h - 00BF6000h
foo_spc loaded at 00C00000h - 00C11000h
foo_syfm loaded at 00C20000h - 00C2A000h
foo_temple loaded at 00C30000h - 00C3B000h
foo_toaster loaded at 00C40000h - 00C5E000h
gdiplus loaded at 70D00000h - 70E91000h
MSVCR71 loaded at 7C340000h - 7C396000h
foo_uie_albumart loaded at 00C80000h - 00C8C000h
foo_uie_volume loaded at 00C90000h - 00C9A000h
foo_ui_columns loaded at 00CA0000h - 00CD7000h
foo_ui_std loaded at 00CE0000h - 00CF7000h
foo_vorbisenc loaded at 00D00000h - 00DFA000h
foo_wavpack loaded at 00E00000h - 00E12000h
foo_winamp_spam loaded at 00E20000h - 00E28000h
uxtheme loaded at 5AD70000h - 5ADA4000h
ctagent loaded at 00F80000h - 00F90000h
mswsock loaded at 71A50000h - 71A8B000h
DNSAPI loaded at 76F20000h - 76F45000h
winrnr loaded at 76FB0000h - 76FB7000h
WLDAP32 loaded at 76F60000h - 76F8C000h
dsound loaded at 51080000h - 510DD000h
VERSION loaded at 77C00000h - 77C07000h
wdmaud loaded at 72D20000h - 72D29000h
msacm32 loaded at 72D10000h - 72D18000h
rasadhlp loaded at 76FC0000h - 76FC5000h
midimap loaded at 77BD0000h - 77BD7000h
wshtcpip loaded at 71A90000h - 71A98000h
KsUser loaded at 5EF80000h - 5EF84000h
appHelp loaded at 75F40000h - 75F5F000h
CLBCATQ loaded at 7C890000h - 7C911000h
OLEAUT32 loaded at 77120000h - 771AB000h
COMRes loaded at 77050000h - 77115000h
cscui loaded at 76620000h - 7666E000h
CSCDLL loaded at 76600000h - 7661C000h
browseui loaded at 71500000h - 715FD000h
USERENV loaded at 75A70000h - 75B15000h
SETUPAPI loaded at 76670000h - 76757000h
ntshrui loaded at 76990000h - 769B4000h
ATL loaded at 76B20000h - 76B35000h
NETAPI32 loaded at 71C20000h - 71C6E000h
shdocvw loaded at 71700000h - 71848000h
imagehlp loaded at 76C90000h - 76CB2000h
DBGHELP loaded at 6D510000h - 6D58D000h

Stack dump analysis:
Address: 004458F4h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 004458F8h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 00427292h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 004394C4h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 004277AEh, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 0043B508h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 00CB8C08h, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 004465DCh, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 00CB7B0Ch, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 00CC63E0h, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 00CC67DCh, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 00CC67C8h, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 00CB7B0Ch, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 77D440BDh, location: "USER32", loaded at 77D40000h - 77DCC000h
Symbol: "GetWindowLongW" (+0000002Bh)
Address: 77D440C6h, location: "USER32", loaded at 77D40000h - 77DCC000h
Symbol: "GetWindowLongW" (+00000034h)
Address: 00CB7B0Ch, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 77D47E67h, location: "USER32", loaded at 77D40000h - 77DCC000h
Symbol: "CallNextHookEx" (+00000039h)
Address: 00CB853Ah, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 00CC5B38h, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 00CB7B32h, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 004465ACh, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 77D43A50h, location: "USER32", loaded at 77D40000h - 77DCC000h
Address: 00CB7B0Ch, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 00CB7B0Ch, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 77D43B1Fh, location: "USER32", loaded at 77D40000h - 77DCC000h
Address: 00CB7B0Ch, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 77D73964h, location: "USER32", loaded at 77D40000h - 77DCC000h
Symbol: "CreateAcceleratorTableA" (+0000032Dh)
Address: 77D99BE0h, location: "USER32", loaded at 77D40000h - 77DCC000h
Address: 77D43D79h, location: "USER32", loaded at 77D40000h - 77DCC000h
Symbol: "GetMessageW" (+00000125h)
Address: 00CB7B0Ch, location: "foo_ui_columns", loaded at 00CA0000h - 00CD7000h
Address: 77D43A33h, location: "USER32", loaded at 77D40000h - 77DCC000h
Address: 77D4B1B8h, location: "USER32", loaded at 77D40000h - 77DCC000h
Symbol: "IsDialogMessageW" (+0000008Dh)
Address: 77D73964h, location: "USER32", loaded at 77D40000h - 77DCC000h
Symbol: "CreateAcceleratorTableA" (+0000032Dh)
Address: 77D99C00h, location: "USER32", loaded at 77D40000h - 77DCC000h
Address: 77D43DDFh, location: "USER32", loaded at 77D40000h - 77DCC000h
Symbol: "DispatchMessageW" (+0000000Bh)
Address: 100038ECh, location: "utf8api", loaded at 10000000h - 1000D000h
Symbol: "uDispatchMessage" (+0000000Ah)
Address: 0041238Bh, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 70A74187h, location: "SHLWAPI", loaded at 70A70000h - 70AD9000h
Symbol: "Ordinal125" (+0000002Dh)
Address: 00410FEAh, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 00438DB5h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 00400000h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 70A74187h, location: "SHLWAPI", loaded at 70A70000h - 70AD9000h
Symbol: "Ordinal125" (+0000002Dh)
Address: 00438DE0h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 0043C320h, location: "foobar2000", loaded at 00400000h - 00452000h
Address: 77E8141Ah, location: "kernel32", loaded at 77E60000h - 77F46000h
Symbol: "GetCurrentDirectoryW" (+00000044h)
Address: 70A74187h, location: "SHLWAPI", loaded at 70A70000h - 70AD9000h
Symbol: "Ordinal125" (+0000002Dh)
Address: 77E9B2E5h, location: "kernel32", loaded at 77E60000h - 77F46000h
Symbol: "SetThreadExecutionState" (+00000097h)
Address: 77E97CE0h, location: "kernel32", loaded at 77E60000h - 77F46000h
Symbol: "VerSetConditionMask" (+0000D764h)
Address: 00438C81h, location: "foobar2000", loaded at 00400000h - 00452000h

Version info:
foobar2000 v0.8.3
UNICODE

This post has been edited by banjobacon: Feb 21 2005, 18:55

[wortels]

shaneh your plugin is open source right? Why not host @ sourceforge.net? IPB's uploading somehow gets the compressed files corrupted :S. And yes I am also getting those random crashes haven't been able to try this one yet. If you dont want to host @ sourceforge I will be getting my hosting in a week and I can host for you

[banjobacon]

You could also upload your plugin to the 3rd party plugin site.

[Biscuits]

Hey, I got the latest version (.zip file worked!) and it seems as though the crashes on quit have been fixed, though I haven't tested thoroughly. I have a few requests:

- Have an option so that it is not always on top.

- I have my hold option all the way up (which I assume makes it never go away) and if I press stop, it stays there. It'd be nice if it'd automatically go away if the music is stopped.

- Have an option to show elapsed time?

- If song is paused, have it show [Paused] or something like that.

Maybe these options defeat the original purpose of the plugin, but I'd find them useful.

Thanks,
-Tristan

This post has been edited by Biscuits: Feb 21 2005, 19:31

[saratoga]

shaneh from toaster's settings I figured you know how to display embedded album art files from id3v2 tags. If you have some knowledge on this could you help foo_uie_albumart. They can't figure out how to display images from id3v2 tags and I have to manually create folder.jpg for all of my album folders.

Thanks a lot

Art in tags is incompatable with foobar's tagging, so adding cover art to any tag type would not be a good idea. You'd have to disable tag writing in foobar entirely for it to work.

Using a folder.jpg is a much better solution.

[Skates]

shaneh from toaster's settings I figured you know how to display embedded album art files from id3v2 tags. If you have some knowledge on this could you help foo_uie_albumart. They can't figure out how to display images from id3v2 tags and I have to manually create folder.jpg for all of my album folders.

Thanks a lot

Art in tags is incompatable with foobar's tagging, so adding cover art to any tag type would not be a good idea. You'd have to disable tag writing in foobar entirely for it to work.

Using a folder.jpg is a much better solution.

Actually, a folder.jpg will not work right for some people such as I, I only keep singles from albums that I deem worthy enough to keep. In this case it would be redundant to have a folder for every single I have, in instances that I only have one song from that album.

This post has been edited by Skates: Feb 21 2005, 20:04

[anza]

shaneh from toaster's settings I figured you know how to display embedded album art files from id3v2 tags. If you have some knowledge on this could you help foo_uie_albumart. They can't figure out how to display images from id3v2 tags and I have to manually create folder.jpg for all of my album folders.

Thanks a lot

Art in tags is incompatable with foobar's tagging, so adding cover art to any tag type would not be a good idea. You'd have to disable tag writing in foobar entirely for it to work.

Using a folder.jpg is a much better solution.

Actually, a folder.jpg will not work right for some people such as I, I only keep singles from albums that I deem worthy enough to keep. In this case it would be redundant to have a folder for every single I have, in instances that I only have one song from that album.

Well you could just have many image files in the folder and name them after the single.

[rossthiof]

Seems there is a problem with displaying album cover in some cases:
If there is an ä,ö or ü [german: "Umlaute"] in the file path, the folder-jpg can't be displayed.
Is there any possibility to solve this problem?

[shaneh]

I think I may have found the cause of at least one of the crashes, I will update it with a fix eventually.

I wont bother uploading it anywhere else until Ive stabalised it somewhat.

I dont see the problem with cover art in your audio files. It contains other meta data so why not. It certainly saves having to fiddle with external files etc. The disk space usage isnt much of an argument when you go through and do the actual % figures. I agree that id3v2 is a crappy format though. Id be more concerned about a player that modifies your files as you play them and writes non-standard tags such as PLAYCOUNT instead of the standard POPM fields etc, with the only way to prevent it being to block all tag modifications. Thats always bugged me about fb2k.

@Biscuits: I tried implementing an "always on bottom" feature a while ago, but Windows doesnt really support it. You have to continually check your Z order position and move to the bottom on all sorts of events etc. It ended up being quite awkward and unusable.

I could hide the toast window on stop without a problem I think.

Things like elapsed time which change dynamically are a bit tricky to do in Toaster. Its been coded in such a way that updating would require a complete redraw of the window. Though thinking about it just now, there might be a way. Although the dynamic width would have to not change with each update, only on a song change, for best results.

The song paused thing would be easy to do if I implement the dynamic info stuff I talked about above.

@rossthiof + others: I will need to change the file handling to unicode versions AFAIK.

This post has been edited by shaneh: Feb 22 2005, 01:23

[ssamadhi97]

Id be more concerned about a player that modifies your files as you play them and writes non-standard tags such as PLAYCOUNT instead of the standard POPM fields etc

Err. This is not a feature of the player, but something introduced by third party plugins that are not part of any installer package. Don't spread this kind of disinformation, please. (btw there is an alternative plugin that does not touch file tags at all and keeps track of playback statistics in its own database)

[shaneh]

Maybe so, but if you want to keep statistics in the main database (AFAIK, the database is part of the player), then you have to update it with fields similar to how the 3rd party plugin works. This data is then potenitally written to the file. I think most people would want to use this database than a 2nd, or sql server or whatever.

Regardless of whether the 3rd party plugins which put this info in the DB in the first place are or aren't part of the package, the main db has the ability to write non-standard tags to files you play. Which AFAIK *is* a feature of the player.

This post has been edited by shaneh: Feb 22 2005, 02:21

[amppa]

All downloads are the same - but for some reason the board is corrupting my uploads, so try your luck with them.

Well, you could upload the plugin to the 3rd party site to avoid corrupted files.

[A_Man_Eating_Duc...]

is there any chance of getting support for multiple image locations?
Like an image fallback, if string A is not found, try string B.

e.g
i have
F:\album art\%Artist% - %Album%.jpg
and
F:\album art\Various Artists - %album%

or is it easier to put in support for the $if2 function ?

e.g
$if2(F:\Album Art\%artist% - %album%.jpg,F:\Album Art\Various Artists - %album%.jpg)

[shaneh]

A_Man_Eating_Duck: You can separate strings by ; and Toaster will try them in order. Unfortuantly if your albums or artist have non-filename characters have invalid filename characters you will have problems. I am not sure of a way to filter the strings such that invalid characters are filtered (on a per tag basis). /EDIT: The $replace function would seem to do the trick.

Ive updated to 0.1.2, but only debug builds are currently available until stability settles. You will need the debug msvcr stuff for this.

I think Ive fixed the main issue people were probably having. I previously had C++ exceptions turned off due to some internal SEH stuff I was doing with delay imports. Ive changed this about a bit and hopefully it will work a little better. I havent done the unicode file handling stuff yet though.

This post has been edited by shaneh: Feb 22 2005, 16:50

[wortels]

Maybe so, but if you want to keep statistics in the main database (AFAIK, the database is part of the player), then you have to update it with fields similar to how the 3rd party plugin works. This data is then potenitally written to the file. I think most people would want to use this database than a 2nd, or sql server or whatever.

Regardless of whether the 3rd party plugins which put this info in the DB in the first place are or aren't part of the package, the main db has the ability to write non-standard tags to files you play. Which AFAIK *is* a feature of the player.

Exactly third party plugins should be able to access the db and create additional fields. This whole idea of tagging the files with playcount is weird and using sqllite adds another process why use an external db if you already have one. I still cant understand why it removes some metadata when editing tags while that metadata is part of the id3 spec. For me this is the first thing that needs to be worked on. id3 spec compliant tags and native id3v2 support like other players do today (itunes etc)

[A_Man_Eating_Duc...]

A_Man_Eating_Duck: You can separate strings by ; and Toaster will try them in order.

Well strike me down, it works

Thanks

[shaneh]

@rossthiof+eliazu: try the new 0.1.3 version and see if its working ok with the unicode folders. It seems to ok for me, though my machine isnt very 'international' so I havent done a too thorough test.

[rossthiof]

I'm on the way to test it, but there is one problem:
I don't have this file called "msvcr71d.dll" on my system and it seems to be hard to find it in the internet...

Edit:Works very well.THX a lot!

This post has been edited by rossthiof: Feb 22 2005, 18:18

[banjobacon]

I downloaded a file with Toaster skins from the Winamp forum (here). I got the ballon skin to work in foobar by changing a few settings around in the Toaster config window, after importing the Ballon preset. However, after I close and reopen fb2k, the skin doesn't work anymore. I have to re-import it for anything to show up.

[eliazu]

hebrew covers and fonts are displayed great now on 0.1.3. thank you very much!

[Duble0Syx]

I've just dl v 0.1.3 and now I get the "cannot load DLL" error when foobar starts. I already have all the dll's I think I need as well as GDI since I am on WinXP sp2. Are there some components known to cause this or am I still missing something?

EDIT: Also, I can't open with 7zip archives at all with either winrar or 7-zip.

This post has been edited by Duble0Syx: Feb 22 2005, 18:58

[dano]

you can get the 2 dll's needed for debug version from here: http://dream.eng.uci.edu/sungjin/EECS123/
if you dont want that, use the release version - my download did not work, too (firefox). but after i tried the download in internet explorer, it worked?!

[saratoga]

Regardless of whether the 3rd party plugins which put this info in the DB in the first place are or aren't part of the package, the main db has the ability to write non-standard tags to files you play. Which AFAIK *is* a feature of the player.

Writing nonstandard tags is a very useful feature, and allowed by the spec in most tag formats (and when not allowed, they are not written). What possible reason could you have for not wanting them?

[Skates]

Regardless of whether the 3rd party plugins which put this info in the DB in the first place are or aren't part of the package, the main db has the ability to write non-standard tags to files you play. Which AFAIK *is* a feature of the player.

Writing nonstandard tags is a very useful feature, and allowed by the spec in most tag formats (and when not allowed, they are not written). What possible reason could you have for not wanting them?

Exactly the point, cover art maybe unstandard with APEv2, but as you say unstandard tags are very useful. So whats the point of not supporting cover art tags?

Seems like your backstepping from your previous statements...

This post has been edited by Skates: Feb 22 2005, 22:26

[Duble0Syx]

Could someone maybe mirror the files? The 7zip file is broken when downloaded with firefox and I can't download the file at all on IE.