I rip my cds on several machines, and copy the results between my desktop and laptop. On occasion I run vorbisgain -afr *.ogg in the root directory of all of my music files, to make sure that I haven't missed replaygaining anything. That's 140 artist dirs (and Foobar says 206 albums) on one machine and there's at least 50% more on the other machine.

When I do this, and even when everyfile is tagged, the process gets slower and slower, memory usage goes up, and forces my system to start swapping. Here's a picture of the task manager graph.

It seems that VorbisGain is holding onto data for albums after they've been processed. And maybe? it could process each album and then release those resources? Or maybe I've missed some of the documentation, and there's a more effective way to do what I'm doing. In which case, I wouldn't mind a tip on how to better use VorbisGain.

--Nathan

If you're using Windows and that's your command line I think you need to separate the commands:
vorbisgain -a -f -r *.ogg

If "-afr" leaks memory and "-a -f -r" doesn't that's a real bug.

"-afr" does what it is supposed to. The format of the flags isn't the problem. Both syntaxes result in the same behavior. There is some kind of data for each album that is preserved in memory after the album is processed.

--Nathan

I'll take a look at it when I have time.

I've run VorbisGain just like that a number of times over my Ogg collection (some 100+ albums) on Win2K, and according to TaskManager (the process list, that is), the reported memory usage was steady throughout the processing. I did that to look for major memory leaks, though I'm pretty sure it isn't be best tool for that task...

If you have saved the log (i.e., the VorbisGain output), feel free to send me a PM with it. Might not help much, but...

Btw, you don't need to split "-afr".

Lear, it's really leaking all over, but it's not your fault. The vorbiscomment reference code is buggy. Seems to be fixed in CVS, I'll have an updated vorbisgain soon.

Uploaded new source and binaries to sjeng.org, updated vorbisgain to 0.34

Should fix all memleaks.

Updated VorbisGain v0.33 now available at Rarewares.

Edit: OK, Garf's renamed it. I'll do the same.

Edit 2: Done.

Good you found it. Seems like it only happened if you didn't write any tags (and VorbisGain reads them to see if anything should be done when in --fast mode). And I like the following comment in an older version of the code:



B)

Gracias, gentlemen. It's working for me, peak memory usage around 1.1 MB, avg CPU 6% when churning through the 17GB of ogg files. The memory curve didn't show the ramp shape.

Thanks again!

--Nathan