hopefully some devs can shed some light on these build problems:
(using source from RareWares: http://rarewares.hydrogenaudio.org/files/l...modifiedsrc.zip )

machine: debian sid/unstable (gcc 3.3.3pre)

(text dumps in http://xmixahlx.dyndns.org/hrm/lame/ )

to the point:

************
MAKE ERROR:

source='VbrTag.c' object='VbrTag.lo' libtool=yes \
depfile='.deps/VbrTag.Plo' tmpdepfile='.deps/VbrTag.TPlo' \
depmode=gcc3 /bin/sh ../depcomp \
/bin/sh ../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I..
-I../include -I. -I../mpglib/ -I.. -O3 -fomit-frame-pointer
-ffast-math -funroll-loops -Wall -pipe -c -o VbrTag.lo `test -f
VbrTag.c || echo './'`VbrTag.c
rm -f .libs/VbrTag.lo
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -I. -I../mpglib/ -I.. -O3
-fomit-frame-pointer -ffast-math -funroll-loops -Wall -pipe -c VbrTag.c
-MT VbrTag.lo -MD -MP -MF .deps/VbrTag.TPlo -fPIC -DPIC -o
.libs/VbrTag.lo
VbrTag.c: In function `PutLameVBR':
VbrTag.c:738: error: structure has no member named `preset'
make[3]: *** [VbrTag.lo] Error 1
make[3]: Leaving directory
`/mnt/build/debian/packages-wip/lame-3.90.3+modified-20031210/libmp3lame'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/mnt/build/debian/packages-wip/lame-3.90.3+modified-20031210/libmp3lame'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/mnt/build/debian/packages-wip/lame-3.90.3+modified-20031210'
make: *** [all] Error 2

****************************
DIFF 3.90.3 vs 3.90.3+modified

731a732,736
> // The following amended 2003-09-19 to add writing of preset info.
> // memset(pbtStreamBuffer+nBytesWritten,0, 3); //unused in rev0
> // nBytesWritten+=3;
> // Next 4 lines added as per above, 2003-09-19.
> pbtStreamBuffer[nBytesWritten++] = 0; /*unused in rev1 */
733,734c738,739
< memset(pbtStreamBuffer+nBytesWritten,0, 3); //unused in rev0
< nBytesWritten+=3;
---
> CreateI2(&pbtStreamBuffer[nBytesWritten], gfp->preset);
> nBytesWritten+=2;
843a849,851
> if (gfp->free_format)
> bbyte = 0x00;
> else


? did someone screw the VBR tag over? or am i missing something?


thanx for the insight
later

Sorry Mike!! I think that the source was left a little behind. I've just updated it and uploaded again. Hopefully, It'll be OK now.

i still get this error:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../libmp3lame -I../include -I.. -O3 -fomit-frame-pointer -ffast-math -funroll-loops -Wall -pipe -c `test -f timestatus.c || echo './'`timestatus.c
/bin/sh ../libtool --mode=link gcc -O3 -fomit-frame-pointer -ffast-math -funroll-loops -Wall -pipe -static -o lame main.o get_audio.o lametime.o parse.o portableio.o timestatus.o -lm ../libmp3lame/libmp3lame.la
gcc -O3 -fomit-frame-pointer -ffast-math -funroll-loops -Wall -pipe -o lame main.o get_audio.o lametime.o parse.o portableio.o timestatus.o -lm ../libmp3lame/.libs/libmp3lame.a
../libmp3lame/.libs/libmp3lame.a(set_get.o)(.text+0xf63): In function `lame_set_preset':
: undefined reference to `apply_preset'
collect2: ld returned 1 exit status
make[2]: *** [lame] Error 1
make[2]: Leaving directory `/mnt/build/debian/packages-wip/lame-ha-3.90.3+m-20031210/frontend'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/mnt/build/debian/packages-wip/lame-ha-3.90.3+m-20031210'
make: *** [all] Error 2

I think you need to add 'presets.c' into the compile.

yes, it was presets.c

needed to add this to Makefile.am and hack the calls to it in Makefile.in (i wasn't sure how lame builds these from CVS, does anyone know the process? i.e. a bootstrap or autogen script?)

anyways, the diffs:



*** END

btw, what are these lame sources:
SPECIALlame.c
Reallame.c
?


later

SPECIALlame.c was, IIRC, the version that only encoded --aps, and Reallame.c, again IIRC, the original and unadulterated lame.c!! (I didn't really mean to include those!! )

john, your latest lame 3.90.3 upload still has these errors

could you implement these changes in your tree? thanx


mike

Amended as per your instructions, above, and uploaded again. Let me know if it's not OK.

thanx john

all fine and dandy now

i left you a valentine in yer box


later