Help - Search - Members - Calendar
Full Version: New Lame GUI frontend in development...
Hydrogenaudio Forums > Lossy Audio Compression > MP3 > MP3 - General
Pages: 1, 2, 3, 4
Synthetic Soul
Inno Setup is very easy to use, but quite flexible.

Of course, there is NSIS, but that looks more complicated to me. Inno's a breeze.

Looking forward to taking a look. smile.gif
Jebus
QUOTE(Synthetic Soul @ Jul 12 2006, 13:29) *

Inno Setup is very easy to use, but quite flexible.

Of course, there is NSIS, but that looks more complicated to me. Inno's a breeze.

Looking forward to taking a look. smile.gif


I'll take a look, but all things being equal i need a copy of visual studio anyhow, and would rather use the windows installer features built in to VS. If I hit a roadblock i'll certainly give Inno a try!
Jebus
Download the test version here

Lame and Nero are the only included codecs right now. And there is no installer.

This is a pre-beta, unversioned, totally unworthy release. Once I have a proper installer, support site, and can release the source code, I will release a version 0.1. I don't want a hundred "where is the source code, GPL etc?" PM's right away. Give me a few days! I'll submit a news item at that time. Only want the feedback of a few individuals right now...

Jeremy

Oh, you will need the .NET runtime 2.0 on your machine.

please discuss problems in this thread for now... I disabled the help links intentionally since they don't exist yet. so those "about:blank" pages are expected. Please report other bugs though!
ponchorage
Well, I tried it out and right after the first track finished ripping I got an error message. I don't have the source (I know you're going to release it later), but here is the disassembly of the portion of code with the problem. I'm not sure it will help, but its all I can offer for debugging purposes:

CODE

--- C:\Documents and Settings\Jeremy\My Documents\Visual Studio 2005\Projects\Omni Encoder\EAC Encoder\Program.cs
00000000 push ebp
00000001 mov ebp,esp
00000003 push edi
00000004 push esi
00000005 push ebx
00000006 sub esp,2Ch
00000009 xor eax,eax
0000000b mov dword ptr [ebp-18h],eax
0000000e mov dword ptr [ebp-2Ch],ecx
00000011 cmp dword ptr ds:[00922DC8h],0
00000018 je 0000001F
0000001a call 793E228E
0000001f xor edx,edx
00000021 mov dword ptr [ebp-30h],edx
00000024 xor edx,edx
00000026 mov dword ptr [ebp-34h],edx
00000029 xor edx,edx
0000002b mov dword ptr [ebp-38h],edx
0000002e xor edx,edx
00000030 mov dword ptr [ebp-24h],edx
00000033 mov dword ptr [ebp-28h],0
0000003a nop
0000003b mov eax,dword ptr [ebp-2Ch]
0000003e cmp dword ptr [eax+4],9
00000042 sete al
00000045 movzx eax,al
00000048 mov dword ptr [ebp-28h],eax
0000004b cmp dword ptr [ebp-28h],0
0000004f jne 0000009D
00000051 nop
00000052 mov edi,dword ptr ds:[02286B94h]
00000058 mov ecx,790FED1Ch
0000005d call FFC61FAC
00000062 mov esi,eax
00000064 mov eax,dword ptr [ebp-2Ch]
00000067 mov eax,dword ptr [eax+4]
0000006a mov dword ptr [esi+4],eax
0000006d push dword ptr ds:[02286B98h]
00000073 mov edx,esi
00000075 mov ecx,edi
00000077 call 786C17F4
0000007c mov esi,eax
0000007e push 0
00000080 push 10h
00000082 mov edx,dword ptr ds:[02286B9Ch]
00000088 mov ecx,esi
0000008a call 7A5BEBB0
0000008f nop
00000090 mov dword ptr [ebp-24h],1
00000097 nop
00000098 jmp 00000292
0000009d nop
0000009e mov eax,dword ptr [ebp-2Ch]
000000a1 cmp dword ptr [eax+4],0
000000a5 ja 000000AC
000000a7 call 793E4671
000000ac mov ecx,dword ptr [eax+0Ch]
000000af call 786CFD7C
000000b4 mov esi,eax
000000b6 mov eax,dword ptr [ebp-2Ch]
000000b9 cmp dword ptr [eax+4],1
000000bd ja 000000C4
000000bf call 793E4671
000000c4 mov edx,dword ptr [eax+10h]
000000c7 mov ecx,esi
000000c9 call 786CEE5C
000000ce mov edi,eax
000000d0 mov ecx,92494Ch
000000d5 call 791C526C
000000da mov esi,eax
000000dc mov edx,edi
000000de mov ecx,esi
000000e0 call dword ptr ds:[0092498Ch]
000000e6 mov dword ptr [ebp-30h],esi
000000e9 mov eax,dword ptr [ebp-2Ch]
000000ec cmp dword ptr [eax+4],2
000000f0 ja 000000F7
000000f2 call 793E4671
000000f7 mov edx,dword ptr [eax+14h]
000000fa mov ecx,dword ptr [ebp-30h]
000000fd cmp dword ptr [ecx],ecx
000000ff call dword ptr ds:[009249B4h]
00000105 nop
00000106 mov eax,dword ptr [ebp-2Ch]
00000109 cmp dword ptr [eax+4],3
0000010d ja 00000114
0000010f call 793E4671
00000114 mov edx,dword ptr [eax+18h]
00000117 mov ecx,dword ptr [ebp-30h]
0000011a cmp dword ptr [ecx],ecx
0000011c call dword ptr ds:[009249BCh]
00000122 nop
00000123 mov eax,dword ptr [ebp-2Ch]
00000126 cmp dword ptr [eax+4],4
0000012a ja 00000131
0000012c call 793E4671
00000131 mov edx,dword ptr [eax+1Ch]
00000134 mov ecx,dword ptr [ebp-30h]
00000137 cmp dword ptr [ecx],ecx
00000139 call dword ptr ds:[009249C4h]
0000013f nop
00000140 mov eax,dword ptr [ebp-2Ch]
00000143 cmp dword ptr [eax+4],5
00000147 ja 0000014E
00000149 call 793E4671
0000014e mov edx,dword ptr [eax+20h]
00000151 mov ecx,dword ptr [ebp-30h]
00000154 cmp dword ptr [ecx],ecx
00000156 call dword ptr ds:[009249CCh]
0000015c nop
0000015d mov eax,dword ptr [ebp-2Ch]
00000160 cmp dword ptr [eax+4],6
00000164 ja 0000016B
00000166 call 793E4671
0000016b mov edx,dword ptr [eax+24h]
0000016e mov ecx,dword ptr [ebp-30h]
00000171 cmp dword ptr [ecx],ecx
00000173 call dword ptr ds:[009249D4h]
00000179 nop
0000017a mov eax,dword ptr [ebp-2Ch]
0000017d cmp dword ptr [eax+4],7
00000181 ja 00000188
00000183 call 793E4671
00000188 mov edx,dword ptr [eax+28h]
0000018b mov ecx,dword ptr [ebp-30h]
0000018e cmp dword ptr [ecx],ecx
00000190 call dword ptr ds:[009249DCh]
00000196 nop
00000197 mov eax,dword ptr [ebp-2Ch]
0000019a cmp dword ptr [eax+4],8
0000019e ja 000001A5
000001a0 call 793E4671
000001a5 mov edx,dword ptr [eax+2Ch]
000001a8 mov ecx,dword ptr [ebp-30h]
000001ab cmp dword ptr [ecx],ecx
000001ad call dword ptr ds:[009249E4h]
000001b3 nop
000001b4 nop
000001b5 nop
000001b6 jmp 000001E1
000001b8 nop
000001b9 nop
000001ba push 0
000001bc push 10h
000001be mov ecx,dword ptr ds:[02286BA0h]
000001c4 mov edx,dword ptr ds:[02286B9Ch]
000001ca call 7A5BEBB0
000001cf nop
000001d0 mov dword ptr [ebp-24h],1
000001d7 call 792E6289
000001dc jmp 00000292
000001e1 nop
000001e2 mov ecx,7A743FBCh
000001e7 call 791DE034
000001ec mov esi,eax
000001ee mov ecx,esi
000001f0 call 79BC7380
000001f5 mov dword ptr [ebp-34h],esi
000001f8 mov ecx,dword ptr [ebp-34h]
000001fb cmp dword ptr [ecx],ecx
000001fd call 79BC7704
00000202 mov esi,eax
00000204 mov edx,dword ptr ds:[02286BA4h]
0000020a mov ecx,esi
0000020c cmp dword ptr [ecx],ecx
0000020e call 799BA4D4
00000213 nop
00000214 mov ecx,dword ptr [ebp-34h]
00000217 cmp dword ptr [ecx],ecx
00000219 call 79BC7704
0000021e mov esi,eax
00000220 mov ecx,esi
00000222 xor edx,edx
00000224 cmp dword ptr [ecx],ecx
00000226 call 799BA1B0
0000022b nop
0000022c mov ecx,dword ptr [ebp-34h]
0000022f cmp dword ptr [ecx],ecx
00000231 call 79BC79C0
00000236 nop
00000237 mov ecx,dword ptr [ebp-34h]
0000023a cmp dword ptr [ecx],ecx
0000023c call 79BC7A60
00000241 nop
00000242 mov ecx,924B04h
00000247 call 791D84FB
0000024c mov esi,eax
0000024e mov edx,dword ptr ds:[02286BA8h]
00000254 mov ecx,esi
00000256 call 78804DF8
0000025b mov esi,eax
0000025d test esi,esi
0000025f je 00000279
00000261 cmp dword ptr [esi],924B04h
00000267 jne 0000026B
00000269 jmp 00000279
0000026b mov edx,esi
0000026d mov ecx,924B04h
00000272 call 7923BB3C
00000277 mov esi,eax
00000279 mov dword ptr [ebp-38h],esi
0000027c mov edx,dword ptr [ebp-30h]
0000027f mov ecx,dword ptr [ebp-38h]
00000282 cmp dword ptr [ecx],ecx
00000284 call FFC7686C
----------->00000289 nop
0000028a xor edx,edx
0000028c mov dword ptr [ebp-24h],edx
0000028f nop
00000290 jmp 00000292
00000292 nop
00000293 mov eax,dword ptr [ebp-24h]
00000296 lea esp,[ebp-0Ch]
00000299 pop ebx
0000029a pop esi
0000029b pop edi
0000029c pop ebp
0000029d ret


The debugger points to the line with the arrow. I have configured EAC just like the image you included in the zip file.

Here is an image:

IPB Image
Jebus
Did the main omni encoder window pop up at all, or did it just throw the exception? Does Omni Encoder work in standalone mode?
Shade[ST]
@ponchorage : use alt+prtscreen to take a screenshot, and use ['codebox'] (no quotes) to paste your crashlog.
Jebus
New version posted which will print helpfull exception messages in a window for those of you without a debugger smile.gif

Please download and try again with this one if you are having problems. This won't fix the problems, but it will at least tell me what they are!
ponchorage
QUOTE
' date='Jul 12 2006, 21:59' post='411287']
@ponchorage : use alt+prtscreen to take a screenshot, and use ['codebox'] (no quotes) to paste your crashlog.


I did use alt+prtscreen. I'll change it to codebox, though. Thanks.

QUOTE(Jebus @ Jul 12 2006, 21:45) *

Did the main omni encoder window pop up at all, or did it just throw the exception? Does Omni Encoder work in standalone mode?


I already had the main omni encoder window open before I started EAC. Is that what is causing the problem? I'll try closing it and running EAC.

I am able to run OmniEncoder in standalone mode, but I didn't actually try to encode any files. I just configured the settings.

I just noticed that when I started EAC again, OmniEncoder started up, too. Also, the tracks I had ripped before (before cancelling the extraction) showed up within OmniEncoder
windowshade
Nice work: this has real potential.

A couple or three (...has encountered errors and has to close...) crashes which I could not reproduce upon re-ripping. The track being ripped is dropped from the list. (I really wish I could be more specific.) Got it to work by re-trying and leaving the GUI alone altogether.

Are you considering a FLAC module? Is replaygain tagging in the works? Album gain on individual files would win me over as a user for sure. (In fact, I manually delete the track gain from my classical collection: I don't need adjustments of +11 dB on quieter pieces. </off topic>)
Jebus
QUOTE(windowshade @ Jul 12 2006, 20:53) *

Nice work: this has real potential.

A couple or three (...has encountered errors and has to close...) crashes which I could not reproduce upon re-ripping. The track being ripped is dropped from the list. (I really wish I could be more specific.) Got it to work by re-trying and leaving the GUI alone altogether.

Are you considering a FLAC module? Is replaygain tagging in the works? Album gain on individual files would win me over as a user for sure. (In fact, I manually delete the track gain from my classical collection: I don't need adjustments of +11 dB on quieter pieces. </off topic>)

Looking good so far; stay off East Hastings.


Try with the re-loaded version, it should tell you what the exception is this time. Does it only happen on track #1 when the main window hasn't loaded yet?

Yeah, I'll have modules for all encoders. Or if not, they're super-easy to write (once i release the source). The API is pretty slick, if i do say so myself smile.gif

ReplayGain tagging is a possibility, but frankly any of those post-encoding options can just be run in a big batch afterwards, right?

What does album gain on individual files mean? Wavegain -a "one-file.wav" and Wavegain "one-file.wav" will give the same result! I must misunderstand you...
ponchorage
Everything seemed to work fine when I didn't start OmniEncoder before starting EAC. One thing that threw me off was that the Amazon album cover finder popped up behind the other windows and I couldn't see it. I was clicking on the main OmniEncoder window and just getting that annoying beep sound.
Jebus
QUOTE(ponchorage @ Jul 12 2006, 20:52) *

QUOTE
' date='Jul 12 2006, 21:59' post='411287']
@ponchorage : use alt+prtscreen to take a screenshot, and use ['codebox'] (no quotes) to paste your crashlog.


I did use alt+prtscreen. I'll change it to codebox, though. Thanks.

QUOTE(Jebus @ Jul 12 2006, 21:45) *

Did the main omni encoder window pop up at all, or did it just throw the exception? Does Omni Encoder work in standalone mode?


I already had the main omni encoder window open before I started EAC. Is that what is causing the problem? I'll try closing it and running EAC.

I am able to run OmniEncoder in standalone mode, but I didn't actually try to encode any files. I just configured the settings.

I just noticed that when I started EAC again, OmniEncoder started up, too. Also, the tracks I had ripped before (before cancelling the extraction) showed up within OmniEncoder


The way it works is this:

EACEncoder does 3 things: It takes parameters from EAC, tries to start Omni Encoder (if it isn't already running), then sends its track info to Omni Encoder. Then it exits. This happens once per track.

So, you can have Omni Encoder running beforehand and EACEncoder will still add tracks to it, or you can have EACEncoder start it automatically after ripping the first track. Heck, you can even close it after the first track is ripped, and then the second track will open it again. Make sense?

So I need to know if EACEncoder is throwing the error when Omni Encoder is already open, or if it is throwing it when it is TRYING to open Omni Encoder. Does that make sense? I assume the latter, since I had lots of problems to iron out before.

(edited for clarity)

QUOTE(ponchorage @ Jul 12 2006, 21:01) *

Everything seemed to work fine when I didn't start OmniEncoder before starting EAC. One thing that threw me off was that the Amazon album cover finder popped up behind the other windows and I couldn't see it. I was clicking on the main OmniEncoder window and just getting that annoying beep sound.


Alright, i'll fix that window focus thing... it was bugging me how EAC kept stealing the focus back anyway. I still can't reproduce your crash though, with Omni Encoder open or closed to begin with it works fine on my machine. I need you to run it with the revised version and tell me what the error is.
windowshade
QUOTE(Jebus @ Jul 12 2006, 23:01) *

What does album gain on individual files mean? Wavegain -a "one-file.wav" and Wavegain "one-file.wav" will give the same result! I must misunderstand you...

Clarification: I'd like to rip albums as individual tracks, then run replay gain album analysis (with tagging, not wavegain adjustment) on the works. I can use foobar for this but it's one more step. I can't get WACK (love it as I do) to do that at all.

Thanks again--I'll repost if I get any more errors.
Jebus
QUOTE(windowshade @ Jul 12 2006, 21:26) *

QUOTE(Jebus @ Jul 12 2006, 23:01) *

What does album gain on individual files mean? Wavegain -a "one-file.wav" and Wavegain "one-file.wav" will give the same result! I must misunderstand you...

Clarification: I'd like to rip albums as individual tracks, then run replay gain album analysis (with tagging, not wavegain adjustment) on the works. I can use foobar for this but it's one more step. I can't get WACK (love it as I do) to do that at all.

Thanks again--I'll repost if I get any more errors.


Gotcha.
ponchorage
I didn't get the error this time around when I tried to open OmniEncoder before EAC.

Sorry for the billion posts. I promise I'm not trying to pad my stats. biggrin.gif

I noticed that if I click on the album art "X" while I'm still ripping it allows me to download the album art, but then immediately starts encoding the tracks that have already been ripped. Is this the desired functionality?

Then, when the whole album finishes ripping I get an error saying, "Unable to decode the file ..." for all the tracks which were in the list when I first clicked on the album art "X". This is becauseit these tracks are currently being encoded by the first dialog that opened when I clicked on the album art "X". They have already been decoded and will disappear from the list when they have finished encoding.
Jebus
QUOTE(ponchorage @ Jul 12 2006, 22:12) *

I didn't get the error this time around when I tried to open OmniEncoder before EAC.

Sorry for the billion posts. I promise I'm not trying to pad my stats. biggrin.gif

I noticed that if I click on the album art "X" while I'm still ripping it allows me to download the album art, but then immediately starts encoding the tracks that have already been ripped. Is this the desired functionality?

Then, when the whole album finishes ripping I get an error saying, "Unable to decode the file ..." for all the tracks which were in the list when I first clicked on the album art "X". This is becauseit these tracks are currently being encoded by the first dialog that opened when I clicked on the album art "X". They have already been decoded and will disappear from the list when they have finished encoding.


Thanks for catching that, it is certainly not the intended functionality.

Edit: Fixed this, and the window focus bug. Also, now when exceptions occur a detailed stack trace will be printed to screen. Please send in screenshots of it if you see one! New zip file has been uploaded. Still not sure what is causing that spurious EACEncoder crash... I need a stack trace!
ponchorage
I got a stack trace for ya! It occured after the first track had ripped and the second was being ripped. I did not open OmniEncoder myself beforehand. After closed the stack trace window, I got another window saying there was an error from the encoder. Sorry, I can't remember exactly what it said. It just listed the options passed to the encoder (track number, name, etc).

IPB Image
Shade[ST]
QUOTE(ponchorage @ Jul 13 2006, 16:17) *

I got a stack trace for ya!

Dude, did you get my PM about how to make smaller screenshots? You're really screwing up the board's formatting...
ponchorage
Sorry, I got your PM after I had posted. I appreciate the tip, though. I'll fix the images in a little while.
Jebus
Thanks, poncho... think its what i was experiencing myself earlier, afterall (OmniEncoder starts up but not completely, so it isn't yet listening when EACEncoder tries to talk to it).

New version uploaded. Please use this one now! And thanks for your help! I'll probably have the real beta ready by tomorrow provided you don't find any more of these crashers.

Encoding works okay? Output files look good?

EDIT: oops, forgot to upload before posting this, so there was a few minutes where the old version was still there. Make sure your .exes and .dlls were modified at 3:01pm today. Sorry about that!
Jebus
Download the official version here.

This thread can now be considered closed. A new one for the beta has been started.
This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.
Invision Power Board © 2001-2008 Invision Power Services, Inc.