Hydrogenaudio Forums > updated foo_uie

david_dl

Jan 19 2006, 04:06

QUOTE(WigBaM @ Jan 17 2006, 11:16 AM)

Also this needs to be dealt with as well please. The problem is when you have multiple sources and one of them is not there album_art shows the last good source in the list instead of continuing skipping until the next good one is found. Hope you'll get it sorted!

Anyway, great job!

Added: Another one, bind 'first source' as a double-click action. Now when I double click the first source shows up only for a brief moment before it switches to second source.

FIXED SOURCE
David, I had a look into the source myself and managed to fix all of the above issues (not the system tray one though):

in uie_albumart.cpp:

CODE

bool uie_albumart::set_image(..
....
if(!file.is_empty()){
Bitmap bmp(string_wide_from_utf8(file.get_ptr()));
if(bmp.GetHeight()){
img=file;
crnsource = n; -ADDED THIS TO FIX ALBUM COVER STAYING ON;
break;
}
}

I've implemented a little walk-around on the issue with double-clicking returning the second source. In the same uie_albumart.cpp:

CODE

LRESULT WINAPI uie_albumart::on_message(HWND wnd1,UINT msg,WPARAM wp,LPARAM lp){
static bool b_dblclick = false; -ADDED THIS VARIABLE TO INDICATE DOUBLE-CLICK
switch(msg)
{
case WM_CREATE:
....
....
break;
case WM_LBUTTONDBLCLK:
click_func(cfg_dblclickfunc);
b_dblclick = true; -ADDED
break;
case WM_LBUTTONUP:
if(!b_dblclick){ -ADDED
click_func(cfg_lftclickfunc);
}
b_dblclick = false;
break;
case WM_MBUTTONUP:

Hope it helps!

Hi. Sorry for the delay, i've been busy with a few other things.

Thanks for the code. Saved me some effort

I'll test and upload updated versions of the DLL and source shortly.

david_dl

Jan 19 2006, 05:47

Done. I uploaded the source too. I haven't tested it much but I'm tired and gotta go sleep now.

VLSI

Jan 19 2006, 09:09

QUOTE(david_dl @ Jan 19 2006, 06:47 AM)

Done. I uploaded the source too.

You seem to have uploaded the old source again. Otherwise, thanks for the update.

david_dl

Jan 19 2006, 14:50

QUOTE(VLSI @ Jan 20 2006, 04:09 AM)

QUOTE(david_dl @ Jan 19 2006, 06:47 AM)

Done. I uploaded the source too.

You seem to have uploaded the old source again. Otherwise, thanks for the update.

Sorry about that. I was trying to get it online as fast as possible at 2am

Try again now (the "source" link at the bottom)

Habla

Jan 19 2006, 15:59

the new binary seems to still exhibit all of the old issues...

WigBaM

Jan 19 2006, 16:03

QUOTE(Habla @ Jan 19 2006, 01:59 PM)

the new binary seems to still exhibit all of the old issues...

works like a charm for me, except for that bug when cover is outdated when restored from system tray.

Habla

Jan 19 2006, 16:09

It still won't scan through all of my sources.

david_dl

Jan 19 2006, 17:07

QUOTE(Habla @ Jan 20 2006, 10:59 AM)

the new binary seems to still exhibit all of the old issues...

Did you get the one from the bottom link? (I've removed the old versions now to avoid confusion) If not, redownload it.

david_dl

Jan 19 2006, 17:13

QUOTE(Habla @ Jan 20 2006, 11:09 AM)

It still won't scan through all of my sources.

Could you explain what you mean by "scan through all of my sources."?
The test i just did is added "-$replace(%_path%,%_filename_ext%,)folder.jpg" and "-match:$replace(%_path%,%_filename_ext%,)*cover.jpg" to my sources, put two images, '1984-cover.jpg' and 'folder.jpg' in D:\Music\Van Halen\1984, then played a track from that folder. The next source function caused it to switch from folder.jpg to cover.jpg. Is this what you mean?

david_dl

Jan 19 2006, 17:16

QUOTE(WigBaM @ Jan 20 2006, 11:03 AM)

QUOTE(Habla @ Jan 19 2006, 01:59 PM)

the new binary seems to still exhibit all of the old issues...

works like a charm for me, except for that bug when cover is outdated when restored from system tray.

Do you mean it fades to the new cover from a really old one? That shouldn't happen anymore, it doesn't for me. Or the cover just doesn't change? I haven't seen that happen on my setup.

ak47mega

Jan 19 2006, 17:30

new version bug
when nocover(default.png) image... focus
next image source not view

previous virsion work fine

my config

match:E:\Media\Music\album_Photo\%_filename%.jpg
E:\Media\Music\album_Photo\%album%.jpg
E:\Media\Music\album_Photo\%album%.gif
-components\default.png

VLSI

Jan 19 2006, 19:01

QUOTE(david_dl @ Jan 19 2006, 03:50 PM)

Try again now (the "source" link at the bottom)

I was hoping to experiment with it a bit, but a number of files are missing so I cannot compile. If it's not too much trouble, please post the whole thing whenever you get around to it. Thanks David.

EDIT: I tried using the older versions of the missing files, but the resource files don't match.

EDIT2: I can confirm ak47mega's bug report. Once you hit a track without an album cover, it gets stuck and won't display other images.

spaceships

Jan 19 2006, 21:59

i get the same bug

Habla

Jan 20 2006, 03:03

Yeah, what they said. My strings worked fine on the previous release. Now it defaults to the my nocover.jpg image.

waileongyeo

Jan 20 2006, 04:06

QUOTE(david_dl @ Dec 21 2005, 10:58 AM)

Haven't tested it much, report any new problems (they are unlikely to be serious. If you are happy with the old version, don't upgrade, this adds nothing new.)

foo_uie_albumart (anim version)-fix

source

Modified source link error,
Probably this?

modified source

Wrong url, I get it from foo_ui_albumart mod files

david_dl

Jan 20 2006, 04:17

QUOTE(Habla @ Jan 20 2006, 10:03 PM)

Yeah, what they said. My strings worked fine on the previous release. Now it defaults to the my nocover.jpg image.

Hmm, maybe I shouldn't have applied WigBaM's fixes without really testing them.
I didn't actually understand the problem he was fixing, I see what's causing the current problem. Could someone outline the original problem and how i can emulate it so I can make a proper fix? (sorry I don't have much time for this at the moment)

WigBaM

Jan 20 2006, 11:36

Sorry guys!
I do apologise! What seemed to be an easy to fix from the first look didn't quite actually worked out! I admit I didn't tested it througly, though it worked with my config.
David, I have sent you a PM with the problem explanation and new working source (I DID some tests on it this time

)

P.S. Confirm system tray bug gone.

david_dl

Jan 20 2006, 18:43

QUOTE(WigBaM @ Jan 21 2006, 06:36 AM)

Sorry guys!
I do apologise! What seemed to be an easy to fix from the first look didn't quite actually worked out! I admit I didn't tested it througly, though it worked with my config.
David, I have sent you a PM with the problem explanation and new working source (I DID some tests on it this time

)

P.S. Confirm system tray bug gone.

No problem, it really was my fault, I should have done at least a few tests

Thanks for all the effort you've put into this, its really appreciated, especially since I have very little time to spend on this atm. So, I present to you, WigBaM's fix (attached to the first post). It works fine in my setup, but I must admit, I only use the most basic functionality (only source folder.jpg, I leave it blank for no cover). I have complete confidence that this will solve your problems, WigBaM has gone to quite a bit of trouble. If it doesnt work, blame me, I probably copy and pasted it wrong

And also, please post here if there are any other issues/features you would like fixed/added. We all want this plugin to improve (maybe simple is good, but surely its more fun to bloat it with obscure features

[just kidding] ), but I'm out of ideas for improvements.

david_dl

Jan 20 2006, 18:55

I noticed it said WigBaM was reading this topic. That was fast. Anyway, I tend to do forum stuff backwards, I made that post, and actually uploading the files and modifying the first post was the last thing i did. (sorry bout that). So you might have to download it again to get the new version.

Habla

Jan 20 2006, 20:16

Problems solved.

Thanks guys!

ak47mega

Jan 20 2006, 21:07

Thanks david_dl and all...

gfngfgf

Jan 21 2006, 00:01

Thanks for the update, WigBaM and david_dl. I can confirm that the album art does not fade when restoring from the system tray (that's a good thing).

gfngfgf

Jan 21 2006, 13:08

Hmm, I downloaded the source last night from the very last link on the first post (the file source_again.rar), and I try to compile it, I get the error that "uie_albumart.h" can't be found. Was this an oversight?

david_dl

Jan 21 2006, 15:28

QUOTE(gfngfgf @ Jan 22 2006, 08:08 AM)

Hmm, I downloaded the source last night from the very last link on the first post (the file source_again.rar), and I try to compile it, I get the error that "uie_albumart.h" can't be found. Was this an oversight?

Damn. Not again. I need to stop uploading these files after midnight. Try again now.

mazy

Jan 21 2006, 15:29

david_dl, thank you for your work on rexy's sources! i have small request - could you, please, add a combobox for selecting the edge style (none / sunken / grey)?

VLSI

Jan 22 2006, 11:58

Great work guys! Just noticed one small bug: when foobar2000 starts up with a track that has no cover, it shows blank instead of the defaulting graphic. It works fine with a track change though.

francesco

Feb 4 2006, 05:10

Great Great plugin!

but i have a problem , i can't move the pannel

i would like to move maybe in the left side of foobar , i'm a novice

um i solved my problem!
after 1 day reading topic , and clicking ...

WigBaM

Feb 4 2006, 08:40

edit: solved

Habla

Feb 4 2006, 14:25

Solved what?

david_dl

Feb 4 2006, 15:44

I understand WigBam has created an updated version of this plugin with a few new features some people would probably like to try

. Please feel free to post your binaries and source here, if they turn out to be a success I can modify the first post to include them.

WigBaM

Feb 4 2006, 16:24

thanks David, I didn't want to post it here without you approving first.

New version 0.050, changes:
+ Added support for multisourcing from single entry
patterns like 'blalbla*' will make ablumart go through all matching files like 'blabla1.jpg', 'blablabla.jpg' etc.
+ Added new optional sliding effect on NextSource
* generally optimised and cleaned the code

Source (fixed sliding effect)
Binary (fixed sliding effect)

Tested it on my config and on various combinations - worked good. Please report any bugs ASAP. Enjoy

david_dl

Feb 4 2006, 18:31

Nice, now I can look at the back and front of my cd cases with a single click

.
One small bug to report; If I use the next source function, so that I'm viewing the back cover, then click on a track in a new album (follow cursor mode), it uses the slide effect instead of the fade effect.
Other than that, excellent work

WigBaM

Feb 4 2006, 20:00

Thanks

I think I fixed that minor issue with sliding effect. New source & binaries uploaded.

gfngfgf

Feb 4 2006, 23:28

I added a foo_uie_albumart page to the wiki, specifically to answer any questions people had about the sources list. Let me know what you think, especially if you think I might have left something out.

I haven't had a chance to play with your new version WigBaM, but it sounds very interesting. Thanks for the update.

WigBaM

Feb 5 2006, 08:02

gfngfgf
I have checked that Wiki you've created and it is GREAT! Thanks! I have added a button on config page which takes you there. I hope you don't mind

ak47mega

Feb 5 2006, 08:23

great plugins and great job

maybe...
automatic change next source possible?
and
streaming special cover

Lance Uppercut

Feb 5 2006, 08:36

Again. Just when I thought this plug-in couldn't get any better, it does. The scrolling to the next source is a great addition. Excellent job!

mazy

Feb 5 2006, 15:33

this new version is indeed very nice

. i would still like to see this implemented: combobox for selecting the edge style (none / sunken / grey). or just checkbox to switch it to 'none' (like 'no border' or something like that).

waileongyeo

Feb 5 2006, 23:41

Great job, WigBaM! Nice visual effect when changing to next source.
Thanks.

Masahiko

Feb 6 2006, 07:12

Thank you !! One of my essential plugin for foobar

Feature would be great :
- Import cover from streaming radio (cover from the web page like http://www.streamingsoundtracks.com/)

francesco

Feb 6 2006, 12:54

thanks

WigBaM

great great plug-in!

Cosmo

Feb 6 2006, 14:42

Re: version 0.050
One problem I'm having now is with searching for images inside subfolders (of an unknown name). I used to use patterns like this -

CODE

-match:$replace(%_path%,%_filename_ext%,)*\*cover*.*

- which would find folders named "art, or artwork, or scans" etc... but now this finds nothing. Is there a way now to search for subfolders without writing a specific name?

Thank you!

adamrc

Feb 6 2006, 15:05

Nice work, everything seems to work well for me. I do have one question. It's a basic question, but maybe someone can help me. I have all my single mp3 files stored in C:\my music and my albums are stored in C:\my music\albums. How can I get album_art to ignore my C:\my music directory and still work for my albums directory?

WigBaM

Feb 6 2006, 16:01

QUOTE(Cosmo @ Feb 6 2006, 12:42 PM)

Re: version 0.050
One problem I'm having now is with searching for images inside subfolders (of an unknown name). I used to use patterns like this -

CODE

-match:$replace(%_path%,%_filename_ext%,)*\*cover*.*

- which would find folders named "art, or artwork, or scans" etc... but now this finds nothing. Is there a way now to search for subfolders without writing a specific name?

Thank you!

Yes, thanks for reporting, it seems at some point I unitnentionaly removed the sub-dir search.
But it's fixed now - here is an update that should work: Download v0.051

QUOTE(adamrc @ Feb 6 2006, 01:05 PM)

Nice work, everything seems to work well for me. I do have one question. It's a basic question, but maybe someone can help me. I have all my single mp3 files stored in C:\my music and my albums are stored in C:\my music\albums. How can I get album_art to ignore my C:\my music directory and still work for my albums directory?

Could you explain a bit further on how your covers are stored and what source config you are using?

adamrc

Feb 6 2006, 16:22

QUOTE

Could you explain a bit further on how your covers are stored and what source config you are using?

In my music albums directory, I have all the artists stored in seperate directories and the folder.jpg is stored in each artist directory. It's displaying the art just fine as it is now. The only problem I am having is that in my single mp3 files directory C:\my music, there is no album art at all, and when I try to play a song from that directory, it searches the entire directory and my hard drive starts searching for album art that is not there. So it temporarily hangs up foobar until the search is complete. I just wanted to have it to where you can tell album_art to completely ignore that one directory. My source config is the original and has not been changed.

WigBaM

Feb 6 2006, 16:36

QUOTE(adamrc @ Feb 6 2006, 02:22 PM)

QUOTE

Could you explain a bit further on how your covers are stored and what source config you are using?

In my music albums directory, I have all the artists stored in seperate directories and the folder.jpg is stored in each artist directory. It's displaying the art just fine as it is now. The only problem I am having is that in my single mp3 files directory C:\my music, there is no album art at all, and when I try to play a song from that directory, it searches the entire directory and my hard drive starts searching for album art that is not there. So it temporarily hangs up foobar until the search is complete. I just wanted to have it to where you can tell album_art to completely ignore that one directory. My source config is the original and has not been changed.

Try using this string:
match:$if($stricmp($replace(%_path%,%_filename_ext%,),'C:\my music\'),<your default image path>,$replace(%_path%,%_filename_ext%,)folder.jpg)

adamrc

Feb 6 2006, 17:03

WigBaM,
Thanks so much for your help. The string you told me to use worked.

Cosmo

Feb 6 2006, 21:54

QUOTE(WigBaM)

QUOTE(Cosmo)

Re: version 0.050
One problem I'm having now is with searching for images inside subfolders (of an unknown name). I used to use patterns like this -

CODE

-match:$replace(%_path%,%_filename_ext%,)*\*cover*.*

- which would find folders named "art, or artwork, or scans" etc... but now this finds nothing. Is there a way now to search for subfolders without writing a specific name?

Thank you!

Yes, thanks for reporting, it seems at some point I unitnentionaly removed the sub-dir search.
But it's fixed now - here is an update that should work: Download v0.051

Thank you for your work! ... but unfortunately v0.051 still isn't finding my sub-dir's

(edit [feb 16 2006]: downloaded 0.051 again, now it works...)

acedriver

Feb 6 2006, 23:16

the new version fixed the crashing i had before.. good job

Echo5ive

Feb 7 2006, 11:08

I have the same problem that was reported on page 1 - I see it in the component list, but it's nowhere in the interface.

In addition to that, I have no panel list either...

Edit: Ah, never mind. I just needed to upgrade ColumnsUI.