v0.31 released featuring incremental search in release list, custominfo fixes, improved "update tags".

Perfect just perfect!! great work

But there are still a few bugs to work out. sometimes when there are multiple artist under a name and you click the other name there are no releases? and the album cover download processbar still stays on the screen sometimes but less than before

Disgogs must be the best music library around, and it is great to have it intregrated in foobar.
Keep up the good work!

Thank you for this great plugin, it almost makes you my personal hero. :-)

Btw... could you please add "gdiplus.dll" to the dependencies? It isn't that obvious that it is a needed dll, and it seems to refuse to work without it. Thanks!

And... a few feature suggestions:

- An addition to the "Write Tags" dialogue: a multiselect field with all available tags, so you can select which fields to tag. (OK, this might be not very important, but is a nice-to-have IMHO.)

- Caching of the information you fetched from discogs e.g. in a local sqlite DB or something similar. Usage scenarios: prefetch content into DB manually (if you have no network connection on the machine you want to tag things), speed up album searching (cache list of releases by an artist and maybe add a "refresh" button), etc.

- Include the "Credits:" line for various artists albums. Ideal would be to have the fields DISCOGS_CREDITS (with the artist who mixed the CD etc, e.g. "Ravin" at buddha bar 6) and DISCOGS_CREDITS_CATEGORY (e.g. DJ Mix, Executive Producer, ... - whatever there is in the string before the dash.)

EDIT: cleared up the list a bit. ;-)

A little bug I noticed in 0.31...
... "Discogs -> Write Tags" doesn't work (it doesn't write any tags), however "Discogs -> Update Tags" does work. Any idea what could cause this?

Thanks!

(I'm just manually filling in the "DISCOGS_RELEASE_ID" field and then use update tags as a workaround, but... I'm hoping for a 0.32 release with this bug fixed. ;-) )

EDIT: I'm using foobar2000 v0.9.4.2.

The empty release list for some artists is not a bug: I only display "releases" and "dj mixes" sections of the relevant web pages, not displaying other categories such as "appears on", "remixes", "production" etc whose listed releases always have a different artist name than the one you search for.
However I see it could be some use to list them and now there's the filter box, I may add them to the release list. For now, if an artist doesn't have releases listed in the panel, it is that they don't have anything as "Releases" or "DJ MIxes".

For the progress bar stuck i've not seen it myself but sometimes receiving data from discogs.com can be slow or stall. The plugin should detect it under 1min and display a error message box if it's the case.
Soon I'll tag a good part of my colection so maybe I'll see the pbm.




Sure it's a dependency, it comes standard with XP I believe , not sure of other version of Windows. foo_uie_albumart use it too.



That's what the tag mapping dialog is for, provided you don't change the config too often (ie for every two releases)



I'd rather support fetching discogs data from local DB dump, when (if) they release such a dump.



Sounds reasonable.

Very strange...can you always reproduce it ? I'm using 0.9.4.1 myself so I'll have to try with 0.9.4.2

Sadly yes. However, this _might_ be a bug in wine (I'm running foobar2000 on linux using wine 0.9.25) as well... however I doubt it, as the tagging with e.g. the freedb plugin works fine. And the tag update function works too, so... it's rather strange.
But I'll see if I can test in in vmware under windows xp as well, to make sure it's not wine-related.



According to foobar2000.org/requirements.html windows 2000 is a supported OS, so it'd be just a nice hint for all other windows 2000 users to have it listed. ;-)

(And yes, it's included in windows xp, it's part of the .net package as well etc.)

You're lucky that I'm also a Linux guy (coding windows plugins): I just tried in wine and there's indeed a problem with writing tags when invoked from "write tags...". As I want this plugin to work perfectly with fb2k under wine, I'll fix this.

Hi,

Great plug-in!!

Just been reading this thread. Here is my vote, a bug? and some wishes.

vote
my vote is for double digit track#

bug?
discogs tags are not always written eg. for http://www.discogs.com/release/789485 (using Write tags..)

wishes
optional use of square brackets [] for remix info instead of ()
option to maintain album art filenames as found
option to maintain artists as found on discogs for artists with 'The' etc as in 'Beatles, The'
possibility to edit tags before accepting
possibility to rename files as well

Keep up the good work.

Cheers,
a3aan

Glad to hear that.

Thanks a lot!


EDIT:

Two new (?) bugs:
- Fetching albumart of discogs #794561 via "Discogs -> Update Album Art" (with "retrieve all available art" and "process only releases[...]" checkboxes activated.) crashes foobar2000 with a cpp runtime error.
- Tagging discogs #54230 results in a broken artist (which should read Add N to (X)), "(" and ")" don't seem to be sufficiently escaped; it results in "Add N to ".

This already an option in the configuration panel, and double digits is the default IIRC



can you be more specific, which tags etc ?



I will not process discogs data, it comes as it is. You probably can convert ( to [ with other fb plugins.



They have some meaningless filenames such as R-789485-1158971146.jpeg so you really don't want this



Good idea



And you can edit them later in the "Properties" standard foobar dialog...that's why I'm not too keen on doing this as the functionality is already there (less convenient maybe but there)



Could be done but I suppose there's some functionality in fb2k that allows to do that based on tags ? Anybody ?

Thanks for the feedback.



I corrected the bug having not tags written in wine...A win32 list API call not implemented as it should.
Will have to look into the album art crash.
Lol on Add to N to (X): the parser remove the trailing artist number which usually is something like Foo (3).
Well you see what happens in that case !

None of the tags starting with DISCOGS are saved. I did work a few times, but somehow it stopped working...

EDIT: I played some more with it. The DISCOGS tags are not saved when the the option ID3v2 Writer Compatibility Mode is checked.




I dont care about the name. Just want to determine the files on discogs are the same as i donwloaded before.

Cheers,
a3aan.

[quote name='bubbleguuum' date='Dec 23 2006, 14:09' post='459246']
[quote name='stampgevaar' post='458668' date='Dec 20 2006, 19:51']
Perfect just perfect!! great work

But there are still a few bugs to work out. sometimes when there are multiple artist under a name and you click the other name there are no releases? and the album cover download processbar still stays on the screen sometimes but less than before
[/quote]

The empty release list for some artists is not a bug: I only display "releases" and "dj mixes" sections of the relevant web pages, not displaying other categories such as "appears on", "remixes", "production" etc whose listed releases always have a different artist name than the one you search for.
However I see it could be some use to list them and now there's the filter box, I may add them to the release list. For now, if an artist doesn't have releases listed in the panel, it is that they don't have anything as "Releases" or "DJ MIxes".



===>

It would be nice if the categories like appears on, remixes etc also show maybe with a checkbutton for those. So if you have that option on, everything on discogs is possible to find with your plugin and that would be great. Cause sometimes I still can't find stuff with your plugin because I forget the album artist or have the wrong album artist tagged and still have to search for the discogs id. and maybe have the option the search for a album or record label with your searchbox, album search isn't really necessary but nice to have and record label would be good to find things quickly and my case that is.

Yep, it now displays all release displayed on an artist page. I tagged some part of my collection yesterday and it was obvious it was missing.

Also fixed the annoying progress popup not disappearing. I'll make a release later today

It seems there is a problem with proxy usage. I'm using proxy and all i get is short hang with zero results. Inputting release number/url results in "wrong release" error.

Here is TCPView screenshot:

Foobar is connecting directly to discogs without using proxy.

I have proxy set both in foobar and iexplore so I wonder where else should I set it and if proxy usage is implemented at all.

To post conclusion. I'm waiting for support anxiously, because the idea is great and I really want to utilise this component.

Ahh didn't thought of proxies! I'll add support for it retrieving fb2k configured proxy and passing that to libcurl.

foo_discogs freezes foobar on a slow internet-connection, as long as data is received. Can you improve this behaviour?
Thank you for your work!

The new artist search is great! But I just found a bug, I think;

Artist names with an "&" character can´t be searched.

For example:
Ost & Kjex
http://www.discogs.com/artist/Ost+%26+Kjex

V0.90 is out! See first post.





You're right, while retrieving data fb2k UI is freezed because retrieving happens in the main thread.
Not sure how to do this properly though (retrieving in a thread is not sufficient because I need to wait for the thread to end and then block).



See "known issues" of 0.90 for an explanation of this

Wonderful piece of software. I love how it's so actively being developed.

I have one suggestion. In the configuration menu, I have the album art save path set as:

x:\covers\%artist% - %album%

which works fine, except for when there is an illegal character in the album or artist name. Sure, I could add a long, clunky replace() in there, but I think it'd be better if there was an option to strip out all illegal characters, which btw are \*|":?></

Yay! Works perfectly. Thank you very much for a great component. No more regexp replace game with masstagger

Yes I noticed that some time ago and forgot about it . I'll replace illegal chars with underscore, but how are you going to tell the source to foo_uie_albumart ? The only way I see is a ugly TAGZ command which replace all illegal chars with "_". Does a TAGZ command exist that format a string so it's compatible with the filesystem ? Would be great.

released v0.91 which mainly fixes album art not retrieved at all in 0.90.

Updated

Your software rocks. Seriously. :-)

Thank you for fixing the album-art stuff... !!

If now just all the special character escaping worked a tad better, your plugin should be included in foobar2000 by default ;-)

Can you possibly make the fetching of the small album art and the automated search for the album artist optional. I mean when you use your plugin it automatically searches for an artist and if it's the wrong artist or when you already have the url your waiting for nothing.
The same for the small album art in the tagging window, it's nice to have but a possibility to switch this of is nicer for mass tagging.
I have noticed when I get the covers afterwards that the tagging goes a lot quicker.
I'm sorry if I sound demanding but I tagged over 1000 albums with your plugin and I have noticed that these are the things that always keep me waiting.

btw the processbar still hangs sometimes but it isn't that much of a deal anyway

hi; I just tried this plugin.
Seems fine but there's something I don't understand.
Why do I have to re-order discogs tracks manually (to match with files on the right) ?
Why doesn't the plugin automatically guess what is best order ?
(I have ticked "automatically match discogs tracks to local tracks")

The automatic reordering is a bit basic as it will only reorder tracks if the number of local files and number of track in the discogs release is the same.

If its equal first it will match the tracks on trac length if this information is available on discogs (typically for CD but less often for vinyl). If there's no track length it will use %tracknumber% in files if available.
Else it won't go further by comparing track names for example.




I tagged quite a bit of my own collection (600 release for now) and I arrive to the same conclusion so look for options to disable fetching of small album art and automatic search, in the next version

your component crashes foobar when I try to update a lot of albums with albumart. it says that it let's the runtime act in a unusual way. It doesn't matter if I chose to update all art or just want the missing covers...

If noticed that it happens when the albums are from a lot of different labels, don't know if it has something to do with it...

sometimes when fetching the album art the progress bar fills up 100% but doesn't close, i have to click cancel.

Not sure if this is to do with it being saved as folder.jpg? as i later changed it to album_art

using latest version

I didn't saw that myself and I update qui a few album with it (over 30Mb of art retrieved)
Can you reproduce on a particular release ? More info on th error that happened ?



It happens rarely but I think it can happen if the focus window is changed when the progress window is displayed. It's just a display bug : art is retrieved correctly

I had the error 2 times but I can't reproduce it, maybe it wasn't your plugin. If I see it again I will post it

Edit: it happens when I want to update album art on a large number of files. say 10a15 complete labels
I get this error => see picture



only happens when I do the album art update thing it's not my foobar I can give you the labels if you need them but you have to wait a while because there quite a lot.

I like this Plug-in a lot, thanks.

Yay,

just checked out the latest version - wicked!

Any chance for a context menu item "Grab Album Art" if Artist and Album tags are present and correct?

Ronny

FB just crashed when I was searching for an artist within the plugin. Then I noticed that right now Discogs is down (for me at least) at the moment - and I think that´s the problem Is there a timeout in foo_discogs? It would also be nice if one would be able to stop searches - Search button turns into a stop button or similar. Not just to battle the timeout problem but also to speed up when trying to find an artist..

Would be lovley.


Still THE plugin of 2006 (and probably 2007)

Have request (don't know if other people are interested but it would be really useful for me) would it be possible to have the artists images (off the artists page - not the release page) downloaded?

also don't know if you've considered my previous request, of adding to your parser the featured artists to a <featured> tag? - it would make me a happy man



Agreed along with SCPL, thanks for the great work

+1
---
its true... when I tagging full label collection with many releases, i dont use internal search engine. i open this page in internet explorer(label or artis page) and copy-paste URLs step-by-step + i have a slow connection so Auto artist searching is really VERY annoying...

and i think for more comfortable work, you need to make the order of buttons more ergonomic:
now i tagging with that way:

1. import folder - all label releases..or artist
2. remove all tags from mp3's (because i dont want to autostart "auto artist searching" - remove it!)
3. select tracks in playlist for tagging
4. press hot key for "Write tags..." - "S" (i manually set it)


// now about ergonomic keys, about what I spoke above
5. then,
5.1 i need to press TAB button 3 times, to make focus on URL - i think this area must be first-focused by default
5.2 press ctrl+v to paste URL
5.3 and then press tab 2 times again to focus on the OK button, to enter... i think buttons should be in that TAB order: 1.URL 2.OK button

(may be this can be automated: if URL, that i manually pasted, have both strings: "http://discogs.com" and "/release/" - then start to search automatically - this checking algorithm will avoid wrong start of searching, in situations when clipboard has some wrong URLs: not on discogs.com, or on discogs.com, but not on release page) so if pasted URL not right i can paste other URL here... so u make script:

when i MANUALLY paste URL to URLstring(default focused), foo_discogs check this pasted URL, and if this right,autostart searching(press ok):

PASTE EVENT:
if (strstr(URL.text,"discogs.com") !=NULL && strstr(URL.text,"/release/") != NULL)
{
auto press OK
}



6 .....and theen .... i turned off auto track matching, because all tracks in folder and in discogs usually goes alphabetically so i just press enter... in this window "write tags" - focused by default.. this is good



---
UPD... another IDEA:

add global static string "previousURL"
and use it here:
//================================
if (
strstr(URL.text,"discogs.com") !=NULL
&& strstr(URL.text,"/release/") != NULL
&& strcmp(URL.text,previousURL) != 0 //not identical <<<< HERE
)
{
strcpy(previousURL,URL.text); // previousURL = URL.text <<<<< and HERE
auto press OK
}


so if i forget somethink... and trying to paste URL that i already tagged right before - it dont press OK button automatically, so i will be noticed that somethink wrong URL is wrong, or previous search was with that URL... so i need to check URL, and if allright, then press enter manually

"5.3 and then press tab 2 times again to focus on the OK button, to enter... i think buttons should be in that TAB order: 1.URL 2.OK button"

Why not just set make the plugin when you press enter it automatically does the ok button. Sort of like a keyboard shortcut in foobar.

I'm also agreed with the automatically searching for artist, this because it isn't handy. Most of the time when your tagging you collection it is because the tags aren't correct and not because you have already did the effort to put a right artist name in the tags.

YEAH! i think too...
-default focus when form loads is on URL
-default action when i press enter is OKbutton.click

so users just need to press ctrl+V and enter (if my script will not operate.. i script is not so hard to realize.. but maybe it will comfortable) what other ppl think about this script that i explained above?



try to remove %artist% in properties before tagging

To much work, then it's quicker to just wait for it

not sure about default focus i can see your point, sometimes it would be useful but other times i prefer to search through foobar.

Def agree about the "Ok" set to enter key.

I also miss having the "Del" key to remove selected file - currently have to click remove

Also - mass moving eg when u want to move more then 1 file up/down should be able to select multiple tracks and hit move up / down

i ripped one of my vinyls and remembered about foo_discogs on this site. worked great. thanks for your work!

Oh wow. I haven't been on the HA forums in a while and this plugin is a pleasant surprise. Looks fantastic, downloading it now!

Why isn't the various contributing people list downloaded and tagged? What I speak of is, in this example, the

Flugelhorn - Bo Rande
French Horn - Lasse Mauritzen
Soprano Vocals - Rebecca Stark

on track 2.

It's because the information is not available in a programmer friendly way. That's what discogs call roles or credits, there are like a zillion of them (http://help.discogs.com/wiki/SubmissionGuidelinesCreditList) some of them standard and other not. I'm figuring a way to retrieve a few of them like "Featuring" or "Vocals" but it's still a hack, that's why I'm a bit reluctant to do it
It'll be written in their own tags (ie %DISCOGS_FEATURING%) and people will have to use the masstager afterwards if they want to put it in %TRACKNAME% for example, using whatever formatting they like.

I'll also probably add a %DISCOGS_CREDITS% tag with all credit per track concatenated which for some track can be huge

You could add them into tags like this:

*person1*: *role1*;*person2*: *role2*;*person3*: *role3*

etc. Personally, I have such lists mapped to INVOLVED PEOPLE LIST, which foobar should map to TIPL, according to the ID3v2.4 standard.

i just plan on displaying %title% then an if statement such as:

$if($meta(discogs_featuring), featuring [%discogs_featuring%],)

v 0.92 is available taking into account a lot of the recent feedback - thanks! :


- add: find release dialog: focus on OK and search buttons is automatically set according to user actions
- add: find release dialog: "auto" option if enabled will auto search for the value of %ARTIST% if the tag has some value
- add: find release dialog: ability to search for non exact artist names, "exact matches" checkbox
toggle display of exact matches and all matches
- add: find release dialog: artist name containing funky characters (&, :, etc) should now return results
- add release dialog: option to display or not the small album art. Allow to gain some time by not fetching it (for display purpose)
- add release dialog: Delete key delete tracks in discogs and local track lists
- chg: connection failure should be more robust if discogs is not responding or no data is received for some time



Next version will fetch some of the track credits!

sensational - I love it