hi. some not serious bug or somethik like this... but this is dont need to release new version i think:

it is about VINYLTRACK again...
when taging CD releases foo_discogs anyway create VINYLTRACK tag and write to it tracks numbers...

for example it happens with this usual releases:
http://www.discogs.com/release/1015158
http://www.discogs.com/release/118605

but i dont think that releases have any importance here...

Though so, as i had the script looking for that field.

Just updated seems to be better, had one parse error tho:
foo_discogs: error: release 239279: XML parse error

Out of interest, say you ammended it to add the artist id is there a way to do batch updates for all my albums instead of doing 1 album at a time?

Found it: the "+" in "C+C Music factory" was producing a wrong URL.



That's what update album/artist art if for, you can select as many files as you want. I usually never write art at tag time but use unpdate instead in batch processing because it can be very very long especially for compilations. Btw looking at the code, update art should write %discogs_artist_id% (while fetching artist art at tag time does not), I've not rechecked it that it works though.


@ Dave_Scream: fixed!

YAY! we love you

for some reason the album art for this release wont download automatically: 1078022

Is the fixed version (without vinyltrack problem) already online? or does it still have to come?

Great update by the way I noticed that the tagging goes a lot quicker then before

Will release a new version tonight, with a fix for a bug in the tag mapping dialog when you set the tag name, it's modifing another tag. Say you change DISCOGS_FORMAT to FORMAT, it would write the format in the genre tag or something.

Bug:
So, I'm having problems with how Discogs tags subsongs on CD releases.

Example:
http://www.discogs.com/release/717241
There are only 9 tracks on this CD. However, foo_discogs wants to number them 1-14:


So, it's not a huge deal, but it is an inaccuracy.

bubbleguuum, could be implemented Featuring/Remix with the new xml API?

Киря, а эти не работают?:

Edit tag mappings/Featuring track credit
Edit tag mappings/Vocals track credit
Edit tag mappings/Remix track credit

Oops.. but I mean write it into the %title% in brackets after actual track title

try somethink like this:

%title% [' ('[Remixed by %DISCOGS_CREDIT_REMIX%][ Vocals by %DISCOGS_CREDIT_VOCALS%][ feat. %DISCOGS_CREDIT_FEATURING%]')']

but there is a problem:
the thing that without API was good now (with api) is bad:

for example this release http://www.discogs.com/release/244132
track 2-07 looks like

2-07 Abattoir (Razormaid Mix) (5:46)
Remix - Razormaid

so if u make previous scheme ull get "Abattoir (Razormaid Mix) (Remixed by Razormaid)" lol

maybe some strstr script will help in this situation... it will look like this %title% $if($strstr(%title%,%DISCOGS_CREDIT_REMIX%),,%DISCOGS_CREDIT_REMIX%)

so if %title% already have %DISCOGS_CREDIT_REMIX% it will not be shown...
---
UPD. ok it was not bad idea: so i started to test this string:

%title% ['('[$if($strstr(%title%,%DISCOGS_CREDIT_REMIX%),,Remixed by %DISCOGS_CREDIT_REMIX%)][$if($strstr(%title%,%DISCOGS_CREDIT_FEATURING%),,feat. %DISCOGS_CREDIT_FEATURING%)][$if($strstr(%title%,%DISCOGS_CREDIT_VOCALS%),,vocals by %DISCOGS_CREDIT_VOCALS%)]')']
---
oh. %DISCOGS_TRACK_CREDITS% do this work...

Dave_Scream

I know, thanks But I don't want only display feat/remix info, so I will use masstager to update %title% and then remove "temporary" fields. I think it's a good idea to embed this actions to the foo_discogs.

sorry for my english

Related to this release: When there are two performers credited in one track, as in track 11's vocalist, it only retrieves one (TTC in this instance.)

Hey, bubbleguuum thx for the great all new api support. I upgraded from 1.02 to 1.11 and I am really pleased by the speedy access. However I came across one possible bug:

I have artist art download enabled but I get an error message "I/O error (win32 #123)"

The files go to the path:

E:\Music\Special Interest\Artist pictures

when I add the path to

"E:\Music\Special Interest\Artist pictures"

I get the message "Object not found"

I tried to download for a couple of releases and it seems to work nowhere.

Any idea?

Cheers,

Chris

thank you for yet another very fine release!

Hej, thanks for this great tagger plugin!

I wondered if combining informations in the mapping is possible.
I mean, you can input any field name to map certain infos to, which is the best thing of all, but specifying the same field name multiple times eventually ends up with only either (perhaps the last one in the list) info getting added to the certain field.
For instance there is the "VINYLTRACK" for the nice vinyl number adding feature, but i'd like it to be added in front of (some might want it at the end in brackets etc) the title data in the same field, is doing that possible with the addition of some symbols or some way? If not yet, i'd be very grateful for such a feature, since it'd take me an other step closer to fully automatized tagging =)

Thanks for the great work with this handy component!
Cheers

Masstagger -> ADD -> format values from other fields ->
Destination field name -> VINYLTRACK
Formatting pattern -> '('%vinyltrack%')'

r u talking about this thing? if yes, i think this is not foo_discogs job...

maybe...... foo_discogs needs some "after tag job" automation-abilities... for example: after tagging - start for these tagged files some mass tagger scripts.. like: "write 'added date' stamp" and some other scripts... or maybe after tag just press some hotkeys.. and these hotkeys will do some job...

for example, in my profile, hotkey R is assigned to mass tagger script wich add "date stamp" to %ADDED%...

but this is not hard for me to just click this hotkey everytime i tag my files =)

I'll release a new version that fixes the reported bugs soon

@DaveScream: as you say it's the masstagger job to eventually retag/reformat stuff using discogs info afterwards. Running custom scripts is a single hotkey away...
I'm running foo_cwb_hook to set %ADDED% when the new files that enter the library instead of invoking the script manually.

@Chris Norman: you have this error because the artist art directory does not exist. Just create it and it should work. In next version the directory is created if it does not exists

Thanks bubbleguuum!

hm i saw this feature, but i dont used it because i thinked that it will tag any files, wich i will drag in list... even dont fully downloaded releases but after ur words i tested it and it really works only when i move files in path wich is in media library...

i have a question...

when i move/rename already downloaded releases from download folder to the right path, i do 2 steps.

first: i click W hotkey, to open mass file renamer, and load "by artist" or "by label" preset and make "move entire parent directory..." - for moving all NFO,SFV,and jpg files to new release path

second: and then im again press W hotkey, and select "rename files"

so firstly i move entire folder to new path, and then i rename files in this new path.

and i want to ask how u make this job? can i do "move" and then "rename" with only one step??

Thanks a lot guys , it really works as i desired! feeling a bit noober than guilty, but your answers were a lot faster than i'd have found the one reading all the tagging threads.
This vinyltrack thingie is still a bit complicated tho, since the field collects the general tracknumber datas too, regardless it's first char is a letter, or just plain numbers which is not too vinylish (or is there a regexp to do this "copy value only with first character alphabet" trick?) .

Thanks again & Cheers!

There's a bug with last released version with VINYLTRACK where for some release it has a numeric value while it should have not. Correctex in next release: now VINYLTRACK has a value only if format is "Vinyl" or "Acetate"




I use "rename or move files " in the "Do what" section of the mass file renamer.
The only problem is that it won't move non-audio files to the destination (such an option would be really useful to have). As in a release directory I only have album art, I always bacth fetch art when files are in their definitive location, not at tag time. So I understand why you must do it in 2 pass in your case

There's no way to know these subtracks are not real tracks and it's a rare case. Just delete the offending subtracks and hit the renumber button but I'm sure you already figured that

v1.12 released!

+ fix: editing a tag mapping could attribute it to the wrong discogs info
+ fix: incomplete url escaping was producing XML parse error (release 239279)
+ fix: %DISCOGS_ARTIST_ID% is now fetched and written with the XML API
+ chg: retrieve art using XML API urls instead of old HTML method (faster)
+ fix: small art preview is now displayed when using the XML API
+ fix: artist art directory is created if it does not exist
+ chg: subtracks are now part of the discogs track listing if they have some length (that mean they are real tracks, instead of separators)
(ex: release 891540, subtracks are skipped)
+ fix: %DISCOGS_CREDIT_FEATURING%, %DISCOGS_CREDIT_VOCALS%, %DISCOGS_CREDIT_REMIX% now handle multiples credits (ex: release 1085782, track 11)
+ add: value written for %ALBUM_ARTIST% when release is a compilation is now configurable (default: "Various Artist")

I realize it's rare, be could a solution be a "combined subtracks" button so that the subtrack names are not lost?

Could you explain how it works ?
putting F:\mp3\artists\ do not create a specific folder for the artist.
OK, I understood..

and putting an invalide filepath (F:/mp3/artists ) makes fb2K crash with a pop up saying "invalid filepath"

No that is not quite correct - Folder exists. I found a way to circumvent: I just copied everything into a folder that does not have spaces and it worked.

BTW the mass update mode now works like a charm. No crashes anymore

it is about multivalued tags
bubbleguuum as i saw on screenshots, u use "playlist tree"... and i have a question:
for example "by artist" query in playlist_tree... what u doing in situation, when there are for example this names:

Umek
Umek vs. Chris Liebing
Ben Long & Umek

and when searching "Umek", "Ben Long & Umek" will be far away from Umek in list, cause "B" is far away from "U"
and i want to see all this releases in just "Umek" folder

so i've tryed to make %album artist% as multivalued tag... and manually edit "Ben Long & Umek" with ";" between artists, for multivalued string...
and then in Query editor i use this: <%album artist%> but all this dont work as it must...

and then i have read the playlist tree info.. and in txt author says that <%tag%> is not working... but this job can be finished by some speial query language in playlist tree...

does anybody know how to make this work? and if yes, maybe foo_discogs can just write artist tag like this "Umek; Chris Liebing" instead of "Umek vs. Chris Liebing"...?

yeah! thanks

I'm using <%STYLE%> to have a release with multiple styles appear in each playlist tree style node. Ex if a release has style Techno and Acid it would be listed in both Techno and Acid categories in the tree. It works because %STYLE% is a multivalue tag
As you said for this to work for artists, %ARTIST% need to be a multi-value tag. I'll add the option in the next release.



Would be difficult to do an UI for that for such a rare case. You're better off manually editing the names afterwards to add the subtracks.



Strange because I had no problem using a directory with white spaces...(as long as it existed with the previous version)

I understand where is the problem was! (ive talked about %album artist%, but not about %artist%)
and the solution is: %album artist% is not always has VALUE!!!
---
and all releases in playlist tree is not showed when using %<album artist>% BECAUSE if %artist% == %album artist% - %album artist% is empty!!! but for example Columns UI if %album artist% empty, uses just %artist

but! when using <%album artist%> scheme, %artist% and %album artist% is no more linked!!!! so... if i use this theme in playlist tree it will show only the releases, with %album artist%...

so another offer: fill the %album artist% tag even if %artist% == %album artist%
---
I checked it right now, and for example here: http://www.discogs.com/release/211645
when i tag, %album artist% is empty
---
no, it is not working...some releases are out of list anyway. im waiting for answer here http://www.hydrogenaudio.org/forums/index....id=521309&#

Thinking about this issue even if %ALBUM ARTIST% always contained a value (all artists, as a multi value tag) it still wouldn't work for compilation becuase in that's case %ALBUM ARTIST% value is "Various Artist".

I'm going to add another tag let's say %ARTIST_MULTI% that will be the same as %ARTIST% but without the join fields between artist. Example : if %ARTIST% is "Foo vs Bar", %ARTIST_MULTI% will contain "Foo; Bar" (as a multi value tag). Then you can just use <%ARTIST_MULTI%> and it should work. Does it cover all the cases ?

well.. this scheme will be good for getting all track list of 1 %artist% and it will show all the tracks of artist... unmixed-from releases of this artist, and mixed from mixes and compilations of other artists, and shure this feature will not be spare. so %artist_multi% +1

but it is good to have a feature for getting only full releases of artist (not just separate tracks from releases with tracklist which contains this artist) ... and for this job %album artist% must be used instead of just %artist%.

and another reason, for example here: http://www.discogs.com/release/924278
release name:
Justus Köhncke vs. Prins Thomas - Elan
tracklist:
A Justus Kohncke - Elan (Prins Thomas Versjon)
B1 Justus Kohncke - Advance (Prins Thomas Diskotek Miks)
B2 Justus Kohncke - Tilda

Prins Thomas here is only as %album artist% so here we need to use %album_artist_multivalued% instead of %artist_multivalued% because the last is not useable (it will contain only Justus Kohncke).

so it will be good to have not just %artist_multi% but and %album_artist_multi% too...

shure when %album_artist_multi% contains "Various Artist" it will be not useable in that case... well it is not so dangerously if playlist_tree will have 1 additional node - "Various Artists"

is there some troubles in how to fill the %album_artist_multi%?
i look now for example here: http://www.discogs.com/release/924278?f=xm..._key=90c962fb19
and see this:
<artists><artist><name>Justus Köhncke</name><join>vs.</join></artist><artist><name>Prins Thomas</name></artist></artists>

so %album_artist_multi% can be constructed from all <artist> in <artists> tag in release.

Good analysis so expect %album_artist_multi% and %artist_multi% in next release.

To respect the guidelines I'll leave %album artist% as it is (ie defined only if there's multiple artists):

"Notes: Field name is ALBUM ARTIST, with no underscore. Tag should exist if and only if an album is by multiple artists, and be contained in every track"

Just some feedback. I get an XML Parse Error for release 850967.

The release is flagged as rejected. Probably this the reason why it doesn't work.

I'd just like to say a big thank you to bubbleguuum for this plugin. I'm a new user to foobar, and reading about this plugin made me want to try out foobar. I originally planned on using foobar with foo_discogs to tag my collection, and then move back to Winamp once it was done. Needless to say, this plugin has made foobar an essential application, I'm a total convert. Winamp will be uninstalled very soon, methinks.

At long last, my MP3's are all (or nearly all, Discogs isn't complete, closer every day and all that) tagged, correctly, with album art, catalog numbers and labels.

Ta muchly!

Thanks, glad you find the plugin useful and to see an ogger convert from winamp to foobar! And with the new foobar 0.9.5 it's an even greater time to make the switch !

wohoho! thank you for this news! i downloaded it right now! and i can se here new File Operations!

so now we have ability to Rename all mp3's to new path and move all .jpg and .nfo from old location to new location simply by 2 clicks =)
---
ahaha! by 1 click!

I haven't moved over to the newer version yet, still on 0.9.4.4., seeing as I'm a brand new user, I'm a little wary of upgrading immediately, although maybe this is just over cautious on my part. Am I missing much functionality staying where I am for the time being? Is it safe to do this without messing up my configuration and preferences?

I've actually got another quick question, about artist art. Currently it's downloaded to a single folder in my music folder, but I've noticed that I've got a few thousand image files, which is going to be a bit of a pain to sort through. Ideally, I'd like each artist image to be downloaded into the album folder, as the album art currently is. This way, I'd have not only the covers but the artist images viewable in foo_uie_albumart. It might also be nice to have the label art, when available, downloaded in the same way.

I'm not sure if this is possible with the current version already, or if not, if it's a possible future feature/option. Maybe it's possible to point foo_uie_albumart to that folder and pick the right images to display?

Any pointers/help would be most appreciated.

[edited for spelling]

You can install 0.9.5 in a different directory if you want to play with it



The idea is that artist art is downloaded in a single directory to avoid duplication of images. You can't download it in the release directory but if more people want it I may add the option.
Using the single artist art single directory, if you didn't figured it out already, you can add a source in foo_uie_albumart like this:



replace i:\artist_art\ with the good directory.
You can even have two album art panel one for album art and one for artist art.

Label art is not fetchable, I may add it.

Didn't think of that, I may well have a play around with that tomorrow.



It's a good idea, for those people who want to save HDD space. Personally, a few MB here and there wouldn't bother me. It'd be nice to have the option at least, but with your solution, it works in any case.

Having said that, I can't get it to work right now, I'm going to play around with it and get it working though. Thanks for you help.

Hmm, I think I've found out why there is a problem. In the Edit tag mappings dialogue, the Original Track Number (internal) tag is mapped to DISCOGS_ARTIST_ID tag, but I can't change that because the Map To: box is greyed out. Write tag is ticked, not greyed out. Therefore, each track has a different artist ID, namely, the same as the track number. Also, the Artist ID is mapped to DISCOGS_ARTIST_ID too, where write tag is greyed out too (I assume that's correct seeing as I have Fetch Artist Art enabled, and the Custom Info box is ticked. Did I maybe change sommething I shouldn't have when I first started using this plugin? Or maybe this is the expected behaviour?

(Sorry to bother you with this, I don't want to be a pain in the neck!)

Also, the path to my artist art is F:\Music\!artist art\???.jpg, it wouldn't be the ! causing a problem would it?

Wow this is wrong and I wonder how it hapenned. Try clicking the "default mappings" button to see if "Original Track Number" is resetted to DISCOGS_ORIGINAL_TRACK_NUMBER

I did that, and now the Original Track Number is routed to DISCOGS_ORIGINAL_TRACK_NUMBER, but now it's not fetching the artist ID, even though artist ID is checked (greyed out). Weird.

While using some previous version of foo_discogs (I know it wasn't 1.12), I noticed that some tags written by foo_discogs were disappearing. It seems completely random, and happened to maybe one track out of an album and never a whole album at a time.

This can cause problems with foo_dop. Please read/reply to this post if you have any info: http://www.hydrogenaudio.org/forums/index....showtopic=58454

Hi,

where does foo_discogs store its configuration?
I'd like to copy it and use it on a different computer.

Thanks in advance.

EDIT: seems like it was discogs itself that was causing the problem...

Oh and if it's possible please make the "label art fetching" possible, really sounds like a cool idea.

Thanks in advance

since i switched to 0.9.5 i can't get the album arts downloaded by foo_discogs to display.
i use the dfault settings, anyone could hint me at a soultion for this please ?

and props to bubblegum too

When I choose view release,label,artist,etc page I get an error from windows. My extentions are not connected to firefox anymore. Could you tell me what extention you use for this command so I can re-connect them?

I hope you understand what I mean, it's difficult to make my self clear because my windows is dutch. If I literally translate the error, it says that I have to go to folder options because there is no program connected to these sort of files.

EDIT: never mind I figured it out sorry