Hi,

I finished a first version of a mp4 input plugin for foobar2000. The code is in audiocoding.com CVS.

Menno

Compiled version for 0.32 temporarily here.

Nice. I don't know if this is a problem with the plugin or the player, but when I load an mp4 with japanese characters, foobar crashes. Any ideas?

I think it's a plugin problem. The MP4 file reading library doesn't support unicode I guess.

Menno

I've got an error too.
Please look at this picture.

is that with unicode characters in filenames or in tags ? mp4 decoder library should never touch filenames, it's all handled by fb2k itself.

Tags are not supported yet for MP4, I'll add that somewhere in January.
The MP4 file library does all the file operations and I don't feel like hacking it too much yet.

Divide by 0 picture doesn't really say much to me, unless Case used some very old code of faad2.

Menno

that's not "hacking", your "plugin" is half-broken if it doesn't use file readers, and your libraries are useless if they don't support file access callbacks (i hope they do, too lazy to look at them).
i should make fb2k open files in no-share mode just to prevent people from doing what you just did.
<insert flame about libvorbis' superiority>

I don't use tags, the characters are only in filenames, if that helps.

oh, and tag updater "pretends to be working" by always returning 1 while it doesn't do anything. thats veeeery bad, it makes users think that they've edited tags on their files while they haven't.

I deleted foobar2000.cfg and the error disappeared.
Now foobar can load mp4 files with Japanese characters.

I'm using unmodified third party source code (Cisco) for reading mp4 files.

I'll change the set_info() return value. (writing some documentation for your API could help (or at least some comments in the code about the return values for each function)).

Menno

from input.h :

am i seeing things ?

Aaargh
I should try reading more than 80 characters per line

Menno

actually, a way to bypass file reader would be very useful in some cases. I mean when there's no file actually, like 'linein://' or 'cda://'. it was easy to handle in winamp2, but in foobar it requires stupid-looking hack.

New version in CVS now. This should make zZzZzZz happy

Menno

New version compiled and uploaded.

Thanks, its working ok.

Can i delete the dll that came with john33's compile (because it wasn't present in your zip file) ?

I must say i'm a bit confused now.

Yes, it's not needed with my compile. I use still good old MSVC6 and all libraries my compiles need are included in anything newer than Win95.

Link points now to version for 0.34.

Excellent work, it now plays my files perfectly! I've been waiting forever for winamp to implement international functionality, but you guys had it beat so quickly. Good job all.

MP4 plugin now also supports tagging.

Menno

Binary for 0.35a uploaded.

who can make a wma plugin for fb2000?

Wow... B) And what about us poor Winamp (l)users?

and here.

There was some problem with tagging in the first version I put in CVS. Please update the binaries with current code.
Also: be sure that if there are still bugs in the tagging... (I didn't encounter any until now) this plugin could screw your files good.

Menno

Just updated here.

Damn, you're quick!
I was just starting to play around with previous version

I tagged couple of files using foo_mp4 and this has 'added' 40-80 kB to filesizes (depends on original size).
Does tag take that space or something went wrong during tagging?

What did you add? Just a few short strings?
What kind of mp4 files were this?

Menno

Psytel MPEG-2 AAC LC, mp4 created with mp4ip (0.9.7 IIRC).
Big one was about 8 min long.
Usual strings (artist, album, title, date, track).

Ok, I'll have a look at this. Does the file still play correctly?

Menno

Yes, both in_mp4 and foo_mp4 play it without problems.

The file library seems to write the hint track twice, I'll see if I can figure out what happens, and try to fix it.

Menno

I did -optimize it in mp4creator and tagged one is about the same size as original.

Ok, but that's not really an option in the plugin, since it requires writing from 1 file to another.

Menno