Help - Search - Members - Calendar
Full Version: Album Art Downloader
Hydrogenaudio Forums > Hydrogenaudio Forum > General Audio
Pages: 1, 2, 3, 4, 5, 6, 7
cuotos
thanks a lot cartman smile.gif -my bad -i really thought i already git the latest version but now i see the difference. stupid me wink.gif I'll try your suggestions -thanks again. smile.gif
tool++
QUOTE(AlexVallat @ Jun 7 2007, 18:34) *

QUOTE(tool++ @ Jun 7 2007, 16:27) *
What on earth, the new UI completely ignores the visual style sad.gif
I think this is a WPF thing. It doesn't use the old windows GDI controls, so if you've a custom visual style then it won't affect how WPF draws. I'm not sure whether MS plans to have custom themes for WPF or not, from what I can tell you can fairly easily change the style of a single application, but there doesn't appear to be any way that a system-wide theme could be done. Even if they did, the theme would have to be written for WPF, it certainly wouldn't support themes that were written for the old GDI system.

Bad news for custom theme users, I'm afraid, as WPF becomes more mainstream.

QUOTE(tool++ @ Jun 7 2007, 16:27) *
Could you please fix the bugs in 0.6 before you continue development with the other one? Thanks! smile.gif
Um, no, sorry. I looked at the source for the original one, and even poked in a couple of small fixes, but basically I considered it to be unmaintainable. That's why I decided to start a new codebase from scratch. I think its gone rather well, personally, but the original version is still around for those who disagree.

If david_dl, or Marc Landis are still interested in fixing bugs with the original version, then you might have some luck with them.

Alex


Why does this WPF crap need to ignore the visual style? Why not just use windows GDI controls? Or reference parts of the visual style and get its own bloody handling of the visual style (I've seen this done in many nonstandard controls such as the dropdown button on gaim). If whoever created thinks ignoring UI standards is the way to go then I hope it dies a horrible death along with all Java apps that fail to integrate properly.

It is really anti-foobar ethic

</bad mood>

On a more positive note, I do like the new version, if a little unresponsive/slow.
AlexVallat
QUOTE(tool++ @ Jun 12 2007, 23:40) *
Why does this WPF crap need to ignore the visual style?

I think mostly because custom visual styles are bitmap based, and WPF controls are vector based. I might be mistaken, but I was under the impression that Microsoft never officially supported third party visual styles (in fact, didn't you used to have to hack a system dll to get them to work?), so they probably don't regard supporting them as a UI standard.

While it might still die a death, it looks unlikely, as Microsoft are pushing it quite hard. I would say it is more likely to become the underlying rendering system for the OS, with backwards compatible hosting of GDI content within it where required. Vista is already moving that way.
AlexVallat
QUOTE(askbollen @ Jun 12 2007, 16:44) *
I love this plugin, thanks for creating and maintaning it smile.gif

There are a few sites i find useful for finding coverart that arent included in the current set of scripts. I'd be delighted to see them added.

http://rateyourmusic.com/
http://www.audiophileusa.com/


RateYourMusic.boo, as requested :-)

The other one looks a bit specialist, but I suppose I might get round writing a script for it, unless anyone else fancies having a go.

Alex
j8ee
When using the 0.6 alpha 2 version I get messages like this when trying to add the artless folders in the browse window:
System.IO.DirectoryNotFoundException: Could not find a part of the path 'E:\My Music\John Paul Jones - 1999 - Zooma\folder.jpg'.

If I clear the default art filename box, there's no errors, but then every single album folder is considered to not have any artwork...

The folder.jpg filename error also shows up when using foo_run, using -ar "%artist%" -al "%album%" -p "$replace(%_path%,%_filename_ext%,)folder.jpg"

Removing the default filename and configuring the save toolbar works fine however.

But I'm a little confused about these different versions - 0.6 and 0.6 alpha looks completely different?

That alpha version is much more convenient for downloading multiple files when using the save toolbar. Also the preview is better, handling large files. However, the 0.6 XUI(?) version looks better in general, seems more stable, and it works very well if you only want to dl one single folder pic even if previewing large pictures is a little awkward since they aren't resized.
AlexVallat
QUOTE(j8ee @ Jul 11 2007, 14:30) *
But I'm a little confused about these different versions - 0.6 and 0.6 alpha looks completely different?

Yeah, I appreciate that while they are at the same version number, that's going to be a bit confusing, sorry about that. I'm currently investigating bug reports from a user which, if I can come up with fixes, will result in v0.7, which will make things a bit clearer!

In any case, there are two branches of Album Art Downloader, yes. They are:

Album Art Downloader (currently at v0.6 alpha 2, last updated 2nd March 2007)
Album Art Downloader XUI (currently at v0.6, last updated 10th June 2007)

Album Art Downloader is a continuation of the original CoverDownloader application, with some bug fixes and some additional features added in. The development of it has been taken over by Marc Landis, and I have also contributed some towards it. Marc is busy with other personal matters at the moment, so there has been no development work on this for a while.

Out of the twin desires of continual frustration with working with the CoverDownloader code, and a desire to do something cool using WPF (makes pretty UIs, basically), I decided to re-write Album Art Downloader from the ground up. This project I called XUI (experimental user interface). At the moment it is just me working on it, though I am hoping Marc might join in when (if?) he has more time. Of course others are welcome too, this is an open source project.

I am hoping it will replace the main Album Art Downloader branch in time, but for the moment it lacks some of the functionality that the main branch has, most notably the foobar library browser and presets (like the toolbar save buttons). I don't want to be pushing anyone into taking a step backwards if they rely on these features, so for the moment I'm offering this XUI project as a Preview Release.

I haven't had much time to work on XUI myself recently, but I was happy it had reached a stable and useful plateau. Other than bug fixes, the next feature I want to put into it is Presets. No timetable for this yet, but I wouldn't expect to see anything for at least a few weeks, as I haven't started it yet.

So, in summary:

Album Art Downloader XUI: Newer, prettier, hopefully nicer to use, some new features, command-line compatibility with CoverDownloader (works with REACT2)
Album Art Downloader (0.6 alpha 2): Foobar Library Browser, Toolbar Save presets, less resource-intensive, follows custom Windows Visual Styles.

Hope this helps!

Alex
j8ee
Thanks, that clear things up, yes! I skimmed through this thread, but I got it mixed up... I thought the alpha version was the rewrite, and that development on the XUI one was supposed to be halted in practice. Looking closer at the XUI version, I start to realize the work behind it, and it's got some really nice features. The overview and sorting of pictures is especially good.
AlexVallat
AlbumArt Downloader XUI v0.7 Released

This version is a stability release, with work mostly around memory management and bug fixing. I have also moved the releases to SourceForge, which should mean an end to any problems with downloading.

Download:
See main post for latest version
SoleBastard
QUOTE(AlexVallat @ Jul 15 2007, 10:58) *

AlbumArt Downloader XUI v0.7 Released

This version is a stability release, with work mostly around memory management and bug fixing. I have also moved the releases to SourceForge, which should mean an end to any problems with downloading.


A very nice tool, it does exactly what I would like to have my dream album art find tool do, thank you! biggrin.gif.
Too bad memory usage skyrockets to 1GB (!) and comes to a crawl after 20 albums or so (out of 200). I'm running a fully updated WinXP, any tips to prevent this? I'll be glad to help, just tell me smile.gif
AlexVallat
QUOTE(SoleBastard @ Jul 16 2007, 20:36) *
A very nice tool, it does exactly what I would like to have my dream album art find tool do, thank you! biggrin.gif.
Too bad memory usage skyrockets to 1GB (!) and comes to a crawl after 20 albums or so (out of 200). I'm running a fully updated WinXP, any tips to prevent this? I'll be glad to help, just tell me smile.gif


Damn, I thought I'd fixed the memory issues in 0.7. Does it slow to a crawl when you are using the file browser to search through your collection? Or is it only after you start to download them? If it's not too much hassle, could you check if you get the same problem if you download art for the albums individually, rather than using the queue? (you can double click on an album in the file browser to open a search window for it).

If it's still misbehaving I'll keep looking, and see if there are any other memory leaks I can track down.

Of course, needless to say, if you haven't upgraded to 0.7 yet, then do that!

Alex
SoleBastard
I have a fresh install of 0.7, never used any older version.

Searching with the file browser was not slowing down although it was not very responsive while searching (tested with >1000 albums). Individual downloading of albums is no problem.

The problem was when downloading the album previews (queue lists says 3 simultaneously although I just get 2 search windows). I first tried with >1000 albums in the queue but that was completely impossible because the program went unresponsive (had to force end task). Then I stepped back to queuing around 200 albums which worked ok, a bit slow for my taste but certainly workable. but after I came to album 25 or something memory usage reached 1GB and the program started to slow down and became unresponsive again.

Then I decided to cancel everything in the queue but I saw that was not possible (no 'cancel all' button). So I closed the queue window and then search windows but they just came popping up. Closing down the main window didn't help either. The only way to stop the program was by end task it again.

Again, I really like the concept of the program and I don't like to complain about it. I just report my experiences and I hope you can do something with it wink.gif.
AlexVallat
QUOTE(SoleBastard @ Jul 17 2007, 19:04) *
I have a fresh install of 0.7, never used any older version.

Searching with the file browser was not slowing down although it was not very responsive while searching (tested with >1000 albums). Individual downloading of albums is no problem.

The problem was when downloading the album previews (queue lists says 3 simultaneously although I just get 2 search windows). I first tried with >1000 albums in the queue but that was completely impossible because the program went unresponsive (had to force end task). Then I stepped back to queuing around 200 albums which worked ok, a bit slow for my taste but certainly workable. but after I came to album 25 or something memory usage reached 1GB and the program started to slow down and became unresponsive again.

Then I decided to cancel everything in the queue but I saw that was not possible (no 'cancel all' button). So I closed the queue window and then search windows but they just came popping up. Closing down the main window didn't help either. The only way to stop the program was by end task it again.

Again, I really like the concept of the program and I don't like to complain about it. I just report my experiences and I hope you can do something with it wink.gif.

Thanks for your feedback, it is helpful to know how you've been using it. I'm afraid that having around a thousand albums in the queue is pretty much always going to be unworkable without a redesign of the queuing system. I had not considered that anyone would be willing to sit in front of this app searching for 1000 album covers, one after the other. To do a task of that magnitude, I'd be looking at designing an entirely different sort of UI, but I'm afraid for the moment, I'm considering it outside of the scope of this project.

I certainly agree that there should be a Cancel All button, I'll see that it gets in there for the next release. Perhaps some sort of warning when queuing large numbers of searches too.

To easily end the program, though, you ought to be able to just go to File/Exit, which avoids using End Task.

Alex
SoleBastard
Hehe, I guess queuing >1000 albums was a bit too much, to be true I hadn't considered how much time it would take to manually go through all the albums in a row biggrin.gif

File/Exit isn't really working when the program becomes unresponsive (or perhaps I was just too inpatient) smile.gif

As I reported 200 albums in the queue is also not workable. I'll will try and figure out an optimum/maximum queue length somewhere in the future. What would be nice for that is to be able to select multiple folders at once using the browser in the file browser window using standard windows options like drawing a selection box, using ctrl/shift, etc. Or perhaps dragging it from explorer directly into the file browser window? Anyhow, I think I'm just proof that there's always a 'better' fool wink.gif
AlexVallat
QUOTE(SoleBastard @ Jul 17 2007, 22:59) *
Or perhaps dragging it from explorer directly into the file browser window?

I like that. Can't see any reason it wouldn't be possible, so that should make it in to the next release too.

As far as the queue goes, I'm thinking of popping up a warning if you try to queue more than 50. Nice round number, and fairly unlikely that anyone actually wanted to do 50 searches in a row, rather than just selecting everything and choosing "Search".
hal9001
QUOTE(AlexVallat @ Jun 15 2007, 16:25) *

RateYourMusic.boo, as requested :-)

Great site for covers, especially singles, but the script (under 0.6 alpha 2, as the XUI thingy takes the mojo off my pc) gives the following error :
QUOTE
Method 'AlbumArtDownloader.ScriptTask.EstimatedCount' not found.
Ignite339
Could someone PLEASE make a script for revhq.com? I would do it myself but I'm pretty clueless.\

EDIT: Also, the RYM one works great for me, awesome job!
AlexVallat
QUOTE(Ignite339 @ Jul 20 2007, 02:27) *

Could someone PLEASE make a script for revhq.com? I would do it myself but I'm pretty clueless.\

EDIT: Also, the RYM one works great for me, awesome job!

Hmm... they're a bit small. But I suppose they're probably not available anywhere else, they seem a little obscure. Still, the scripting was interesting, so here it is: revhq.boo

Alex
edwardar
First, thanks very much for this program - it's really great!

I have a small problem/request:
I use the AlbumArtDownloader with REACT 2 and it works ok - similarly to the old CoverDownloader - except that the default filename does not seem to be passed through the command line. Because of this, every time I rip a CD, I need manually to change the save location and filename to suit REACT.

Any chance you could incorporate the old command line switch which specified the default filename? Or am I doing something wrong?


Thanks again!

Ed

edit: my mistake, appears to be simply a problem with my REACT config.
AlexVallat
--deleted-- no longer relevant, was a reply to above post.
AlexVallat
AlbumArt Downloader XUI v0.8 Released

Another release, with some new features. I've added Drag and Drop support to drop files and folders on to the File Browser window, a Cancel All button in Queue Manager window, a warning if queueing a large number of searches from the File Browser, and finally the ability to force a Queued search to start immediately, by double clicking it in the Queue window.

Download:
See main post for latest version
dano
Thanks for this program.
I wonder why you are not making your own topic? Would be more clear. I also miss some sort of central documentation. ATM we must dig in this thread.

1. I hope you can add image dimensions to amazon scripts. If you use another query url you can get the resolutions:
CODE

http://ecs.amazonaws.com/onca/xml?Service=AWSECommerceService&AWSAccessKeyId=XXXX
&Operation=ItemSearch&SearchIndex=Music&Keywords=BlaBla&ItemPage=1&ResponseGroup=ItemAttributes,Small,Images

something like that..

2. To see the full picture, you must click on it and hold the mouse button.
For me holding the mouse button down is not so comfortable.
I would prefer if I can click on it, then the image is loaded and I click a second time to close it.
AlexVallat
QUOTE(dano @ Jul 28 2007, 16:21) *
Thanks for this program.
I wonder why you are not making your own topic? Would be more clear. I also miss some sort of central documentation. ATM we must dig in this thread.
I didn't start a new topic, because this is the one everyone knows for Album Art Downloader. I suppose we could all migrate to a new topic, but I don't feel any pressing need to.

Some sort of documentation would be a good thing, yes. Not that I'm volunteering to write it, but I agree in principle that it wouldn't hurt. The wiki page would probably be a good place for it - there is some info there already.

QUOTE(dano @ Jul 28 2007, 16:21) *
1. I hope you can add image dimensions to amazon scripts. If you use another query url you can get the resolutions
Oh, I like that. The amazon script wasn't one of mine, but getting the image dimensions is worth a re-write, certainly. Thanks for the query URL, I've put up a new amazon script that uses it here: amazon.boo

QUOTE(dano @ Jul 28 2007, 16:21) *
2. To see the full picture, you must click on it and hold the mouse button.
For me holding the mouse button down is not so comfortable.
I would prefer if I can click on it, then the image is loaded and I click a second time to close it.
Thanks for the feedback. I wasn't really expecting people to be looking at the images for long, just a quick check that it was the right thing, then release.

I'll probably add an option for click to close somewhere in the next version, but it won't be the default behaviour, as it's a bit non-obvious. In the meantime, if you are holding the button down while it downloads the full size image, you could try clicking and releasing once, then waiting until the 'downloading' icon disappears from the thumbnail before clicking and holding to preview.

Alex
dano
Thanks for the updated script, seems to be fine.
I also think an option for the click behavior is a good way.
Imperecedero
the last version works great even i dont quiet understan why this program is so heavy, my computer dies when i use this program, i takes too long to load....

Anyway great piece of code, but just one thing i think is missing, all my cover art is named "cover.jpg" but apparently AAD use "folder.jpg" format for the File browser function. So when i search inside my music directories AAD found zero album art because they are all named "cover". There is somewhere when i could change the default name from "folder" to "cover".

When i use AAD from foo_run i can tell it to use "cover", bue when i execute it alone, "folder" is the default thing.
AlexVallat
QUOTE(Imperecedero @ Aug 14 2007, 19:03) *
There is somewhere when i could change the default name from "folder" to "cover".
Yes. Click the "Options..." link in the file browser, just under the box where the search path is. This will expand the options for the file browser, one of which is what pattern to use for the image file search. Change this to cover.jpg, and you should be good to go.

For information, this pattern supports wildcards (*) and subfolders wildcards (\**\) too.
Imperecedero
i did exactly what you say but the File Browser is still searching for "folder.jpg" album art. Am i missing something?
AlexVallat
QUOTE(Imperecedero @ Aug 15 2007, 05:22) *

i did exactly what you say but the File Browser is still searching for "folder.jpg" album art. Am i missing something?
So, you start Album Art Downloader, you click File, New, File Browser, click Options and fill in cover.jpg in the image search box. You then click the "Search" button, and the results area fills with albums. The Artwork Status column show what, just "Not Present"? Or does it find a Folder.jpg that it shouldn't? Could you try copying one of your Cover.jpg to Folder.jpg, and see if it is found?

I'm not sure what else I can suggest, that is the way to do it, and it finds cover.jpg just fine for me here. You could try using *.jpg instead, I suppose, that might help.
Imperecedero
jajajajjaja this is why i always failed my english tests, i never read the questions so i never answer what i should.

The options button in the File Browser was always there, i just dont see it. ohmy.gif

Sorry for your time crying.gif
jenzore
Hey, the Artist, Trivialbeing isn't working for me. I don't find any artist's images. Is a the failure of the tool or the websites?

Ok, Temporarily Offline.


Are there any alternatives besides http://www.artisttrivialbeing.org/? And did anybody design a script for it?
hal9001
I love XUI version 0.8. It even seems to load faster than previous XUI builds.

1. I use FB2K via foo_run. My command line is:
CODE
albumart.exe -ar "%artist%" -al "%album% OR %title%" -p "C:\#pix2\CD Covers\%artist% - %album% FRONT (%name%).jpg"

while %name% refers to an internal switch within albumart.exe, and does not derive from foobar. It's great for multiple releases and accidental matches and such.
For some reason this switch is ignored while going to the app. Is there any workaround that could transfer %name% as-is to the app?

2. Wonderful job with the RateYourMusic script. Could anyone post a script for http://www.israel-music.com/? It's more or less the only source for Jewish/Israeli covers.

3. Could you add a command-line option for 'sort by' (name/size/source)?
mobyduck
QUOTE(hal9001 @ Aug 19 2007, 05:27) *
Is there any workaround that could transfer %name% as-is to the app?
Have you tried '%name%'?

HTH.

Alessandro
pholzmann
Rev 0.8 crash report...

CODE
Album Art Downloader has encountered a fatal error, and has had to close.
If you wish to report this error, please include this information, which
has been written to the file: C:\apps\media\audio\REACT2\coverdownloader\errorlog.txt

App version: 0.8.0.0, running on Microsoft Windows NT 5.1.2600 Service Pack 2

System.UnauthorizedAccessException: Access to the path 'C:\Documents and Settings\Pete\Local Settings\Application Data\AlbumArtDownloader\albumart.exe_Url_mu2psj2qqjbnx4e5zddnsbg4k1jy1e5q\0.8.0.0\user.config' is denied.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
   at System.Configuration.Internal.WriteFileContext.FileIsWriteLocked(String FileName)
   at System.Configuration.Internal.WriteFileContext.ReplaceFile(String Source, String Target)
   at System.Configuration.Internal.WriteFileContext.Complete(String filename, Boolean success)
   at System.Configuration.Internal.InternalConfigHost.StaticWriteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
   at System.Configuration.Internal.InternalConfigHost.System.Configuration.Internal.IInternalConfigHost.WriteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
   at System.Configuration.Internal.DelegatingConfigHost.WriteCompleted(String streamName, Boolean success, Object writeContext, Boolean assertPermissions)
   at System.Configuration.ClientSettingsStore.ClientSettingsConfigurationHost.WriteCompleted(String streamName, Boolean success, Object writeContext)
   at System.Configuration.UpdateConfigHost.WriteCompleted(String streamName, Boolean success, Object writeContext)
   at System.Configuration.MgmtConfigurationRecord.SaveAs(String filename, ConfigurationSaveMode saveMode, Boolean forceUpdateAll)
   at System.Configuration.Configuration.SaveAsImpl(String filename, ConfigurationSaveMode saveMode, Boolean forceSaveAll)
   at System.Configuration.Configuration.Save()
   at System.Configuration.ClientSettingsStore.WriteSettings(String sectionName, Boolean isRoaming, IDictionary newSettings)
   at System.Configuration.LocalFileSettingsProvider.SetPropertyValues(SettingsContext context, SettingsPropertyValueCollection values)
   at System.Configuration.SettingsBase.SaveCore()
   at System.Configuration.SettingsBase.Save()
   at System.Configuration.ApplicationSettingsBase.Save()
   at AlbumArtDownloader.Properties.WindowSettings.SaveWindowState()
   at AlbumArtDownloader.Properties.WindowSettings.window_Closing(Object sender, CancelEventArgs e)
   at System.Windows.Window.OnClosing(CancelEventArgs e)
   at AlbumArtDownloader.ArtSearchWindow.OnClosing(CancelEventArgs e)
   at System.Windows.Window.WmClose()
   at System.Windows.Window.WindowFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.UnsafeSendMessage(IntPtr hWnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at System.Windows.Window.InternalClose(Boolean shutdown, Boolean ignoreCancel)
   at System.Windows.Window.Close()
   at AlbumArtDownloader.ArtSearchWindow.AutoCloseOnSave(Object sender, PropertyChangedEventArgs e)
   at System.ComponentModel.PropertyChangedEventHandler.Invoke(Object sender, PropertyChangedEventArgs e)
   at AlbumArtDownloader.AlbumArt.NotifyPropertyChanged(String propertyName)
   at AlbumArtDownloader.AlbumArt.SaveInternal(Object sender)
   at AlbumArtDownloader.AlbumArt.RetrieveFullSizeImage(WaitCallback callback)
   at AlbumArtDownloader.AlbumArt.Save()
   at AlbumArtDownloader.ArtSearchWindow.SaveExec(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
   at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
   at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
   at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
   at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
   at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
   at System.Windows.Controls.Button.OnClick()
   at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
   at System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
   at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.ReRaiseEventAs(RoutedEventArgs args, RoutedEvent newEvent)
   at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
   at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Boolean isSingleParameter, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.InvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Boolean isSingleParameter)
   at System.Windows.Threading.Dispatcher.Invoke(DispatcherPriority priority, Delegate method, Object arg)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
   at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
   at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at System.Windows.Threading.Dispatcher.Run()
   at System.Windows.Application.RunInternal(Window window)
   at System.Windows.Application.Run(Window window)
   at System.Windows.Application.Run()
   at AlbumArtDownloader.App.AlbumArtDownloader.IPriorInstance.Run()
   at AlbumArtDownloader.InstanceMutex.RunAppAsServiceHost(IPriorInstance instance, String channelUri)
   at AlbumArtDownloader.App.Main(String[] args)
pholzmann
0.8 bug report:

Several times now, the downloader has identified GIF or BMP files as valid album art... and renamed them as JPG files while downloading.

I'm not sure whether GIF or BMP's are good album art candidates (it certainly leads me to request file size in KB , and/or file type indicator, as a feature)... but I guarantee renaming to a different extension causes other software to get very confused!

Here's an example:
Artist: Keith Green
Album: The Ministry Years
Source: Google Image

Lots of stuff comes up. Look at the stylized face art, which is silver or green (disc 1, disc 2). The green face, 185x187 size, from Google Images, is a GIF file:
IPB Image
AlexVallat
OK, I haven't checked here for a while, time for some answers:
QUOTE(hal9001 @ Aug 19 2007, 14:27) *
Is there any workaround that could transfer %name% as-is to the app?
I think you use %% to escape a % sign in foo_run, so using %%name%% should do the job.

QUOTE(hal9001 @ Aug 19 2007, 14:27) *
Could anyone post a script for http://www.israel-music.com/? It's more or less the only source for Jewish/Israeli covers.
Sorry, I don't have time at the moment. Perhaps someone else will take a look at it...

QUOTE(hal9001 @ Aug 19 2007, 14:27) *
3. Could you add a command-line option for 'sort by' (name/size/source)?
Sounds reasonable. Should make it into the next version, whenever I get round to one.


QUOTE(pholzmann @ Aug 20 2007, 10:50) *

Rev 0.8 crash report...
Thanks for reporting this. The error has occurred because AAD was unable to read its settings file: "C:\Documents and Settings\Pete\Local Settings\Application Data\AlbumArtDownloader\albumart.exe_Url_mu2psj2qqjbnx4e5zddnsbg4k1jy1e5q\0.8.0.0\user.config". It recieved an Access Denied error. Without being able to load its settings, it can't run. I don't know why your system has denied access to this file for AAD.


QUOTE(pholzmann @ Aug 20 2007, 11:14) *
Several times now, the downloader has identified GIF or BMP files as valid album art... and renamed them as JPG files while downloading.
Make sure that the filename to save your images as ends in .%extension%, instead of .jpg, that way it will name them appropriately.

Alex
hal9001
QUOTE(AlexVallat @ Aug 20 2007, 14:24) *

QUOTE(hal9001 @ Aug 19 2007, 14:27) *
Is there any workaround that could transfer %name% as-is to the app?
I think you use %% to escape a % sign in foo_run, so using %%name%% should do the job.
Brilliant. It works now, only apparently I had to add '(' ')' for the parenthesis I wanted to add for the %name% value, otherwise the statement is completely ignored. Thanks for your help.

One more thing: Even though I have the "new window" option off on albumart.exe and "simultanious runs=1" on foo_run, the app still loads a new window everytime I run a new search from Foobar. Can there be an option to allow allow only one instance/window of the app run?
Poromenos
Hey, are you the Alex Vallat that has byalexv.co.uk? If so, we used to talk a lot on ICQ 10 years ago or so. I see you still have a VB module I wrote in your "Useful stuff library" part (again, assuming it's you).

Anyway, I downloaded your program but can't get it to run. I have .NET 2.0 runtimes installed but the program just crashes on startup... It's a fresh XP install, so I'm probably missing some other dependency.

Edit: Never mind, just noticed the 3 in ".NET 3.0 required" tongue.gif
phunkydizco
Are there any commandline options in the new xui version?
AlexVallat
QUOTE(phunkydizco @ Aug 31 2007, 17:07) *

Are there any commandline options in the new xui version?

Yes. It is command-line compatible with the original CoverDownloader, so should work with React2. The full list of command parameters is:

CODE
/artist Artist to search for (/artist "Artist Name")
May be abbreviated to /ar (/ar "Artist Name")
Parameter name may be omitted
if this is the first parameter ("Artist Name")

/album Album to search for (/album "Album Name")
May be abbreviated to /al (/al "Album Name")
Parameter name may be omitted
if this is the second parameter ("Artist Name" "Album Name")

/path Default path to save art as (/path "\Art\Folder.jpg")
May be abbreviated to /p (/p "\Art\Folder.jpg")
Parameter name may be omitted
if this is the third parameter ("Artist Name" "Album Name" "\Art\Folder.jpg")

The following variables can be used in paths:
%artist% Artist searched for
%album% Album searched for
%name% Name of the image found
%extension% Default file extension for the image
%source% Name of the source where image was found
%size% Dimensions of the image

/f Provided for backwards (/p "\Art" /f "Folder.jpg")
compatibility only. When
specified, the value is
appended to the path.

/localImagesPath
Path to search for local image (/localImagesPath "\Art\Unsorted\**\*.jpg")
files in. If not specified, the
path to save art in is used.

The following variables can be used in paths:
%artist% Artist searched for
%album% Album searched for
* Wildcard, matches any characters
\**\ Subfolder search. Any folders will match
at this point in the path. For example
"\Art\Unsorted\**\*.jpg" will match:
\Art\Unsorted\image.jpg
\Art\Unsorted\misc\image.jpg
\Art\Unsorted\misc\old\image.jpg

"\Art\Unsorted\*\*.jpg" will match only:
\Art\Unsorted\misc\image.jpg

/autoclose Closes the search window after (/autoclose)
saving. To avoid closing, use
Save As.
May be abbreviated to /ac

Append "off" to disable closing (/autoclose off)
the search window after saving,
if this option is on by default.

/sources Searches only the specified (/sources "Amazon,Coveralia")
sources. Others are disabled.
Separate sources with commas.
May be abbreviated to /s

/exclude Does not search the specified (/exclude "Local Files,Google")
sources. Separate sources with
commas.
May be abbreviated to /es
For backwards compatibilty, the
parameter "/ae off" can also be
used to exclude "Local Files".

/fileBrowser (/fileBrowser "\Music")
Opens a File Browser window. If
a path is specified, starts
searching that path immediately.
If no path is specified, the
browser window is just opened. (/fileBrowser)

If other parameters are not
specified, then a search window
will not be shown initially.

phunkydizco
When I search for album art the GUI freezes and I cannot minimize the window.

So my question to the developers: Are the album art downloads running in an own thread? It seems that they are not decoupled from the GUI.
AlexVallat
QUOTE(phunkydizco @ Sep 1 2007, 14:13) *
When I search for album art the GUI freezes and I cannot minimize the window.

So my question to the developers: Are the album art downloads running in an own thread? It seems that they are not decoupled from the GUI.

Yes, the searches and art downloads are running in a non-UI thread, and should not be blocking you from minimising the window, or interacting with other window controls (such as the Stop All link, for example). Are you using the latest (0.8 XUI) version?
phunkydizco
I attached a screenshot of my settings. Perhaps you can test, if you have the same problems?

Click to view attachment
AlexVallat
QUOTE(phunkydizco @ Sep 1 2007, 16:17) *

I attached a screenshot of my settings. Perhaps you can test, if you have the same problems?

Click to view attachment

Thanks for that. I tried running a search with those settings, and it was fine to start with. It does return a very large number of results, though, and as the number of results increased, the responsiveness decreased, unless the search was stopped first.

This is not a case of the search or download threads locking up the UI, but the UI thread itself doing too much work trying to resort, reflow and layout the results list when it has a large number of items in it. I'm currently working on some ideas for improving performance in this area, so hopefully next version will be better.

Until then, I'd generally suggest choosing a few sources you like rather than searching on all of them like that, or using the Stop All button, or setting a low limit on max number of results for the worst offenders like the Google and Amazon searches.

Alex
AlexVallat
On the above point, also should point out that sorting by Size and having automatic downloading of Unknown Size albums, while admittedly useful, does cause the results list to constantly re-sort itself, which adds to the problem. Not that that excuses the poor performance, but until I can get this next version out, it's worth knowing that switching it to sort by name or source will give better performance with large numbers of results.

On a happier note, as part of the work I'm doing on the new version, I've updated a couple of scripts which have become broken by website updates. Here are:

coveralia.boo v0.5
yes24.boo v0.3

PS: Foobar library browsing is now working on my dev build, so that will *definitely* be in 0.9

Alex
suamikim
Hi,

first of all: Great work! I haven't tried the new version for Framework 3.0 but at the moment i'm really satisfied with the one for 2.0.

There is only one thing i'm missing:

A plugin for one of the best cover-sites in the net (imho): www.darktown.to

Because i have no clou about writing such a plugin myself i would really appreciate if someone could do that for me if it's possible!

Thanks,

mik
jahpal
alex xcuse my dome question but if the scripts are not made i dont know how to use them. this scripts wont do me any good . and the other thing is im running v0.6 alpha2 . THANK YOU AnyWay...
AlexVallat
QUOTE(suamikim @ Sep 5 2007, 15:18) *
A plugin for one of the best cover-sites in the net (imho): www.darktown.to

Had a very brief look at that site. Not touching that with a barge pole. Someone else can, if they like.

QUOTE(jahpal @ Sep 7 2007, 04:12) *
alex xcuse my dome question but if the scripts are not made i dont know how to use them. this scripts wont do me any good . and the other thing is im running v0.6 alpha2 . THANK YOU AnyWay...

Sorry, I don't understand what you are asking.

If you are asking how to write a script, then the first thing you're going to need is most likely a good knowledge of Regular Expressions, or some other way of automatically searching for patterns in a page. If you know this, then the easiest way to do a script is to start with an existing one and modify it.

If you are asking how to use a script (.boo) file that you have, then the answer is that you put it in the Scripts folder of wherever you installed album art downloader to ("c:\program files\album art downloader\scripts" for example). It will be picked up next time you run the program.

If you are asking for something else, then please try and explain more clearly what it is.

Alex
suamikim
QUOTE(AlexVallat @ Sep 7 2007, 00:58) *

Had a very brief look at that site. Not touching that with a barge pole. Someone else can, if they like.


Danke für die Antwort. Nachdem ich leider nicht selbst in der Lage bin den 2. Satz selbst zu übersetzen frage ich einfach mal nach, was das genau zu bedeuten hat (dass du es nicht machen wirst kann ich schon rauslesen, aber die genaue Bedeutung des Satzes erschließt sich mir nicht so ganz):

"Not touching that with a barge pole."??

Danke, mfg

ps.: Ich hoffe es stört hier niemanden, wenn ich dieses eine Post in Deutsch verfasse wink.gif
david_dl
http://www.hydrogenaudio.org/forums/index....974#entry149483

QUOTE


"Not touching that with a barge pole."??



Maybe it's the multiple pornographic pop ups, the site being in German, or that it looks orientated towards piracy?
foosion
QUOTE(suamikim @ Sep 7 2007, 09:41) *
"Not touching that with a barge pole."??

It means he doesn't want to get anywhere near it. Another variation of this saying uses the term "a (proverbial) 10 ft pole" (10 ft is approximately 3 m).

QUOTE(suamikim @ Sep 7 2007, 09:41) *
ps.: Ich hoffe es stört hier niemanden, wenn ich dieses eine Post in Deutsch verfasse wink.gif

Don't make a habit of writing your posts in German unless you intend to provide a full English translation. wink.gif
jahpal
Alex you did answer what i needed to know . i thin k pretty clear . thank you
This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.
Invision Power Board © 2001-2008 Invision Power Services, Inc.