Hi folks,
i've found this patch for LAME which add support for album art in the APIC frame of ID3v2 , but i'm not too sure on how to apply the patch to LAME in linux.
Anyone that has done it before?

Ps: this appears to me as the ONLY method to add album art in Id3v2 tags from commnad line, using linux.... am i wrong?

the patch can be found at the Lame Project page at SourceForge

I patched this into 3.97, my decoding fixed version, and you can d/l it from: http://homepage.ntlworld.com/jfe1205/lame3.97dec-fixed-N.zip

It could probably do with a little more testing. I'd appreciate some feedback as, if it's OK, I'll add this at Rarewares.

john33, thanks so much for it. i'm going to download it now . Rest assure i will leave you feedb as soon as i 've got some.





ah, just downloaded... i realised is a .exe , pc file. i really need a Linux solution. Thanks anyway...

ok, patched on a fresh cvs checkout and built statically on debian unstable.

let me know if this works for you:
http://rarewares.org/xmixahlx/lame-cvs-albumart.7z


later

You should feel good today xmixahlx : you helped a total stranger (me) to solve an important issue he had for a long while. For this, i want to Thank You.

It all works wonderfully; I've noticed this is lame 3.98 alpha version, so i did some tests with different encodings and played the file in win xp sp II and Linux: both worked like a charm.

I wounder if there's any known reported issues with this per released....

Are your patches available somewhere for people building from vanilla source?

Thanks.

I'm not clear which patches you're referring to? The patches for the id3 stuff are on the link in the first post. If you mean my decoding fixes, they are in the current CVS Head, ie., 3.98alpha. If you mean the modified 3.97 code, I don't have patches, per se, but I can make the full modified source available.

I was referring to decoding fix actually, and id3 patch didn't apply cleanly to vanilla 3.97 so I didn't want to duplicate work . If you can make the source available it would be appreciated else I can checkout from CVS.

I think that the only files amended were those in this zip: http://homepage.ntlworld.com/jfe1205/lame-...c-fixed-src.zip.

If I'm wrong, let me know and I'll post the full source, but I think these are the ones.

Thanks thats seems to be the decoding fix, id3 modifications seems to be missing , ah btw any reference for what the decoder fix supposed to do? I am doing lame packaging for a Linux distro hence my interest. Thanks.

Ah, sorry, I didn't realise you wanted the full fix. I've just uploaded with the full amendments for both the id3 stuff and the decoding. It's on the same link.

The decoder fix simply provided that the padding at the start and end of the mp3 file was correctly dealt with so that the output was the same number of samples as the original wave input.

I have put up seperate patches against 3.97 @ http://cekirdek.pardus.org.tr/~ismail/patches/lame in case someone needs them. Thanks again!

thanks for those patches cartman & john33

kolossal: you're welcome!

also, it looks pretty stable. not much is experimental according to the changelog:
http://lame.cvs.sourceforge.net/*checkout*...ml/history.html

VBR-NEW is default, so no need to duplicate it - just an fyi.


later

I've now posted win32 lame.exe binaries of both 3.97 and 3.98a11 at Rarewares, for anyone that wants them.

I'm assuming the 3.97 build is the one we discussed. If not, what differences are there in this version? Also, as far as I know, Nyaochi is still developing a fix for using GIFs as source images.

Yes, it's the same. I'll update as and when Nyaochi makes changes.

Thank you for uploading the binary of this patch, john33


I examined the issue with GIF files and found that this is not a bug of the patch.

iTunes does not support MP3 files with a GIF image embedded. When a user attach a GIF image with iTunes, it actually converts the GIF image to PNG automatically. I confirmed that WMP9 could recognize GIF images embedded with this patch.

Although the patch works as it should for GIF images, it is not recommended that you attach GIF images in MP3 files because of the compatibility issue with iTunes.

You're welcome. Thank you for all your efforts, they are much appreciated.

Hi John,
would it be possible to have a Linux version of lame 3.98, latest beta, posted somewhere?
Thanks for your help,
Kolossal

@xmixahlx: Mike, any chance of a lame 3.98b3 compile?

sure,

lame cvs checkout @ 20070618.1700 PST (3.98b3+cvs includes nyaochi's id3 patches)

see here for the log:
http://lame.cvs.sourceforge.net/*checkout*...ml/history.html

compiled with:
--enable-nasm --enable-static


http://rarewares.org/xmixahlx/lame_20070618.7z



later

Many, many thanks guys,
downloading it now.
Will report back once tested.