Help - Search - Members - Calendar
Full Version: Unicode support
Hydrogenaudio Forums > Lossless Audio Compression > WavPack
mkuzmin
Hi.

It would be great if WavPack win32 tools and Winamp plugin get unicode support.

On my computer "language for non-unicode programs" in Windows control panel is set to Russian, so everything works fine for English and Russian titles. But there are issues with Spanish, French and other national symbols:

1) wavpack command-line tools cannot process files with national symbols in file names
2) Winamp plugin converts such titles to ASCII

Thanks.
Liisachan
Hi, I've experienced similar problems too often, but fortunately not with WavPack, except that, in the past WavPack was confused by 0x5C that is not a path separator, one of typical problems of non-unicode apps.
I just looked at wavpack.c, and it already uses UTF-8 internally, but converted from ACP.
Directly accepting WCHAR command line itself should be easy. Just GetCommandlineW. But...

QUOTE(mkuzmin @ Aug 29 2007, 15:56) *

1) wavpack command-line tools cannot process files with national symbols in file names


I don't think you can type Unicode in the dos box anyway. Well, the Run editbox coming up by [Start]->[R] is okay tho... The practical way for the time being is,maybe to call the command line tool via Unicode-enabled frontend such as foobar2000. Maybe. If you are desperate, type dir /x and you can see the 8.3 ansi name of your Unicode-name file.
Egor
QUOTE(Liisachan @ Aug 30 2007, 00:30) *
I don't think you can type Unicode in the dos box anyway.

Hi, use chcp command to change command line codepage:
chcp 65001
- utf-8

chcp 65000
- utf-7
Liisachan
QUOTE(Egor @ Aug 30 2007, 04:47) *

QUOTE(Liisachan @ Aug 30 2007, 00:30) *
I don't think you can type Unicode in the dos box anyway.

Hi, use chcp command to change command line codepage:
chcp 65001
- utf-8

chcp 65000
- utf-7

With them, you might be able to type Unicode in UTF-8 or -7 if you had IMEs that generate UTF-8 or -7.
Actually, even without that, you're already able to use UTF-16 in the dosbox, by copy-and-paste. I'm not sayng Dosbox does not support Unicode. I just said there's no easy way to TYPE so-called Unicode characters.

Anyway. more realistically, I think what was originally meant was, for instance, something like this.

> dir *.wav
2007-01-01 00:00 ansi.wav
2007-01-01 00:00 UNICODE.wav
> wavpack *.wav
ansi.wav:
created ansi.wv in xx secs (lossless xx.xx %)

?????.wav:
can't open file ?????.wav!

**** warning: errors occurred in 1 of 2 files! ****
Egor
QUOTE(Liisachan @ Aug 30 2007, 13:42) *
I just said there's no easy way to TYPE so-called Unicode characters.

Well, one can also select (if he cannot type it in) a unicode filename by using the "name auto-completion feature" (e.g., by pressing TAB, like in Unix shell).

QUOTE(Liisachan @ Aug 30 2007, 13:42) *
?????.wav:
can't open file ?????.wav!

And this really depends on console propgram. In the following example I archived a Chinese-named txt file from console with auto-completion feature:

CODE
D:\audio>chcp 65001
Текущая кодовая страница: 65001

D:\audio>Rar.exe a 1.rar "你好世界!.txt"

RAR 3.70   Copyright (c) 1993-2007 Alexander Roshal   22 May 2007
Shareware version         Type RAR -? for help

Evaluation copy. Please register.

Creating archive 1.rar

Adding    ????!.txt                                                   OK
Done
Liisachan
QUOTE(Egor @ Aug 30 2007, 07:42) *

And this really depends on console propgram. In the following example I archived a Chinese-named txt file from console with auto-completion feature:
Yes, I think that's what the first post is all about. There is a request because it is possible. I personally don't need Unicode support in WavPack so much as for now, but it would surely be a good move. Also like when C:\Path\in\UNICODE\foo.wav.

PS
BTW... one thing that may be important is... if WavPack.exe simply becomes a Unicode app, it will not run on Windows 98/me anymore. There may be still Windows 98 users...

edit: wording
mkuzmin
thanks for your comment, Liisachan!

The issue with "can't open file" error in "wavpack *" command is exactly what I meant.

I'll take a look on chcp tool.

Thanks.
Liisachan
QUOTE(mkuzmin @ Aug 30 2007, 08:42) *

I'll take a look on chcp tool.


mkuzmin, did you try foobar2000 already? It can open UNICODE_NAME.wav etc, and select it in the list, right click->Convert->Convert to->WavPack, voilą you'll get UNICODE_NAME.wv (by default. you could save it as any name you like)
bryant
I have just made an attempt to add Unicode display support to the winamp plugin. This covers the info box and the interface to the media library. Again, I have tested it with 5.01 and 5.35, but I don't have any tagged files that do not work with regular ANSI so any testing is appreciated.

http://www.wavpack.com/winamp_alpha2.zip

Cheers!

David
mkuzmin
Hi Bryant.

this version correctly shows unicode tags in Info box.

In playlist window I was able to see unicode symbols once. Since then I cannot reproduce it - they are converted to ASCII as before. No idea why.

Bad news is medial library stoped to import such files at all. A file with pure ASCII artist and track names but with Spanish symbol in album title is not parsed - all fields are empty.

I'll send you a couple of examples privately.

Thanks.
bryant
Okay, I think I fixed this:

http://www.wavpack.com/winamp_alpha3.zip

The problem was that I was under the impression that winampGetExtendedFileInfoW() would get passed a wide version of the same "dossified" name that gets passed to the ANSI version of the function. Somewhere I read that it was possible to just implement this function to get Unicode tags without having to handle the Unicode filenames, but that seems to be not the case. Anyway, I now handle Unicode filenames and it works great (I created some pathnames and tag info that have combinations of Unicode characters that are impossible to represent in ANSI and it all seemed to work fine).

Thanks for testing! smile.gif

David
mkuzmin
Yes, everything looks fine now. I'll continue to use this alpha and let you know if I find anything else.

Thanks a lot.
bryant
QUOTE(mkuzmin @ Sep 4 2007, 05:32) *

Yes, everything looks fine now. I'll continue to use this alpha and let you know if I find anything else.

Great! Thanks... smile.gif
Silver Wave
What about Audition filter?
bryant
QUOTE(Silver Wave @ Sep 5 2007, 17:41) *

What about Audition filter?

Is there a Unicode issue with the Audition filter? I have never seen any instructions on creating a Unicode version of it...
Silver Wave
QUOTE(bryant @ Sep 6 2007, 07:32) *

QUOTE(Silver Wave @ Sep 5 2007, 17:41) *

What about Audition filter?

Is there a Unicode issue with the Audition filter? I have never seen any instructions on creating a Unicode version of it...


Your answer is here:
http://www.adobeforums.com/cgi-bin/webx/.3bc8bbcf/1

David, can U register in Adobe Forums?
mkuzmin
It's looks like alpha 3 version lost compatibility with Last.fm audioscrobbling plugin for Winamp.
If both plugins are loaded Winamp crashes when I try to play wavpack files. Old version works fine.

I'll do more testing this weekend to provide details.

Thanks.
Mike
mkuzmin
that incompatibility was fixed on last.fm side by new verstion of their client application.

thanks
This is a "lo-fi" version of our main content. To view the full version with more information, formatting and images, please click here.
Invision Power Board © 2001-2008 Invision Power Services, Inc.