Skip to main content

Notice

Please note that most of the software linked on this forum is likely to be safe to use. If you are unsure, feel free to ask in the relevant topics, or send a private message to an administrator or moderator. To help curb the problems of false positives, or in the event that you do find actual malware, you can contribute through the article linked here.
Topic: New tool: React - [Run EAC Tasks] (Read 288700 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

New tool: React - [Run EAC Tasks]

Reply #400

Has anyone else encountered the situation I described above?  I've tried using REACT on 3 different PC's with different hardware and I get the same results on all of them.


I actually ended up getting similar results (a folder full of .wav and .flac.tmp files).  I've found after a couple rips that I am having the problem mentioned in previous posts where the REACT.exe tray icon disappears after awhile.  I should mention that the rips were for heavily scratched CD's in Secure mode on a caching drive, so they took more than a day to complete.  I've unfortunately deleted the logs after deciding to use a simpler solution (I'm okay with less automation), but my last section of my REACT log still had a condition of
Code: [Select]
if 0==1
even though it was indeed the last file.  I was using the default FLAC tracks settings.


This is definitely the part causing the problem.  My REACT icon never disappears but anything after the if 0==1 never executes.  I've gone through the various built-in configs and the ones that lack this work fine but the ones that have it just stop there.  Has anyone else seen this problem or have a workaround?

New tool: React - [Run EAC Tasks]

Reply #401
Okay, a remove and reinstall of REACT and EAC (same versions:  1.00 and .95b4 respectively) fixed all 3 PCs having the issues with this.  Not sure which was the problem but it seems to be working fine now.

Well, except MP4.  Using MP4-tracks or WV_MP4-tracks I get what look like perfectly fine .m4a files but they won't play.  In iTunes v7 and Showtime v3 they attempt to open then just skip to the next song (or do nothing if there is no playlist loaded).  In Winamp v5 I just get 10-30 seconds of static before it skips.  The song length is reported correctly, though.  If I just point directly to the neroaacenc.exe in my REACT Encoders directory from EAC I get perfectly encoded files.

New tool: React - [Run EAC Tasks]

Reply #402
It seems Atomic Parsley was the problem.  Removing the line referring to it in the MP4-tracks config file seemed to work.

I replaced AtomicParsley.exe in the Encoders directory with the new v.9 updated to work with iTunes 7.  It complained about the --writeBack command which I found has been replaced with --overWrite in the new version. 

I've tested with about 10 CDs so far and no issues.  Hopefully these posts will save someone else some time and trouble rather than just taking up space

New tool: React - [Run EAC Tasks]

Reply #403
BUG report

when cd title terminate with ... (3dot)

REACT not encode files
Music is my first love.


New tool: React - [Run EAC Tasks]

Reply #405
BUG report

when cd title terminate with ... (3dot)

mareo not encode files
Do you mean REACT or are you in the wrong thread?

REACT

edit: SOLVED
change in config file
!destdir2=@musicdir@\OGG\$cdartist$\($year$) $album$
with                       
!destdir2=@musicdir@\OGG\$cdartist$\$album$ ($year$)
Music is my first love.

New tool: React - [Run EAC Tasks]

Reply #406
Does anyone have an MP3-TRACKS config that uses album gain and writes v1,v2 and ape tags? Thanks.

New tool: React - [Run EAC Tasks]

Reply #407
Does anyone have an MP3-TRACKS config that uses album gain and writes v1,v2 and ape tags? Thanks.

Not exactly what you had in mind(no APEv2 tags), but i have a script that you maybe could use ? I use it when i rip CDs for my father(he only wants MP3 track files, and don't want a lossless image for archiving). It will encode to -V2 MP3 track files with ID3v1 tags and also ID3v2 tags when the fields are to big to fit in ID3v1 tags(if you want to have ID3v2 tags made always, then just add "--add-id3v2 --pad-id3v2" to the lame.exe part of the script). Then the MP3 track files are Album Gained(with AG clipping prevention) with the use of mp3gain.exe which you will need to download and copy to your REACT\Encoders folder. I have set mp3gain.exe to not write RG and UNDO tags to the files, but if you want to have those tags, then just remove the "-s s" command from the mp3gain.exe part of the script.

Code: [Select]
!Description=Album Gained LAME -V2 MP3 track files with ID3v1(v2) tags.

!destdir1=@musicdir@\$cdartist$ - ($year$) $album$
!dest1=@destdir1@\$track$ - $title$
!Various-dest1=@destdir1@\$track$ - $title$ ($artist$)

@encdir@\lame.exe -V2 --vbr-new --noreplaygain --ignore-tag-errors --ta "@artist@" --tl "@album@" --tt "@title@" --tn "@track@" --ty "@year@" --tg "@genre@" "@source@" "@dest1@.mp3"
del "@source@"
if @islast@==1 (
move "@eaclog@" "@destdir1@\eaclog.txt"
cd /d "@destdir1@"
@encdir@\mp3gain.exe -a -k -s s *.mp3
)


CU, Martin.

Edit: I guess it would just be a matter of adding Tag.exe to the script after the LAME MP3 encoding to give the files APEv2 tags.

Edit2: Several different corrections...

New tool: React - [Run EAC Tasks]

Reply #408
After much fiddling (I had to change the @islast@==1 test to @track@==@numtracks@ to get anything to happen) I've gotten REACT to SOMETIMES work with the FLAC_MP3-tracks config.  I'll launch it, put a CD in, press F4, EAC will start detecting gaps, and when it's finished, it'll start ripping the tracks.  That works about 60% of the time.

But the rest of the time EAC will either crash with an unhandled exception or it will detect the gaps, write out the cue files, and then stop.  It never starts ripping the tracks and REACT never starts its scripts.  This seems to happen consistently with certain CDs.  Some CDs work right off the bat, some work after repeated crashes/restarts, and some just never work at all.

Any ideas what's causing this?  Is there some more reliable way to start a FLAC/MP3 tracks encoding other than pressing F4?  (I assume REACT is doing some magic to try to intercept that key in EAC.)

I'm using EAC 0.95b4-cdrdao and REACT 1.000, with wnaspi.dll 2.0.1.74 in the EAC folder.  Here's the react.ini file:

Code: [Select]
[Settings]
Config=FLAC_MP3
Version=1.0
EAC=C:\Program Files\Exact Audio Copy\EAC.exe
musicdir=Z:\Music
encdir=C:\Program Files\REACT\Encoders
LogFile=react-log.txt
CodePage=1252
MinimizeCompressionWindow=1
ProcessPriority=1
TracksHotKey={F4}
TracksHotVal=+{F5}
SaveTracksCuesheets=1
ImageHotKey={F10}
ImageNaming=$artist$ - $album$
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-| -||!|'|#|[|]
Debug=0


Thanks.

New tool: React - [Run EAC Tasks]

Reply #409

Does anyone have an MP3-TRACKS config that uses album gain and writes v1,v2 and ape tags? Thanks.

Not exactly what you had in mind(no APEv2 tags), but i have a script that you maybe could use ? I use it when i rip CDs for my father(he only wants MP3 track files, and don't want a lossless image for archiving). It will encode to -V2 MP3 track files with ID3v1 tags and also ID3v2 tags when the fields are to big to fit in ID3v1 tags(if you want to have ID3v2 tags made always, then just add "--add-id3v2 --pad-id3v2" to the lame.exe part of the script). Then the MP3 track files are Album Gained(with AG clipping prevention) with the use of mp3gain.exe(i have set mp3gain.exe to not write RG and UNDO tags to the files, but if you want to have those tags, then just remove the "-s s" command from the mp3gain.exe part of the script). If your music folder is in C:, then remove the "D:" from the script. If your music folder isn't in D:, then change "D:" to the correct drive eg F:.
You will need to download and unpack mp3gain.exe and copy it to your REACT\Encoders folder.

SNIP

Note: This script isn't tested! The script that i use, is on my fathers PC, and since i don't have access to it right now, then i have just made the script again from memmory...

CU, Martin.

Edit: I guess it would just be a matter of adding Tag.exe to the script after the LAME MP3 encoding to give the files APEv2 tags. Also if you don't wan't the files to be perminently altered by mp3gain.exe, then i guess that you could just ammend the mp3gain.exe command line to just do an analys of the files, as that would make mp3gain.exe to put APEv2 RG tags to the files, which you then could use on playback.

Thanks Martin. I did some thinking and decided I don't really need the APE tags but I do want IDsv2.4 and IDSv1 tags. I tried to use just the existing MP3-Tracks script and add "--add-id3v2 --pad-id3v2" as you suggested but MP3 file fails to encode. The DOS window closes quickly and I'm left with a 1KB TMP file and the original wav. This seems to be a problem in  the original script though sinceit happens without the additional switches.

I haven't tried your script yet or looked through the posts to see if anyone has the same problem I have so I'll do that next.

New tool: React - [Run EAC Tasks]

Reply #410
I haven't tried your script yet or looked through the posts to see if anyone has the same problem I have so I'll do that next.

Well I skimmed through the postings and didn't see anyone else having a problem. I gave your script a try and it works but not with the results I'm looking for. Here is the script I had been using.

Code: [Select]
!Description=Wavpack image with embedded cuesheet and EAC log with LAME -V4 mp3 track files, RG album gain

!ImageExt=wv
!CuesheetExt=wv.cue
!WaveGainAnalysis=1
!destdir1=@musicdir@\TAGZ\-RIP\$cdartist$\$album$
!destdir2=@musicdir@\TAGZ\-RIP\$cdartist$\$album$

start @encdir@\albumart.exe "@artist@" "@album@" "@destdir1@\folder.jpg"
@encdir@\wavpack.exe -hmy -w "ARTIST=@artist@" -w "ALBUM=@album@" -w "YEAR=@year@" -w "GENRE=@genre@" -w "REPLAYGAIN_ALBUM_GAIN=@gain@" -w "REPLAYGAIN_ALBUM_PEAK=@peak@" -w "REPLAYGAIN_TRACK_GAIN=@gain@" -w "REPLAYGAIN_TRACK_PEAK=@peak@" -w "CUESHEET=@@cuesheet@" -w "EACLOG=@@eaclog@" "@source@" "@image@"
move "@sourcedir@\@basename@.*" "@destdir1@"
set out2=[$n] $~t
if "$cdartist$"=="Various" set out2=[$n] $~t ($~a)
@encdir@\acdir.exe --overwrite --output "@destdir2@\%out2%.mp3" --pipe "@encdir@\lame.exe -V4 --vbr-new --scale @scale@ --add-id3v2 --pad-id3v2 --ignore-tag-errors --ta $#a --tl $#T --tt $#t --tn $#n --ty $#r{DATE} --tg $#r{GENRE} --tc $qAG applied: @gain@$q - $#o" "@sourcecuesheet@"
del "@source@" "@eaclog@"

It writes a WavPack image and cuesheet with V4 MP3s with AG. I've decided I don't want archives right now and I'm hoping to elliminate some RG work I'm doing in F2K to get AG and TG tags for the MP3s. If possible, I'd also like to write the TOTALTRACKS tag. I notice that neither the AG,TG or TT tags appear in the MP3 files. I also noticed that even though the script specifies track gain, it isn't written to the file (perhaps because it's an image???)

Any ideas? Thanks.

New tool: React - [Run EAC Tasks]

Reply #411
Any ideas? Thanks.

The following script will encode LAME -V2 MP3 track files with ID3v1 + ID3v2 tags. The MP3s are then Album Gained with mp3gain.exe which also stores the RG info as APEv2.0 tags in the MP3s, so that it is possible to change from Album Gain to Track Gain in fb2k or for undoing the gain process completely. When playing the MP3s in a portable player that dosen't support RG, then the MP3s will be played Album Gained. Also there is added a "TOTALTRACKS" APEv2.0 tag to the MP3s. I would recommend that after the ripping and encoding has finished, then load the MP3s into fb2k and rewrite the tags as ID3v1 + ID3v2, so that the APEv2.0 tags are converted to ID3v2 tags and deleted afterwards, but that's of course up to you...

Code: [Select]
!Description=Album Gained LAME -V2 MP3 track files with ID3v1 + ID3v2 + APEv2.0 tags.

!destdir1=@musicdir@\$cdartist$ - ($year$) $album$
!dest1=@destdir1@\$track$ - $title$
!Various-dest1=@destdir1@\$track$ - $title$ ($artist$)

@encdir@\lame.exe -V2 --vbr-new --noreplaygain --add-id3v2 --pad-id3v2 --ignore-tag-errors --ta "@artist@" --tl "@album@" --tt "@title@" --tn "@track@" --ty "@year@" --tg "@genre@" "@source@" "@dest1@.mp3"
del "@source@"
@encdir@\Tag.exe --ape2 -t "TOTALTRACKS=@numtracks@" "@dest1@.mp3"
if @islast@==1 (
move "@eaclog@" "@destdir1@\eaclog.txt"
cd /d "@destdir1@"
@encdir@\mp3gain.exe -a -k *.mp3
)


Edit: Corrected mistake in command line.

New tool: React - [Run EAC Tasks]

Reply #412
Hmm, I might use this. Could I make it do this:

- encode flac -V -8 like i do now with all my tags
- add a TOTALTRACKS tag
- run foobar's replaygain tool on it album-mode
- open up a specified program (my cover art downloader)
err... i'm not using windows any more ;)

New tool: React - [Run EAC Tasks]

Reply #413
Why not use FLAC's inbuilt replaygain?

Basically, the answer is "yes" though.
I'm on a horse.

New tool: React - [Run EAC Tasks]

Reply #414
Would the result of FLAC's replaygain (note I rip to seperate tracks with album gain) be identical to foobars?
err... i'm not using windows any more ;)

New tool: React - [Run EAC Tasks]

Reply #415
But the rest of the time EAC will either crash with an unhandled exception or it will detect the gaps, write out the cue files, and then stop.  It never starts ripping the tracks and REACT never starts its scripts.  This seems to happen consistently with certain CDs.  Some CDs work right off the bat, some work after repeated crashes/restarts, and some just never work at all.

Any ideas what's causing this?  Is there some more reliable way to start a FLAC/MP3 tracks encoding other than pressing F4?  (I assume REACT is doing some magic to try to intercept that key in EAC.)

I'm using EAC 0.95b4-cdrdao and REACT 1.000, with wnaspi.dll 2.0.1.74 in the EAC folder.


Anyone have any ideas about how to fix this?  I thought maybe Azureus was causing it, because REACT seemed to work more reliably when it wasn't running.  But I'm getting errors and crashes again.

Thanks for any help you can give, or suggestions for a more reliable tool for ripping to FLAC and MP3.

New tool: React - [Run EAC Tasks]

Reply #416
To the author of REACT, please review the following thread about the destination folder structure and respond there.

http://www.hydrogenaudio.org/forums/index....st&p=439218

Essentially, the "various-artists" mechanism breaks down on the album "Artist's choice - Sheryl Crow" that has recordings from many artists including Sheryl Crow.

Thanks,
atulc

New tool: React - [Run EAC Tasks]

Reply #417
REACT includes tag.exe which adds id3v1 tags to the resulting tracks. Is there another tagging utility out there that can write id3v2 tags and that could substitute for tag.exe in the REACT configurations? Thanks

New tool: React - [Run EAC Tasks]

Reply #418
Essentially, the "various-artists" mechanism breaks down on the album "Artist's choice - Sheryl Crow" that has recordings from many artists including Sheryl Crow.
Please post your react.ini and config file contents.  Edit: Also, ensure that the "Various Artists" checkbox is checked, and that the track listing is of the format "<artist> / <title>" (as per freedb FAQ 2.2 pt.6).

REACT includes tag.exe which adds id3v1 tags to the resulting tracks. Is there another tagging utility out there that can write id3v2 tags and that could substitute for tag.exe in the REACT configurations? Thanks
http://home.wanadoo.nl/squell/id3.html  Edit: depends what you want to do with it I guess.
I'm on a horse.

New tool: React - [Run EAC Tasks]

Reply #419
To the author of REACT, please review the following thread about the destination folder structure and respond there.

http://www.hydrogenaudio.org/forums/index....st&p=439218

Essentially, the "various-artists" mechanism breaks down on the album "Artist's choice - Sheryl Crow" that has recordings from many artists including Sheryl Crow.

Thanks,
atulc


I am moving further discussion of REACT and the folder structure for various-artists albums to this discussion thread.

I have found a problem with the approach followed by REACT (using EAC) to build the directory structure for FLAC files. I ripped the following three CDs.

  1. Words came back to me - by Sonya Kitchell
  2. Pure moods IV - by various artists
  3. Artist's choice - Sheryl Crow - by various artists


REACT saved the FLAC files for the first two albums in the following directories.

  1. Sonya Kitchell\Words came back to me
  2. Various\Pure moods IV


However, the ripping of the third CD was messed up on two counts.

  1. This CD contains four songs by Sheryl Crow and thirteen tracks from other artists that are among the personal favorites of Sheryl Crow. REACT saved Sheryl Crow's four songs in "Various\Artist's choice - Sheryl Crow". However, each of the songs from other artists was stored in the directory "ARTIST\Artist's choice - Sheryl Crow". Examples of ARTIST include Bob Dylan, Carol King, and Aretha Franklin. This violates my basic requirement that files from a physical CD should be stored in the same directory. iTunes handles this gracefully. It stores all songs from this CD in "Compilation\Artist's Choice - Sheryl Crow". I would really like this to be addressed jointly by the authors of EAC and REACT. This should be easy to fix and would make these tools that much better.

  2. After copying the WAV files generated by EAC to the desination FLAC folders described above, REACT is unable to process WAV to FLAC conversion command. It terminates leaving the WAV files in the destination folders. This is a flaw in the core functionality of REACT. If any REACT developers are following this thread, please address this issue.

Here are my config files for REACT. Except for the Config=FLAC_MP3 in react.ini, everything is just as it was after a fresh installation of REACT.

REACT.ini
Code: [Select]
[Settings]
Config=FLAC_MP3
Version=1.0
EAC=C:\Program Files\Exact Audio Copy\EAC.exe
musicdir=C:\Documents and Settings\Atul K Chhabra\My Documents\My Music
encdir=C:\Program Files\Exact Audio Copy\Encoders
LogFile=
CodePage=1252
MinimizeCompressionWindow=1
ProcessPriority=1
TracksHotKey={F4}
TracksHotVal=+{F5}
SaveTracksCuesheets=0
ImageHotKey={F10}
ImageNaming=$artist$ - ($year$) $album$
Sla_Bks_Col_Qst_Bar_Quo_Ast_Lt_Gt=-|-|-||!|'|#|[|]
Debug=0



FLAC_MP3-tracks.txt

Code: [Select]
!Description=Tagged FLAC and mp3 files with RG album and track tags

!destdir1=@musicdir@\FLAC\$cdartist$\($year$) $album$
!dest1=@destdir1@\$track$ - $title$
!Various-dest1=@destdir1@\$track$ - $title$ ($artist$)

!destdir2=@musicdir@\MP3\$cdartist$\($year$) $album$

echo.> "@dest1@.tmp"
@encdir@\Tag.exe --nocheck --ape2 -t "ARTIST=@artist@" -t "ALBUM=@album@" -t "TRACK=@track@" -t "TITLE=@title@" -t "YEAR=@year@" -t "GENRE=@genre@" -t "TOTALTRACKS=@numtracks@" -t "FREEDB=@freedbid@" -t "CRC=@crc@" "@dest1@.tmp"
move "@source@" "@dest1@.wav"

if @islast@==1 (
  move "@eaclog@" "@destdir1@\eaclog.txt"
  move "@trackscuesheet@.[*].cue" "@destdir1@"
  start @encdir@\albumart.exe "@artist@" "@album@" "@destdir1@\cover.jpg"
  cd /d "@destdir1@"
  @encdir@\Glob.exe -v -c @encdir@\flac.exe -f -5 --replay-gain *.wav
  echo @encdir@\Tag.exe --fromfile "%%INPUT_NAME%%.tmp" "%%INPUT_NAME%%.flac" > encode.bat
  echo @encdir@\lame.exe -V5 --vbr-new --scale %%ALBUM_SCALE%% --tc "AG appl:%%ALBUM_GAIN%%,TG:%%TRACK_GAIN%% dB" "%%INPUT_NAME%%.wav" "@destdir2@\%%INPUT_NAME%%.mp3" >> encode.bat
  echo @encdir@\Tag.exe --fromfile "%%INPUT_NAME%%.tmp" "@destdir2@\%%INPUT_NAME%%.mp3" >> encode.bat
  echo del "%%INPUT_NAME%%.wav" "%%INPUT_NAME%%.tmp" >> encode.bat
  @encdir@\WaveGain.exe -a *.wav --exec call encode.bat
  del encode.bat
)


The EAC settings for Filenames are exactly as after a fresh install of REACT. REACT configures these settings as follows.

Construction of save filenames
Naming scheme: %D - %C - %N - %T
Use various artist naming scheme: checked, set to %D - %C - %N - %T (%A)

When I insert the Sheryl Crow CD into my drive, EAC shows the following information which I fetched from freedb using ALT-G.

CD Title: Artist's Choice - Sheryl Crow
CD Artist: Various
Various Artists Checkbox: Checked
Titles of the individual tracks:
Sheryl Crow / You Can Close Your Eyes
Sheryl Crow / Blue Eyes Crying In The Rain
Sheryl Crow / I Never Loved A Man (The Way I Love You)
Sheryl Crow / The Few That Remain
Bob Dylan / Don't Think Twice, It's All Right
Carole King / So Far Away
Aretha Franklin / I Never Love A Man (The Way I Love You)
...
Rod Stewart / Maggie May
The Band With The Staples Singers / The Weight (Live)

I bought the Sheryl Crow CD from Starbucks. If the EAC/REACT developers need a copy of the CD to determine the problem with the directory structure, I can burn a copy and mail it provided it is used solely for diagnosing this problem.

Please help!
atulc

 

New tool: React - [Run EAC Tasks]

Reply #420
I can't see anything wrong with your setup.

I have created a test config:

Code: [Select]
!Description=Test config to record the values being passed from EAC

!destdir1=@musicdir@\TEST\$cdartist$\$album$
!dest1=@destdir1@\$track$ - $title$
!Various-dest1=@destdir1@\$track$ - $title$ ($artist$)

!destdir2=@musicdir@\TEST
!dest2=@destdir2@\$cdartist$ - $album$ - $track$ - $title$
!Various-dest2=@destdir2@\$album$ - $track$ - $title$ ($artist$)

REM Set log file path
SET testLog="@destdir1@\$album$.txt"

REM Log all interesting values

IF [@track@] EQU [1] (
    ECHO "reactdir:      @reactdir@">>%testLog%
    ECHO "encdir:        @encdir@">>%testLog%
    ECHO "mydocumentsdir: @mydocumentsdir@">>%testLog%
    ECHO "musicdir:      @musicdir@">>%testLog%
    ECHO "sourcedir:      @sourcedir@">>%testLog%
    ECHO "eaclog:        @eaclog@">>%testLog%
    ECHO "destdir1:      @destdir1@">>%testLog%
    ECHO "destdir2:      @destdir2@">>%testLog%
    ECHO.>>%testLog%
    ECHO ==============================================>>%testLog%
    ECHO.>>%testLog%
)

ECHO "basename:      @basename@">>%testLog%
ECHO "source:        @source@">>%testLog%
ECHO "dest1:          @dest1@">>%testLog%
ECHO "dest2:          @dest2@">>%testLog%
ECHO.>>%testLog%

ECHO "cdartist:      @cdartist@ ($cdartist$)">>%testLog%
ECHO "album:          @album@ ($album$)">>%testLog%
ECHO "artist:        @artist@ ($artist$)">>%testLog%
ECHO "title:          @title@ ($title$)">>%testLog%
ECHO "track:          @track@ ($track$)">>%testLog%
ECHO.>>%testLog%

ECHO "numtracks:      @numtracks@ ($numtracks$)">>%testLog%
ECHO "islast:        @islast@">>%testLog%
IF [@track@] EQU [@numtracks@] (
    ECHO "                @track@ EQU @numtracks@">>%testLog%
) ELSE (
    ECHO "                @track@ NEQ @numtracks@">>%testLog%
)
ECHO "genre:          @genre@">>%testLog%
ECHO "year:          @year@">>%testLog%
ECHO "comment:        @comment@">>%testLog%
ECHO "freedbid:      @freedbid@">>%testLog%
ECHO.>>%testLog%

ECHO "crc:            @crc@">>%testLog%
ECHO "bitrate:        @bitrate@">>%testLog%
ECHO "curdate:        @curdate@">>%testLog%
ECHO.>>%testLog%
ECHO ==============================================>>%testLog%
ECHO.>>%testLog%

REM Delete the source WAVE and LOG as we don't need them
DEL "@source@"
IF [@track@] EQU [@numtracks@] DEL "@eaclog@"
Please save this as "TEST-tracks.txt" and put it in your "/Config" folder.  Edit: Please ensure destdir1 is a valid path as it is used as the path for the log file. Then, change "react.ini" to use "TEST", set it going on the Sheryl Crow CD, and post the log created in a CODEBOX to this thread.  It may help.

FYI: Here are two example logs.  The first is using freedb info that got picked up for the test CD I created.  The second is using a VA setup with album, track artist and track names entered by me.  All values are as expected.

Troubador Of The Unknown.txt

Code: [Select]
"reactdir:       C:\Program Files\REACT"
"encdir:        C:\PROGRA~1\REACT\Encoders"
"mydocumentsdir: C:\Documents and Settings\Neil\My Documents"
"musicdir:      C:\Documents and Settings\Neil\My Documents\Audio"
"sourcedir:      C:\Documents and Settings\Neil\My Documents\My Music"
"eaclog:        C:\Documents and Settings\Neil\My Documents\My Music\Troubador Of The Unknown.log"
"destdir1:      C:\Documents and Settings\Neil\My Documents\Audio\TEST\David Mysterious\Troubador Of The Unknown"
"destdir2:      C:\Documents and Settings\Neil\My Documents\Audio\TEST"


"=============================================="


"basename:      David Mysterious - Troubador Of The Unknown - 01 - Red Matthew"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Dtmp1!542.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\David Mysterious\Troubador Of The Unknown\01 - Red Matthew"

"cdartist:      David Mysterious (David Mysterious)"
"album:          Troubador Of The Unknown (Troubador Of The Unknown)"
"artist:        David Mysterious (David Mysterious)"
"title:          Red Matthew (Red Matthew)"
"track:          1 (01)"

"numtracks:      5"
"islast:        0"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            F63DD300"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


"basename:      David Mysterious - Troubador Of The Unknown - 02 - El Toro"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Dtmp660-!.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\David Mysterious\Troubador Of The Unknown\02 - El Toro"

"cdartist:      David Mysterious (David Mysterious)"
"album:          Troubador Of The Unknown (Troubador Of The Unknown)"
"artist:        David Mysterious (David Mysterious)"
"title:          El Toro (El Toro)"
"track:          2 (02)"

"numtracks:      5"
"islast:        0"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            B4B8738D"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


"basename:      David Mysterious - Troubador Of The Unknown - 03 - Caradog Pugh"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Dtmp556)!.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\David Mysterious\Troubador Of The Unknown\03 - Caradog Pugh"

"cdartist:      David Mysterious (David Mysterious)"
"album:          Troubador Of The Unknown (Troubador Of The Unknown)"
"artist:        David Mysterious (David Mysterious)"
"title:          Caradog Pugh (Caradog Pugh)"
"track:          3 (03)"

"numtracks:      5"
"islast:        0"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            687FE9E3"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


"basename:      David Mysterious - Troubador Of The Unknown - 04 - Steve McQueen"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Dtmp58)58.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\David Mysterious\Troubador Of The Unknown\04 - Steve McQueen"

"cdartist:      David Mysterious (David Mysterious)"
"album:          Troubador Of The Unknown (Troubador Of The Unknown)"
"artist:        David Mysterious (David Mysterious)"
"title:          Steve McQueen (Steve McQueen)"
"track:          4 (04)"

"numtracks:      5"
"islast:        1"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            F882028B"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


"basename:      David Mysterious - Troubador Of The Unknown - 05 - Dirty Thort"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Dtmp-!)!3.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\David Mysterious\Troubador Of The Unknown\05 - Dirty Thort"

"cdartist:      David Mysterious (David Mysterious)"
"album:          Troubador Of The Unknown (Troubador Of The Unknown)"
"artist:        David Mysterious (David Mysterious)"
"title:          Dirty Thort (Dirty Thort)"
"track:          5 (05)"

"numtracks:      5"
"islast:        1"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            C3275DC1"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


Test Album.txt

Code: [Select]
"reactdir:       C:\Program Files\REACT"
"encdir:        C:\PROGRA~1\REACT\Encoders"
"mydocumentsdir: C:\Documents and Settings\Neil\My Documents"
"musicdir:      C:\Documents and Settings\Neil\My Documents\Audio"
"sourcedir:      C:\Documents and Settings\Neil\My Documents\My Music"
"eaclog:        C:\Documents and Settings\Neil\My Documents\My Music\Test Album.log"
"destdir1:      C:\Documents and Settings\Neil\My Documents\Audio\TEST\Various\Test Album"
"destdir2:      C:\Documents and Settings\Neil\My Documents\Audio\TEST"


"=============================================="


"basename:      Various - Test Album - 01 - Track One (Artist One)"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Vtmp2(207.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\Various\Test Album\01 - Track One (Artist One)"

"cdartist:      Various (Various)"
"album:          Test Album (Test Album)"
"artist:        Artist One (Artist One)"
"title:          Track One (Track One)"
"track:          1 (01)"

"numtracks:      5"
"islast:        0"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            F63DD300"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


"basename:      Various - Test Album - 02 - Track Two (Artist Two)"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Vtmp!557).wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\Various\Test Album\02 - Track Two (Artist Two)"

"cdartist:      Various (Various)"
"album:          Test Album (Test Album)"
"artist:        Artist Two (Artist Two)"
"title:          Track Two (Track Two)"
"track:          2 (02)"

"numtracks:      5"
"islast:        0"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            B4B8738D"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


"basename:      Various - Test Album - 03 - Track Three (Artist One)"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Vtmp4)!3-.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\Various\Test Album\03 - Track Three (Artist One)"

"cdartist:      Various (Various)"
"album:          Test Album (Test Album)"
"artist:        Artist One (Artist One)"
"title:          Track Three (Track Three)"
"track:          3 (03)"

"numtracks:      5"
"islast:        0"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            687FE9E3"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


"basename:      Various - Test Album - 04 - Track Four (Artist Three)"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Vtmp-91--.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\Various\Test Album\04 - Track Four (Artist Three)"

"cdartist:      Various (Various)"
"album:          Test Album (Test Album)"
"artist:        Artist Three (Artist Three)"
"title:          Track Four (Track Four)"
"track:          4 (04)"

"numtracks:      5"
"islast:        1"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            F882028B"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


"basename:      Various - Test Album - 05 - Track Five (Artist Two)"
"source:        C:\Documents and Settings\Neil\My Documents\My Music\Vtmp65852.wav"
"dest1:          C:\Documents and Settings\Neil\My Documents\Audio\TEST\Various\Test Album\05 - Track Five (Artist Two)"

"cdartist:      Various (Various)"
"album:          Test Album (Test Album)"
"artist:        Artist Two (Artist Two)"
"title:          Track Five (Track Five)"
"track:          5 (05)"

"numtracks:      5"
"islast:        1"
"genre:          Rock"
"year:          2005"
"comment:        DISCNO"
"freedbid:      38035205"

"crc:            C3275DC1"
"bitrate:        128"
"curdate:        2006-10-10"


"=============================================="


Some more info to help you make sense of the logs (CD meta data refers to Test Album.txt):

Naming scheme: %D - %C - %N - %T
Various artist naming scheme: %D - %C - %N - %T (%A)

CD Title: Test Album
CD Artist: Various

Tracks:
Artist One / Track One
Artist Two / Track Two
Artist One / Track Three
Artist Three / Track Four
Artist Two / Track Five

NB: Config file updated to newer version @ 12:08, so the output of my log may not exactly match yours.

FYI: To those interested.  To test I have created a nero NRG file of an audio CD created from 5 MP3s (the first five tracks of the Arctic Monkeys' album in fact).  I have mounted this NRG file using a virtual CD drive and am testing in burst mode.  This make s ripping extremely fast, and allows you to spend more time testing your scripts and less time watching EAC's progress bars.  You can, of course, just use one or two tracks, but I thought five better suited this issue.
I'm on a horse.

New tool: React - [Run EAC Tasks]

Reply #421
@tycho

Not sure if this has been mentioned before, although I know people have had trouble with @islast@.  If you look at the logs above you will see that @islast@ is getting set on track 4/5 not 5/5.  I will try to test with one or more CDs to see if the result is the same, although hopefully atulc's log will provide a second test anyway.

Edit: I've been testing this same CD a few times.  On some occassion @islast@ is set on 4, on others correctly on 5.  I see from the source that it is based on the file modified time of the log file and the last source file.  This doesn't appear to be foolproof; I should know, I am one.  Why not use:

Code: [Select]
$g_islast = ($g_numtracks == $g_track)

?  I'm sure there must be a reason.
I'm on a horse.

New tool: React - [Run EAC Tasks]

Reply #422
Hmm, Thanks. I've noticed that @islast@ is not always correct. I'll try to figure out why, and make a more robust solution.

But to be honest, I don't think it is easy in REACT to fix this. I regret supporting track-based extraction, because it only causes problems, and it is actually not needed: Everything can be achieved with image extraction alone, when using ACDIR for splitting to tracks while compressing.

I wonder if I should make a simpler version of REACT which only supports image extraction (F10), and only have one configuration script, where you can pick and choose from making:

- flac or wavpack image, or tracks with ACDIR
- mp3, ogg, and aac tracks with ACDIR.

I don't see any good reason for making images in lossy formats, although it would be easy enough to add.

The only slight problem with this approach is to add both album and track replaygain tags in an efficient way. Albumgain, which is by far the most important, can be calculated once with WAVEGAIN from the wav image, and applied to all the compressed files in various ways, though.

/Edit: Synthetic Soul, the reason is that it doesn't work if you don't select the last track when extracting. Yes, I know that file timestamp checking is far from foolproof.

New tool: React - [Run EAC Tasks]

Reply #423
I regret supporting track-based extraction, because it only causes problems, and it is actually not needed: Everything can be achieved with image extraction alone, when using ACDIR for splitting to tracks while compressing.

I wonder if I should make a simpler version of REACT which only supports image extraction (F10) <snip>
Interesting.  As an image user I don't really have much opinion on it, but I find it interesting that track ripping has caused such problems.

/Edit: Synthetic Soul, the reason is that it doesn't work if you don't select the last track when extracting. Yes, I know that file timestamp checking is far from foolproof.
Ah, good point.  That's the problem with these projects - you have to try to cater for everyone's personal taste, even though sometimes it makes the easy things so much harder to do, and causes problems for yet more users.  You only have to look at the foobar forum to see the agro that Peter gets.

Thanks tycho.
I'm on a horse.

New tool: React - [Run EAC Tasks]

Reply #424
@atulc

Given the issue with @islast@ it is possible that this is why you are left with some WAVE files on occassion.  I have just tested FLAC_MP3 and I was left with tracks five's WAVE file, as on this occassion @islast@ was (incorrectly) true on track four (not five as it should).

With this in mind, and on the understanding that you are always ripping all tracks, I would replace the line:

Code: [Select]
if @islast@==1 (

with:

Code: [Select]
if @track@==@numtracks@ (


Please do a run with my TEST-tracks config though, to try to ascertain why this CD is acting so strangely.

It may also be worth mentioning the REACT logfile.  if you change the line:

Code: [Select]
LogFile=

to:

Code: [Select]
LogFile=react.log

REACT will write some useful information to the file react.log in your REACT folder.  On this occassion the information should be much the same as my config will write, but it may be useful to use in other circumstances, and possibly in this one too.
I'm on a horse.